| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
output was written all in one line. However, it is really convenient to be able
to grep and count over the file (or generally be able to open it in an editor).
This change is a bit hacky as just using setIndent makes the file completely
expanded with one key-value pair per line, which is also not ideal. With this
change, the format is:
[
{ <entry> },
{ <entry> },
...
{ <entry> }
]
RELNOTES: None
PiperOrigin-RevId: 206758496
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation leads to two identical recursive calls. This isn't harmful as
there is a cache that will make the second call very cheap, but does not seem
right.
As a consequence, a cache is only needed if there are two recursive patterns in
a single glob-path, e.g. /a/b/**/c/**/d/... as either "**" can expand to 0 or
more directories (so /a/b/c/c/d could be reached in two different ways). If
there is only a single recursive pattern, even with "*" placeholders, there is
always a unique expansion (a "*" always represents exactly one path element).
RELNOTES: None.
PiperOrigin-RevId: 206753919
|
|
|
|
|
|
|
|
| |
While at it remove CppCompilationActionBuilder.setAllowUsingHeaderModules,
which isn't used anymore and would make the logic here (even) more complicated.
RELNOTES: None.
PiperOrigin-RevId: 206752281
|
|
|
|
|
|
|
|
| |
Replaced reference to //tools/defaults:crosstool by //tools/cpp:crosstool.
Added Target //tools/cpp:crosstool to base test environment setup.
RELNOTES:none
PiperOrigin-RevId: 206747334
|
|
|
|
|
|
|
|
|
| |
JavaSourceInfoProvider is returned through JavaInfo instead of ConfiguredTarget
for all Java rules. Only android_library and android_binary return it directly
through ConfiguredTarget, since they don't return a JavaInfo provider.
RELNOTES: None.
PiperOrigin-RevId: 206746172
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 206741115
|
|
|
|
| |
PiperOrigin-RevId: 206729076
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a step towards making CppCompileAction work without input discovery.
This works because:
- filterDiscoveredHeaders() is not necessary if we don't discover any
- shouldPruneModules is always false if `shouldScanIncludes` is false (see CppCompileActionBuilder#shouldPruneModules())
RELNOTES: None.
PiperOrigin-RevId: 206721143
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hi,
This PR is for additional work to get the tests running correctly on Aarch64. One key issue was that the default embedded jvm used by default was X86_64 and does not work on other architectures.
To support this I have added a new constraint, however I will refine this in case a version of Darwin becomes available on aarch64.
I'll do the work to find a good arm32 toolchain in a future CL. I do not have access for ppc or z390 to repair those architectures.
Either way, hope this is good for you.
Closes #5525.
PiperOrigin-RevId: 206717726
|
|
|
|
|
| |
RELNOTES: none.
PiperOrigin-RevId: 206717454
|
|
|
|
|
|
|
|
|
| |
supposed to be shared.
Note that CppCompileAction#discoversInputs() will still almost always return true because it's still set to true when .d file pruning is enabled.
RELNOTES: None.
PiperOrigin-RevId: 206716704
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
testenv.sh no longer runs "bazel info bazel-bin"
and "bazel info bazel-genfiles", because the only
test that needs this information is
bazel_sandboxing_test.sh
This saves 1-2 seconds on Windows in every shell
test setup.
Also, on Windows we can safely run Bazel in a
subshell since https://github.com/bazelbuild/bazel/issues/3148 is fixed.
Change-Id: If9873221d536f1acfd4849afbfc83b94311de2bd
Closes #5707.
Change-Id: I04e37c4d5f794017a6050253d8d1b8a8ac43a6d1
PiperOrigin-RevId: 206714921
|
|
|
|
| |
PiperOrigin-RevId: 206697829
|
|
|
|
|
|
|
| |
there are rule errors.
RELNOTES: None.
PiperOrigin-RevId: 206652580
|
|
|
|
| |
PiperOrigin-RevId: 206642715
|
|
|
|
|
|
|
|
|
|
|
| |
This change is focused on 2 things:
- avoid creating builders in case they don't end up being used
- create builders using the maximum expected size to avoid intermediate
allocations to accommodate more elements
Closes #5694.
PiperOrigin-RevId: 206636046
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Concerns were raised about this breaking change, so rolling back to be safe.
*** Original change description ***
Throw a rule error when a skylark rule implementation returns multiple providers of the same type.
RELNOTES: A rule error is now thrown if a Skylark rule implementation function returns multiple providers of the same type.
PiperOrigin-RevId: 206629186
|
|
|
|
|
|
| |
full mapping unless requested. This gets rid of any performance issue for the vast majority of builds. Second, if requested, use a custom data structure so that we don't have to create a full HashSet for artifacts whose only owning labels are their own owner labels.
PiperOrigin-RevId: 206610370
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Java uses dynamically generated proxy classes to access annotation properties
and their methods are ~7X slower than plain getters. According to async-profiler
50%+ of `convertArgumentList` method time is spent in dynamic proxy methods, so
optimizing their performance makes sense.
This also makes the model less anemic, since POJOs can actually provide business
methods.
Closes #5666.
PiperOrigin-RevId: 206608812
|
|
|
|
|
|
|
|
|
|
|
| |
implementations in SkyQuery:
(1) Get rid of the 'errorReporter' param used in the two unbounded 'deps' implementations. In practice, this callback is always used right alongside the normal query callback. So we can re-implement it as a single, composite callback.
(2) Revert the recent change to processResultsAndReturnTargets (and restore the old method name). It general, it's a bad idea to return Targets outside that method, because it means we aren't respecting the MultisetSemaphore<PackageIdentifier>. Along with (1), this fixes a real issue where DepsUnboundedVisitor#processPartialResults was using Targets (and thus keeping their Packages live in memory) outside of the package semaphore.
RELNOTES: None
PiperOrigin-RevId: 206606747
|
|
|
|
|
| |
RELNOTES: Execution Log Parser can now, when printing it out, filter the log by runner type
PiperOrigin-RevId: 206602183
|
|
|
|
| |
PiperOrigin-RevId: 206586252
|
|
|
|
|
|
|
| |
through JavaInfo, instead of returning them also through ConfiguredTarget. Since these providers can not be found in ConfiguredTarget anymore they have to be retrieved from JavaInfo instead.
RELNOTES: None.
PiperOrigin-RevId: 206585413
|
|
|
|
|
|
|
| |
that it can be accessed in Skylark. One example where this is used is in Android IDL processing where the manifestProtoOutput is used to split out the Android IDL generated Java classes from the overarching outputJar produced by the android_library rule.
RELNOTES: none
PiperOrigin-RevId: 206580880
|
|
|
|
| |
PiperOrigin-RevId: 206573961
|
|
|
|
| |
PiperOrigin-RevId: 206568465
|
|
|
|
| |
PiperOrigin-RevId: 206567309
|
|
|
|
|
|
|
|
|
| |
RELNOTES: When using Bazel's remote execution feature and Bazel has to
fallback to local execution for an action, Bazel used non-sandboxed
local execution until now. From this release on, you can use the new
flag --remote_local_fallback_strategy=<strategy> to tell Bazel which
strategy to use in that case.
PiperOrigin-RevId: 206566380
|
|
|
|
| |
PiperOrigin-RevId: 206564363
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:execution_phase_tests
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: Ia46f26d7fa428cc17cd6988859d427165174fe29
Closes #5688.
Change-Id: I5d001825431e8a0ee7d2ce6be911544b72c3bdd2
PiperOrigin-RevId: 206560081
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:startup_options_tests
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: I255b227f7b6b788f21b45b743e7065a646252a36
Closes #5706.
Change-Id: Ibee4997783a820858fc2d2bdda02082a91385d0e
PiperOrigin-RevId: 206551029
|
|
|
|
|
|
|
| |
We want to make sure that the profile captures all Skyframe invocations, so
that we can catch cases where we accidentally introduce new ones.
PiperOrigin-RevId: 206543307
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:experimental_ui_test
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: I7997e8a2e8dce9377c0326b9ed3f6c55a09b2708
Closes #5690.
Change-Id: I7997e8a2e8dce9377c0326b9ed3f6c55a09b2708
PiperOrigin-RevId: 206535860
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:loading_phase_tests
now runs on Windows.
The inherently incompatible parts of the test are
now in
//src/test/shell/integration:loading_phase_posix_tests
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: I90db31449e72aed2138916eed6289bcc20af5cae
Closes #5685.
Change-Id: I38727aed1b548ec8b566f99551e63cceac78180b
PiperOrigin-RevId: 206533515
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 206393574
|
|
|
|
| |
PiperOrigin-RevId: 206389059
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
honored when creating the host platform.
Fixes #5695.
Change-Id: Iaa99c8189421893440e5e5140450c70de69d7b86
Closes #5696.
Change-Id: Iaa99c8189421893440e5e5140450c70de69d7b86
PiperOrigin-RevId: 206371468
|
|
|
|
|
|
|
| |
providers of the same type.
RELNOTES: A rule error is now thrown if a Skylark rule implementation function returns multiple providers of the same type.
PiperOrigin-RevId: 206371385
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 206368137
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
http://https://github.com/bazelbuild/bazel/commit/71479d3ef1627a30b9ec75ca50e6a90cf7db6377 broke thousands of targets in the nightly, notably:
//abuse/ares/rulesystem/generator/python/rule_set:main (x1754)
//net/encapdecap/common/templates:gen_dr_scopes (x903)
//testing/cloud/vex/public:vex_main_internal (x782)
//wireless/android/play/playlog/server:playlog_server (x401)
*** Original change description ***
C++: Removes calls to setCcLinkparamsStore of CcLinkingInfo.Builder
This is in preparation for deleting CcLinkParamsStore. All remaining calls
to the setCcLinkparamsStore method of the CcLinkingInfo builder have been removed.
RELNOTES:none
PiperOrigin-RevId: 206361808
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Go back to the default constructor - instead of requiring everywhere to know the correct hash function, we'll have the default rely on global state. It will make transition easier, even if it makes the origin of the hash less obvious.
*** Original change description ***
Remove default MD5 in most of Bazel's virtual filesystems.
This forces the ex-default to be explicit in a lot of tests, but I'd rather that than have the risk of implicit md5-use in production code.
To keep this CL smaller, do not remove the default from UnixFS quite yet.
RELNOTES: None.
PiperOrigin-RevId: 206358838
|
|
|
|
|
|
|
| |
GitHub assigns *everyone* in a team to a PR, if it matches. Let's not assign everyone to a PR.
RELNOTES: None.
PiperOrigin-RevId: 206350165
|
|
|
|
|
|
|
| |
instead of just skipping the add dep errors.
RELNOTES: follow-up to https://github.com/bazelbuild/bazel/commit/1ac359743176e659e9c7472645e3142f3c44b9e8
PiperOrigin-RevId: 206350053
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling forward with fixes.
*** Original change description ***
PiperOrigin-RevId: 206339696
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 206338340
|
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 206328416
|
|
|
|
|
|
|
|
|
|
| |
The "distdir" option is no longer experimental and therefore should not be
marked as such. Also, the "experimental_repository_hash_file" and
"experimental_verify_repository_rules" are not really about loggig; but they
actually are still experimental.
Change-Id: I5c30c7c0871822c077a713819ae47b250a7d8a71
PiperOrigin-RevId: 206326885
|
|
|
|
|
|
|
| |
This is required to support Windows Docker image creation.
RELNOTES: None
PiperOrigin-RevId: 206326316
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:python_test now runs
on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: Ie408ea55973a32fc5ee6e74f9bed5e3fa9f818b1
Closes #5684.
Change-Id: Ie408ea55973a32fc5ee6e74f9bed5e3fa9f818b1
PiperOrigin-RevId: 206321651
|
|
|
|
|
|
|
|
| |
/cc @laszlocsomor
Closes #5655.
PiperOrigin-RevId: 206319221
|