aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Remove the concept of a mandatory input which is allowed to be missing.Gravatar Googler2017-11-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 177332323
* Revert name of coverage_suppot to coverage_support.Gravatar cparsons2017-11-29
| | | | | | | The previous change was accidental. RELNOTES: None. PiperOrigin-RevId: 177330228
* Remove some unused extension points.Gravatar Googler2017-11-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 177326265
* Add some minor debugging messages to discard_analysis_cache_test, ↵Gravatar janakr2017-11-29
| | | | | | | | purportedly to diagnose issue #4181. My real hope is to achieve the effect I got in discard_graph_edges_test, where the debugging messages seem to have made the flakiness go away, but since this is less multithreaded, I'm less hopeful. PiperOrigin-RevId: 177325229
* Improve depset documentation.Gravatar laurentlb2017-11-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 177321286
* Move CcToolchainTypeRule to CPP_RULES, as opposed to PLATFORM_RULES. It ↵Gravatar cpeyser2017-11-29
| | | | | | more logically belongs with other c++ rule types. PiperOrigin-RevId: 177313718
* RestBlobStore: add missing CAS_PREFIXGravatar nicolov2017-11-29
| | | | | | | | | According to the SimpleBlobStore interface `containsKey` should look up blobs in the CAS. However, the URL it requests is missing `CAS_PREFIX`, so it will never find anything. Closes #4118. PiperOrigin-RevId: 177313658
* Create the output source jar in java_common.compileGravatar elenairina2017-11-29
| | | | | | | | | | | | | | | | | and expose transitive source jars to Skylark. Initial change was rolled back (unknown commit). java_common.compile wouldn't fill the JavaRuleOutputJarsProvider when there was only one input source jar. Fixed that and added test (there was one before, but didn't check this particular provider). Slightly refactor java classes to take in specific host javabase inputs and host java executable for creating the source jar, instead of always relying on fetching them from native java rules specific attributes. Creating the output source jar in java_common.compile makes the behavior more similar to java_library. Exposing the transitive_source_jars to Skylark helps with the Skylark migration from the old 'java' provider to JavaInfo. Progress on #2614. RELNOTES: transitive_source_jars is now exposed on JavaInfo. PiperOrigin-RevId: 177311138
* Fix strip-prefix typo in docsGravatar Ed Baunton2017-11-29
| | | | | | | | The usage is `strip_prefix` not `strip-prefix`. Closes #4162. PiperOrigin-RevId: 177311042
* Update spec, update octal literal syntax and introduction.Gravatar laurentlb2017-11-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 177311029
* Convert TestAspects to MockRule.Gravatar gregce2017-11-29
| | | | | | It'd be nice to go further and break out a bunch of this code into more generally useful places (especially for callers that don't care about aspects). But that's a big mess and beyond the scope of what I'm aiming for here. PiperOrigin-RevId: 177307854
* Update bazel-overview.mdGravatar Rasmus Lund2017-11-29
| | | | | | | | Add Java to list of supported programming languages. Closes #4095. PiperOrigin-RevId: 177307650
* Fix broken link for "C++ common use cases"Gravatar Jon Stewart2017-11-29
| | | | | | | | | | Links to cpp use cases outside of tutorial directory. Fixes #4174 (I think?) Closes #4175. PiperOrigin-RevId: 177307565
* Add . to the bootstrap protoc include pathsGravatar Olivier Chafik2017-11-29
| | | | | | | | | | | | | | | | | | | This fixes the following error I got when building from scratch on Raspbian: ``` src/main/protobuf/invocation_policy.proto: File not found. src/main/protobuf/command_line.proto: File not found. ``` Note: ``` protoc --version libprotoc 3.0.0 ``` Closes #4187. PiperOrigin-RevId: 177306773
* MockRule enhancements.Gravatar gregce2017-11-29
| | | | | | | | - Support custom ancestors and rule implementations. - Refactor defaults into MockRuleDefaults. - More thorough documentation. PiperOrigin-RevId: 177303642
* Expressly fetch remote and ref when using git_repositoryGravatar Ed Baunton2017-11-29
| | | | | | | | | | | | | | | | When I clone from a git repo that doesn't have the default branch the same as the branch that I want ; it doesn't seem to fetch the appropriate branch. I am using a name rather than explicit sha. What happens is: ``` + git reset --hard build-with-bazel fatal: ambiguous argument 'build-with-bazel': unknown revision or path not in the working tree. ``` because it hasn't fetched that ref. Closes #4039. PiperOrigin-RevId: 177298578
* BEP: Extend TestResult to optionally contain meta dataGravatar aehlig2017-11-29
| | | | | | | | Extend the protocol to support also showing meta data about an action execution, if the underlying test action is able to report it. PiperOrigin-RevId: 177294531
* Implemented fix for case when 'use_testrunner' attribute works ↵Gravatar dbabkin2017-11-29
| | | | | | | | | | | | | | | | interconnected with 'main_class' in java_test rule. for manual testing I used BUILD file: java_test( name = "mytest", srcs = glob(["*.java"]), main_class = "com.test.Test", use_testrunner = 1, ) RELNOTES: java_tests no complain when use_testrunner is explicitly set to 1 and main_class is set. PiperOrigin-RevId: 177291746
* Add user and system time to CommandResults, and plumb them into SpawnResults.Gravatar ruperts2017-11-29
| | | | | RELNOTES: None PiperOrigin-RevId: 177290508
* Clean up ExecutionRequirementsGravatar ulfjack2017-11-29
| | | | | | | | | | | | | | | | | | | - remove BaseSpawn.Local; instead, all callers pass in the full set of execution requirements they want to set - disable caching and sandboxing for the symlink tree action - it does not declare outputs, so it can't be cached or sandboxed (fixes #4041) - centralize the existing execution requirements in the ExecutionRequirements class - centralize checking for execution requirements in the Spawn class (it's possible that we may need a more decentralized, extensible design in the future, but for now having them in a single place is simple and effective) - update the documentation - forward the relevant tags to execution requirements in TargetUtils (progress on #3960) - this also contributes to #4153 PiperOrigin-RevId: 177288598
* Handle spaces in absolute paths to tests.Gravatar Seth Greenstein2017-11-29
| | | | | | | | | | | | | | | | | | | | | | This allows for output_base paths that contain spaces, fixing #3897 The test path is set by grepping the MANIFEST, in which each line is a space-separated 2-tuple of relative path and absolute path to the test. Replace the awk command that extracts the second item in the space-separated list with a sed command that extracts everything after the first space. Also, quote the manifest path arg to the grep command. There will still be problems if there are spaces in the relative path, below the Bazel project root. Test: Built and tested a test with an output_base containing a space. Change-Id: I5dba285bb50c27eedace17a5e20efac7392a9a6e Closes #3899. Change-Id: I5dba285bb50c27eedace17a5e20efac7392a9a6e PiperOrigin-RevId: 177283695
* Enable auto-completion for the "ibazel" commandGravatar Martin Probst2017-11-29
| | | | | | | | | | ibazel implements a the same command line interface as bazel, so we can just use the same completion function. See https://github.com/bazelbuild/bazel-watcher. Closes #4091. PiperOrigin-RevId: 177282217
* Minor fixes to spacing in help messagesGravatar Mike Morearty2017-11-29
| | | | | | | | A few help messages were missing a space after the period at the end of a sentence. Closes #4094. PiperOrigin-RevId: 177282132
* Docs: (minor) Change "chaiscript" to "mockascript"Gravatar Tyler True2017-11-29
| | | | | | | | | | | Avoids ambiguity; "chaiscript" is a real language. (See http://chaiscript.com ) Satisfies (unreported issue): https://twitter.com/lefticus/status/932423849928519681 Resolves #4133. Closes #4125. PiperOrigin-RevId: 177281798
* Merge commit 'refs/pull/4164/head' of https://github.com/bazelbuild/bazel ↵Gravatar László Csomor2017-11-29
|\ | | | | | | | | | | into HEAD Change-Id: Iafff106153aff96380837eddf771e572335c8798
* | Various Shell Script Fixes and Improvements - Part OneGravatar Androbin2017-11-29
| | | | | | | | | | | | | | | | see #4023 Closes #4051. PiperOrigin-RevId: 177279457
* | More Shell Cleaning - Part TwoGravatar Androbin2017-11-29
| | | | | | | | | | | | | | | | @damienmg Here are a few more changes. (`third_party` only) Closes #4164. PiperOrigin-RevId: 177278511
* | Change error on adding a directory to the remote cache to be non-fatalGravatar Rahul Malik2017-11-29
| | | | | | | | | | | | | | | | | | | | @ulfjack @buchgr - I'm resubmitting https://github.com/bazelbuild/bazel/pull/3984 on behalf of @mterring to get past CLA issues that are holding it up from merging. This is a temporary fix for the issue https://github.com/bazelbuild/bazel/issues/3891 while we wait for https://github.com/bazelbuild/bazel/pull/4011 to be reviewed and tested Closes #4188. PiperOrigin-RevId: 177276751
* | Added missing Oxford (serial) commas in README.mdGravatar Josh Goldberg2017-11-29
| | | | | | | | | | | | | | | | A, b ***,*** and c. Closes #4136. PiperOrigin-RevId: 177273999
* | Make process-wrapper output execution statistics for executed commands.Gravatar ruperts2017-11-28
| | | | | | | | | | | | | | For example, it now outputs resource usage statistics like the amount of user time and system time used. RELNOTES: None PiperOrigin-RevId: 177263221
* | Automatic code cleanup.Gravatar cushon2017-11-28
| | | | | | | | PiperOrigin-RevId: 177261837
* | Update PathPackageLocator to take a list of potential build file names,Gravatar John Cater2017-11-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | instead of assuming BUILD. - Default the list to the same value as PackageLookupFunction: BUILD.bazel, BUILD. - Move BuildFileNames to the packages package, so it is more generally available. Part of #4056. Change-Id: Ie12512b492cd7d47a9e56ec3bc209f829feaf4b5 PiperOrigin-RevId: 177261295
* | Remove process-wrapper duplication from RunCommand.Gravatar ruperts2017-11-28
| | | | | | | | | | | | | | Also rename ProcessWrapperRunner to ProcessWrapperUtil, since it isn't really a Runner (it doesn't run anything). RELNOTES: None. PiperOrigin-RevId: 177260951
* | Make turbine tests more compatible with WindowsGravatar cushon2017-11-28
| | | | | | | | | | | | See bazelbuild/bazel#4165. PiperOrigin-RevId: 177254510
* | Ensure the argument to JarCreator.addDirectory existsGravatar cushon2017-11-28
| | | | | | | | | | | | Follow-up to https://github.com/bazelbuild/bazel/commit/0b2352de3101e87647d083f6089246079dda0f75 PiperOrigin-RevId: 177234776
* | Extract CONTAINS_JAVA_PROVIDER to a shared constantGravatar cushon2017-11-28
| | | | | | | | | | | | Pre-factoring for unknown commit. PiperOrigin-RevId: 177232397
* | Move CppConfiguration#getFullyStaticLinkOptions, #getMostlyStaticLinkOptions,Gravatar cpeyser2017-11-28
| | | | | | | | | | | | | | | | | | | | | | and #getDynamicLinkOptions to CppHelper. This allows toolchain information needed by those methods to move to CcToolchainProvider. The migration of toolchain information from CppConfiguration to CcToolchainProvider is required to move the c++ rules to platform-based toolchain selection. PiperOrigin-RevId: 177230635
* | Fix typo, remove stale commentGravatar brandjon2017-11-28
| | | | | | | | | | RELNOTES: None PiperOrigin-RevId: 177224445
* | Make check_fileset_dependencies_recursively flag a no-op. We will always ↵Gravatar kush2017-11-28
| | | | | | | | | | | | | | behave as if this flag is true. RELNOTES: None PiperOrigin-RevId: 177219652
* | Eliminate STATIC_FRAMEWORK_DIR as a separate field of ObjcProvider.Gravatar cparsons2017-11-28
| | | | | | | | | | | | | | | | | | Infer those values from STATIC_FRAMEWORK_FILE. This correctly dedupes static frameworks between an app and its dylibs. RELNOTES: None. PiperOrigin-RevId: 177214770
* | Document Android options.Gravatar ajmichael2017-11-28
| | | | | | | | | | RELNOTES: None PiperOrigin-RevId: 177195468
* | Update blazerc documentation in the blaze/bazel user mannuals.Gravatar ccalvarin2017-11-28
| | | | | | | | | | | | | | Update the docs for clarity and to explain the --expand_configs_in_place alternate expansion behavior. RELNOTES: None. PiperOrigin-RevId: 177183524
* | Print 'waiting for other blaze command' on its own line.Gravatar Googler2017-11-28
| | | | | | | | | | | | | | | | | | | | It now prints a newline char immediately, rather than waiting until the lock is released, and printing 'done!' at the end of the line. This allows per-line parsers (like IntelliJ) to display this progress notification without special-case hacks. PiperOrigin-RevId: 177180918
* | Automated rollback of commit b64119807b014d9f3b99fb8a02e22daf1a8299b6.Gravatar nharmata2017-11-28
| | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Tickles the shell integration test version of b/35042288 *** Original change description *** Change BlacklistedPackagesPrefixesFunction to take a pair of a hardcoded set of directories and a file path containing more directories to blacklist. The current usage of PrecomputedValue#BLACKLISTED_PACKAGE_PREFIXES_FILE is overly general and is only meaningfully used by unit tests; in practice, the blacklist file path can never change over the lifetime of the Bazel server. Perform a minor simplifying refactor as a result of this. RELNOTES: None. PiperOrigin-RevId: 177176068
* | macOS compatibility in build.ps1.Gravatar Peter Mounce2017-11-28
| | | | | | | | | | | | | | | | | | | | | | | | Apparently powershell on macOS is a thing now... However, chocolatey does not yet seem to be... cc @dslomov Closes #4026. PiperOrigin-RevId: 177172660
* | Migrate some Skylark tests outside of Blaze.Gravatar laurentlb2017-11-28
| | | | | | | | | | RELNOTES: None PiperOrigin-RevId: 177169878
* | Remove dead code from CompilationSupportGravatar cparsons2017-11-28
| | | | | | | | | | RELNOTES: None. PiperOrigin-RevId: 177165649
* | Change BlacklistedPackagesPrefixesFunction to take a pair of a hardcoded set ↵Gravatar nharmata2017-11-28
| | | | | | | | | | | | | | of directories and a file path containing more directories to blacklist. The current usage of PrecomputedValue#BLACKLISTED_PACKAGE_PREFIXES_FILE is overly general and is only meaningfully used by unit tests; in practice, the blacklist file path can never change over the lifetime of the Bazel server. Perform a minor simplifying refactor as a result of this. RELNOTES: None. PiperOrigin-RevId: 177164057
* | Migrate callsites of CppConfiguation#getCompiler, #getTargetLibc, #getCpu toGravatar cpeyser2017-11-28
| | | | | | | | | | | | | | CcToolchainProvider. Toolchain information must be removed from CppConfiguration to allow the c++ rules to use hermetic platforms. PiperOrigin-RevId: 177163880
* | Grammar fix. bazel-overview.mdGravatar Roller, David2017-11-28
| | | | | | | | | | | | | | | | Removed duplicated word in bazel-overview.md docs Closes #4183. PiperOrigin-RevId: 177161035