| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
native skyframe implementation was actually quite incorrect in this case: It was adding a skyframe dependency on a FileValue for the output file. Without a transitive dependency on the source files and actions that determine the output file's state, this could never work (and explains why the incremental build would fail). Instead, we now depend on the Artifact corresponding to the output file instead.
This change updates the business logic RecursiveFilesystemTraversalFunction. This approach keeps the business logic of Fileset filesystem traversal centralized in RFTF.
To avoid making weird recursive Skyframe nodes in the output tree, we inline Skyframe dependencies and do direct filesystem operations over the output tree.
There are now three states we can be in when looking up a file:
1. Source file: As before, make a skyframe dep on the corresponding file
2. Top-level file of an output tree: Make a dep on the corresponding Artifact
3. Recursive file under an output directory: Do direct filesystem operations. It doesn't make sense to make Skyframe nodes corresponding to these files. In the future, I think we should consider failing fast on this case.
RELNOTES: None
PiperOrigin-RevId: 184556044
|
|
|
|
|
|
| |
since it's never instantiated on its own.
PiperOrigin-RevId: 184554483
|
|
|
|
|
|
|
|
| |
essentially promote OwnedArtifact to ArtifactSkyKey and rename it to ArtifactSkyKey. The king is dead...
Also add some other execution-phase codecs.
PiperOrigin-RevId: 184552706
|
|
|
|
| |
PiperOrigin-RevId: 184540561
|
|
|
|
|
|
|
|
|
|
|
| |
the runfiles tree.
As I understand it, this is only a theoretical issue today because
$unified_launcher is generally a flat file. (Flat files never have
runfiles middlemen.) However, it's good to be future proof.
Change-Id: If77edfa9dd7475ab93b19c62b08f8d86a77acbe6
PiperOrigin-RevId: 184540188
|
|
|
|
|
|
| |
SpecialArtifact.
PiperOrigin-RevId: 184539696
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 184538771
|
|
|
|
|
|
|
|
| |
We're now using ctime to detect file changes, so the timestamp granularity monitor should as well.
Unfortunately, we currently get nanosecond ctime from Linux, but then only return millis from FileStatus, so this doesn't change the accuracy of the monitor at all.
PiperOrigin-RevId: 184536539
|
|
|
|
|
|
|
| |
rule for the execution statistics path.
RELNOTES: None.
PiperOrigin-RevId: 184534589
|
|
|
|
|
|
| |
Closes #4489.
PiperOrigin-RevId: 184532916
|
|
|
|
|
|
|
| |
Fix the create_main_dex_list stub script to find the dx jar binary correctly.
RELNOTES: None
PiperOrigin-RevId: 184532530
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
child of the process where the Blaze client itself was run.
Limitations:
- Untested on Windows; it should work because ExecuteProgram() is implemented there, too, but since Windows doesn't support exec(), there is at least one process in between
Progress towards #2815.
RELNOTES[NEW]: The new "--direct_run" flag on "blaze run" lets one run interactive binaries.
PiperOrigin-RevId: 184528845
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Causes Blaze to crash when building Exoblaze as shown in b/72936965.
Confirmed as root cause by rolling back this CL, building a Blaze
from HEAD, and successfully using it to build Exoblaze.
*** Original change description ***
C++: Remove last instatiation of CppModel outside CcLibraryHelper.
RELNOTES:none
PiperOrigin-RevId: 184528551
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 184518931
|
|
|
|
|
|
|
|
| |
This is a rather small change to a Python tool used to produce a SHA256 hash. Currently, the whole file is loaded in memory before computing the hash, which causes problem when large files are processed. For instance, github.com/bazelbuild/rules_docker uses it to compute the hash of Docker images, which can be multiple GB in size. This PR avoids the tool to cause issues in a limited-memory environment.
Closes #4243.
PiperOrigin-RevId: 184518900
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also update the Python stub script template to set
$RUNFILES_MANIFEST_FILE or $RUNFILES_DIR so the
runfiles library only needs to look for those.
See https://github.com/bazelbuild/bazel/issues/4460
RELNOTES[NEW]: python,runfiles: You can now depend on `@bazel_tools//tools/runfiles:py-runfiles` to get a platform-independent runfiles library for Python. See DocString of https://github.com/bazelbuild/bazel/blob/master/src/tools/runfiles/runfiles.py for usage information.
Change-Id: I4f68a11cb59f2782e5203e39fe60cc66b46023a2
PiperOrigin-RevId: 184515490
|
|
|
|
|
| |
RELNOTES:none
PiperOrigin-RevId: 184510731
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 184498836
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 184492828
|
|
|
|
|
|
|
|
|
| |
Add docs for the --workspace_status_command flag.
Fixes https://github.com/bazelbuild/bazel/issues/4220
RELNOTES: none
PiperOrigin-RevId: 184492241
|
|
|
|
|
|
|
| |
Fixes #4563.
Change-Id: I12868569feb1ec700062006307cda15c24946797
PiperOrigin-RevId: 184490058
|
|
|
|
|
| |
RELNOTES:none
PiperOrigin-RevId: 184411715
|
|
|
|
| |
PiperOrigin-RevId: 184370036
|
|
|
|
| |
PiperOrigin-RevId: 184369667
|
|
|
|
|
|
|
|
| |
To avoid hiding compiler.warn.sun.proprietary warnings when running with -Werror.
Fixes bazelbuild/bazel#4564
PiperOrigin-RevId: 184367653
|
|
|
|
|
|
| |
that top level targets are configured in.
PiperOrigin-RevId: 184358568
|
|
|
|
|
|
|
|
|
|
| |
This further discourages the paradigm of rule implementations consuming
entire configs vs. declared fragments.
It also makes RuleContext a more reliable tracker of which fragments
rules use.
PiperOrigin-RevId: 184355968
|
|
|
|
|
|
|
| |
android_local_test.{resource_files,assets,assets_dir}. They are not used and their usage is unsupported.
RELNOTES: None
PiperOrigin-RevId: 184354541
|
|
|
|
|
|
| |
Closes #4540.
PiperOrigin-RevId: 184349872
|
|
|
|
| |
PiperOrigin-RevId: 184348602
|
|
|
|
|
|
|
|
| |
either a Label or a List<Label>. We can easily enforce this through static type checking, so do it.
This will help with LateBoundDefault serialization, since we don't have to serialize an arbitrary object.
PiperOrigin-RevId: 184347100
|
|
|
|
|
|
|
|
| |
to do.
Also change AspectDescriptor #isEmpty() semantics because they seemed like a bug to me.
PiperOrigin-RevId: 184319840
|
|
|
|
|
|
| |
declaration.
PiperOrigin-RevId: 184304653
|
|
|
|
|
|
|
|
|
| |
This test currently times out when run on our CI and we don't have a root
cause yet -- but it's blocking all submissions. Thus disable it in the
meantime while we investigate.
RELNOTES: None.
PiperOrigin-RevId: 184304422
|
|
|
|
|
|
|
| |
enabled.
RELNOTES:none
PiperOrigin-RevId: 184303490
|
|
|
|
|
|
|
|
| |
has a CODEC member. AutoCodec cannot yet support other type parameters for
NestedSet, like NestedSet<List<Foo>>. This will have to wait for AutoCodec
Runtime.
PiperOrigin-RevId: 184294808
|
|
|
|
|
|
| |
Return statements can exist without an expression.
PiperOrigin-RevId: 184291539
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Did not help so there is no need to carry this further.
*** Original change description ***
tests: increase shard_count for launcher_test
This test is timing out on internal CI, breaking
presubmits.
RELNOTES: none
PiperOrigin-RevId: 184283585
|
|
|
|
|
|
|
|
|
| |
Bazel completely swallowed errors in some cases, e.g., if the pattern is
invalid like bazel build foo//bar:baz.
Note that it previously silently ignored empty targets if --experimental_skyframe_target_pattern_evaluator was passed, and now fails (which is consistent with legacy behavior). This is an intentional change, but may break users who are using the experimental flag and are passing empty strings to Bazel.
PiperOrigin-RevId: 184282856
|
|
|
|
| |
PiperOrigin-RevId: 184280067
|
|
|
|
|
|
|
| |
In scope of b/69780248 three new provider had been added to JavaInfo. This CL implements merge logic for its.
RELNOTES:none
PiperOrigin-RevId: 184273903
|
|
|
|
|
|
|
|
| |
This test is timing out on internal CI, breaking
presubmits.
RELNOTES: none
PiperOrigin-RevId: 184270477
|
|
|
|
|
|
|
|
|
| |
This makes object_file_group work correctly for archiving (So far
object_file_group was only possible for linking, but with the introduction of
tree artifact support, it can appear also for archiving).
RELNOTES: Fix how libraries_to_link are expanded in the archiver command line.
PiperOrigin-RevId: 184258745
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove most of the hardcoded, Windows-only envvars
from testenv.sh:
- BAZEL_VC and BAZEL_PYTHON: Bazel can autodetect
these
- TMP/TEMP/TMPDIR and TEST_TMPDIR: Bazel sets
these automatically
As for BAZEL_SH, we can just get bash's path using
cygpath. We know there is a bash since this is
already inside a bash script.
Also, use `rlocation` for some of the the runfile
lookups.
Change-Id: Ib35d285ec0cbb88cb5d603a4eb0f3386f3c2033b
PiperOrigin-RevId: 184253597
|
|
|
|
| |
PiperOrigin-RevId: 184211212
|
| |
|
|
|
|
|
|
|
| |
android_instrumentation_test_integration_test
RELNOTES: None.
PiperOrigin-RevId: 184203486
|
|
|
|
|
|
|
| |
Also clarifies a comment on preventNewEvaluations.
RELNOTES: None.
PiperOrigin-RevId: 184198568
|
|
|
|
|
| |
RELNOTES:
PiperOrigin-RevId: 184191201
|
|
|
|
| |
PiperOrigin-RevId: 184177838
|