aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Remove some methods from ChattyAssertsTestCase - some are inlined, and someGravatar Ulf Adams2015-02-25
| | | | | | | are unused. -- MOS_MIGRATED_REVID=87139146
* Move all logic to determine which output groups are to be built to ↵Gravatar Lukacs Berki2015-02-25
| | | | | | | | | BuildRequest.determineOutputGroups(). This paves the way for making --compile_only, --compilation_prerequsites_only and --save_temps into aliases for --output_groups=<something> -- MOS_MIGRATED_REVID=87138659
* Remove TempsProvider in favor of an output group.Gravatar Lukacs Berki2015-02-25
| | | | | -- MOS_MIGRATED_REVID=87136119
* Pass bundle_id attribute to PlMerge if it is explicitly setGravatar Googler2015-02-25
| | | | | | | | | * Adds primary and fallback bundle ID fields * Adds conflict resolution that considers IDs in order: plist file, primary ID (set in BUILD file), fallback ID (Blaze default). If plist and primary are both set, they should be equal, otherwise an error is thrown. -- MOS_MIGRATED_REVID=87106031
* Compute action start time in critical path using Clock.currentTimeMillis ↵Gravatar Miguel Alcon Pinto2015-02-25
| | | | | | | instead of nanoTime. As nanoTime should only be used to compute time differences. To avoid having to pass two long values representing time (And calling twice to Clock.xxx methods per action executed) we compute the wall time by passing a clock and computing the difference from the start nano time. -- MOS_MIGRATED_REVID=87102963
* Make xctest_app's .ipa an implicit output so that scripts external to Bazel ↵Gravatar Matthew DeVore2015-02-24
| | | | | | | can access it. -- MOS_MIGRATED_REVID=87086924
* Add the j2objc libraries as dependencies in IosTest.Gravatar Googler2015-02-24
| | | | | -- MOS_MIGRATED_REVID=87083899
* Decrease flakiness of InterruptibleTest.testInterruptible.Gravatar Han-Wen Nienhuys2015-02-24
| | | | | -- MOS_MIGRATED_REVID=87066171
* Removed a couple of warnings in JavaBuilder.Gravatar Damien Martin-Guillerez2015-02-24
| | | | | -- MOS_MIGRATED_REVID=87049801
* LinuxSandboxedStrategy: only set debug if --verbose_failures is set.Gravatar Han-Wen Nienhuys2015-02-24
| | | | | -- MOS_MIGRATED_REVID=87048867
* Simplify the algorithm to compute top-level artifacts to build even more by ↵Gravatar Lukacs Berki2015-02-24
| | | | | | | creating a HIDDEN_TOP_LEVEL output group and putting the artifacts required for building runfiles there. -- MOS_MIGRATED_REVID=87039530
* Remove FilesToCompileProvider and CompilationPrerequisitesProvider and ↵Gravatar Lukacs Berki2015-02-24
| | | | | | | replace them with output groups. -- MOS_MIGRATED_REVID=87038548
* Description redacted.Gravatar Ulf Adams2015-02-24
| | | | | -- MOS_MIGRATED_REVID=87036991
* Description redacted.Gravatar Nathan Harmata2015-02-24
| | | | | -- MOS_MIGRATED_REVID=87009938
* Use a factory method in ASTFileLookupValue to enforce that the NO_FILE ↵Gravatar Nathan Harmata2015-02-24
| | | | | | | constant is correctly used. -- MOS_MIGRATED_REVID=87008436
* Change default xcode_options to DebugGravatar Daniel Wagner-Hall2015-02-23
| | | | | | | Having a random non-Debug non-Release xcode_options doesn't serve any useful purpose. -- MOS_MIGRATED_REVID=86999601
* Make an error message more robust.Gravatar Francois-Rene Rideau2015-02-23
| | | | | | | Make it not depend on the iteration order on the hash table of **kwargs. -- MOS_MIGRATED_REVID=86986044
* Don't allow bundles in objc_* deps.Gravatar Peter Schmitt2015-02-23
| | | | | | | | | Use the "bundles" attribute instead. RELNOTES: Use "bundles" instead of "deps" to depend on bundles in objc rules. -- MOS_MIGRATED_REVID=86985618
* Add documentation for Skylark Go rules.Gravatar Han-Wen Nienhuys2015-02-23
| | | | | -- MOS_MIGRATED_REVID=86946740
* Xcode project files: Add dependencies on ios_extension from objc_binary ↵Gravatar Matthew DeVore2015-02-23
| | | | | | | | | correctly. ios_extension is a direct dependency of the objc_binary, but none of the transitive dependencies should be added to the build phases, since this would cause the symbols of the linked objc_binary to contain everything the ios_extension has, which we don't want. -- MOS_MIGRATED_REVID=86920610
* Add a dummy source file to the Xcode targets for ios_extensions to make ↵Gravatar Matthew DeVore2015-02-22
| | | | | | | Xcode happy. -- MOS_MIGRATED_REVID=86910779
* Use the crosstool feature configuration for all modules, layering and headerGravatar Manuel Klimek2015-02-22
| | | | | | | processing related flags. -- MOS_MIGRATED_REVID=86898123
* Add toString method to QueryEvalResult.Gravatar Janak Ramakrishnan2015-02-20
| | | | | -- MOS_MIGRATED_REVID=86826447
* Convert ResourceSet ctor calls to factory methodGravatar Mark Schaller2015-02-20
| | | | | | | | | | Most current invocations of the ResourceSet constructor shouldn't care about any new dimensions we add to restrict test execution. This change allows us to make those changes, keep the ResourceSet ctor symmetrical, and avoid contaminating those ctor call sites with noise. -- MOS_MIGRATED_REVID=86826112
* Move .accept() from Argument to PassedGravatar Francois-Rene Rideau2015-02-20
| | | | | | | This fixes the visit/accept protocol for Argument.Passed. -- MOS_MIGRATED_REVID=86799044
* Fix bug when using header modules and FDO with --save_temps.Gravatar Manuel Klimek2015-02-20
| | | | | -- MOS_MIGRATED_REVID=86797852
* Ensure that XCVersionGroup always has a file type.Gravatar Peter Schmitt2015-02-20
| | | | | | | Without this, xcode doesn't accept the data model's version group. -- MOS_MIGRATED_REVID=86796043
* Implement ios_extension rule. See IosExtensionRule.java for information on ↵Gravatar Matthew DeVore2015-02-20
| | | | | | | | | how app extensions are built and how they differ from application bundles. RELNOTES: Support ios_extension and ios_extension_binary rules for creating iOS app extensions. -- MOS_MIGRATED_REVID=86788086
* Improve Java examplesGravatar Kristina Chodorow2015-02-20
| | | | | -- MOS_MIGRATED_REVID=86787893
* Reenable Mac tests, but without ParallelEvaluatorTests.Gravatar Han-Wen Nienhuys2015-02-20
| | | | | -- MOS_MIGRATED_REVID=86780976
* Bazel's .gitignore: replace tools/java/* by tools/jdk/*Gravatar Damien Martin-Guillerez2015-02-20
| | | | | -- MOS_MIGRATED_REVID=86780538
* Address John's comments on FAQGravatar Han-Wen Nienhuys2015-02-20
| | | | | -- MOS_MIGRATED_REVID=86780440
* Do not add header modules to the object files in CcCompilationOutputs.Gravatar Manuel Klimek2015-02-20
| | | | | | | | Gets rid of a confusing warning that there are no object files, but something is linked. -- MOS_MIGRATED_REVID=86777258
* Use .pcm.d as file name for the dependency file for header modules.Gravatar Manuel Klimek2015-02-20
| | | | | | | | This can otherwise clash with C/C++ compiles where the source file has the same name as the target. -- MOS_MIGRATED_REVID=86776429
* Description redacted.Gravatar Googler2015-02-19
| | | | | -- MOS_MIGRATED_REVID=86738858
* Fix shutdown deadlock when a shutdown hook crashes - halt() instead of exit().Gravatar Eric Fellheimer2015-02-19
| | | | | | | See associated bug for more details. -- MOS_MIGRATED_REVID=86708715
* Naming and documentation cleanup left over from a recent CL.Gravatar Peter Schmitt2015-02-19
| | | | | | | As discussed in []. -- MOS_MIGRATED_REVID=86708361
* Introduce first class function signatures; make the parser use them.Gravatar Francois-Rene Rideau2015-02-19
| | | | | | | | | | | | | | | | | | | This is the first meaty cl in a series to refactor the Skylark function call protocol. 1- We introduce a first-class notion of FunctionSignature, that supports positional and named-only arguments, mandatory and optional, default values, type-checking, *stararg and **kwarg; 2- To keep things clean, we distinguish two different kinds of Argument's: Argument.Passed that appears in function calls, and Parameter, that appears in function definitions. 3- We refactor the Parser so it uses this infrastructure, and make minimal changes to MixedModeFunction so that it works with it (but don't actually implement *starparam and **kwparam yet). 4- As we modify FuncallExpression, we ensure that the args and kwargs arguments it passes to the underlying function are immutable, as a prerequisite to upcoming implementation of *starparam and **kwparam as being provided directly from a skylark list or dict. Further changes under review will take advantage of this FunctionSignature to redo all our function call protocol, to be used uniformly for both UserDefinedFunction's and builtin function. The result will be a simpler inheritance model, with better type-checking, builtin functions that are both simpler and better documented, and many redundant competing functionality-limited codepaths being merged and replaced by something better. NB: The changes to MixedModeFunction, SkylarkFunction and MethodLibrary are temporary hacks to be done away with in an upcoming CL. The rest is the actual changes. -- MOS_MIGRATED_REVID=86704072
* Add symlinks to third_party/ and tools/ to base_workspaceGravatar Kristina Chodorow2015-02-19
| | | | | | | | | | | | While attempting to clean up the Bazel examples, I noticed that the example tests don't actually work because they expect a third_party directory. We could link third_party/ from the top-level bazel directory, but then we'd have crossing symlinks (base_workspace/tools->tools and third_party->base_workspace/third_party). Linking everything in one direction seemed like a better option, but alternative suggestions are welcome. -- MOS_MIGRATED_REVID=86703332
* Clarify comment added in [].Gravatar Lukacs Berki2015-02-19
| | | | | -- MOS_MIGRATED_REVID=86689743
* Correctly add .pcm files to the command line of parsed headers when theirGravatar Manuel Klimek2015-02-19
| | | | | | | dependencies just generate pic or non-pic header modules. -- MOS_MIGRATED_REVID=86686907
* Decouple header-processing from the toolchain rule attribute.Gravatar Manuel Klimek2015-02-19
| | | | | | | This required pulling the feature configuration into the rule-specific code. -- MOS_MIGRATED_REVID=86685776
* Description redacted.Gravatar Marian Lobur2015-02-19
| | | | | -- MOS_MIGRATED_REVID=86685664
* Remove BaselineCoverageArtifactsProvider in favor of an output group.Gravatar Lukacs Berki2015-02-19
| | | | | | | The only slightly different thing here is that now, instead of using target.getConfiguration().isCodeCoverageEnabled() we use BuildRequest.Options.collectCodeCoverage, but the only place where this is not the same I can think of is InputFileCT, which does not have baseline coverage files anyway. -- MOS_MIGRATED_REVID=86682774
* Renamed java tools from //tools:java/* to //tools/jdk:* inside blaze.Gravatar Damien Martin-Guillerez2015-02-19
| | | | | -- MOS_MIGRATED_REVID=86681843
* Port all module map and header parsing related flags to the new crosstoolGravatar Manuel Klimek2015-02-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | configuration. Together with [] (change to the crosstool configuration), the resulting blaze is able to build header modules (minus clang bugs). Detailed changes: 1. Adapt CppCompileAction to only insert the arguments itself if the crosstool does not specify a feature. 2. Make CppCompileAction provide the build variables to the flag expansion. 3. Pass package features through to the new feature selection / crosstool configuration; allow rules to always request features and mark features as unsupported. 4. Add feature "header_module_includes_dependencies" that controls whether we can only provide top-level header modules in the ${module_files} build variable; the currently integrated clang does not fully support that yet. 5. Add feature "use_header_modules", which allows targets to use compiled header modules without being compilable as module themselves. 6. Convert tests to use the feature configuration where it makes sense; we will be able to delete a lot of unit tests once the control via the feature configuration is rolled out to the stable crosstool, and implement them as crosstool integration tests. -- MOS_MIGRATED_REVID=86680884
* Scrub.Gravatar Ulf Adams2015-02-19
| | | | | | | | | | | | | | | | | | | | Also includes the following changes: Skylark: tests copy the Skylark files into the same directory. Load statements are replaced with relative paths within bzl files and with absolute paths in tests. -- Refactor Objc abstract rule classes. This new arrangement groups attributes by logical purpose and clarifies rule composition. For example objc_binary inherits "linking" whereas an objc_library inherits "linkable" but both inherit "compiling". The only functional change in this CL is to remove the "data" attribute from all rules as it is not used in the depot and doesn't make sense when we also allow specifying resources in any number of other ways. -- MOS_MIGRATED_REVID=86676190
* Add anything specified in "defines" to the compiler arguments for ↵Gravatar Matthew DeVore2015-02-18
| | | | | | | objc_binary, ios_extension_binary, and objc_binary. -- MOS_MIGRATED_REVID=86614967
* Prepare strict deps for using JavacPathFileManager.Gravatar Liam Miller-Cushon2015-02-18
| | | | | | | | | | | | | This lays the groundwork for using a JavacPathFileManager and Jimfs to test strict deps and the dependency extractor, instead of the ad-hoc in-memory filesystem implementation in InMemoryJavaFileManager. The current implementation is deeply impressive, but scary to maintain and entirely unnecessary now that we have nio-based filemangers Jimfs. RELNOTES: N/A -- MOS_MIGRATED_REVID=86606317
* Fixed an inconsistency.Gravatar Googler2015-02-18
| | | | | -- MOS_MIGRATED_REVID=86606301