aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* When creating RuleContext, explicitly pass the set of attributes an attached ↵Gravatar Carmi Grushko2015-11-02
| | | | | | | Aspect provides. -- MOS_MIGRATED_REVID=106882046
* Make subcommand completion in zsh work on Mac OS XGravatar Yuki Yugui Sonoda2015-11-02
| | | | | | | | | Avoid depending on extended regexp of gawk -- Change-Id: I28a57c249c5b8078b410c365f51f400bcdc27997 Reviewed-on: https://bazel-review.googlesource.com/#/c/2240 MOS_MIGRATED_REVID=106877966
* Introduce ForkJoinQuiescingExecutor, permit its use in evaluationGravatar Mark Schaller2015-11-02
| | | | | | | | | | | | | | | | | | This CL introduces a QuiescingExecutor implementation specialized for ForkJoinPools with the same interrupt handling, error propagation, and task completion semantics as AbstractQueueVisitor. Currently it does this by largely sharing its implementation with AQV. Future refactoring could let it rely more on ForkJoinPool's own awaitQuiescence implementation to avoid the overhead of AQV's remainingTasks counter maintenance. Subtasks spawned by tasks executing in ForkJoinQuiescingExecutor will rely on ForkJoinPool's thread-local task deques for low contention and (mostly) LIFO ordering. -- MOS_MIGRATED_REVID=106864395
* Changes from [] that were left out of theGravatar Brian Silverman2015-11-02
| | | | | | | | | | | | | | previous commit Document and test how rules can run without the sandbox. The only documentation about usable tags values was in a weird place, along with duplicated information about flaky tests. -- Change-Id: Ib98a0a5c582890512161ecf9f5d89c8e78d9ad68 Reviewed-on: https://bazel-review.googlesource.com/#/c/2220 MOS_MIGRATED_REVID=106858070
* Fix AbstractQueueVisitor synchronization, comments, and field namesGravatar Mark Schaller2015-11-02
| | | | | | | | | | | | | | | | This fixes the following synchronization issue with AbstractQueueVisitor's jobsMustBeStoppedField: it was read in awaitTermination in a block synchronized on zeroRemainingTasks, but in markToStopAllJobsIfNeeded it was read and written in a block synchronized on the AQV instance. Now, it is always read or written in a block synchronized on zeroRemainingTasks, because it is used in the condition represented by that object. This also thoroughly cleans up obsolete and irregular documentation in the class. -- MOS_MIGRATED_REVID=106849236
* Parametrize aspect definition with AspectParameters.Gravatar Dmitry Lomov2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106848269
* Cleanup ValueVisitor (and dirty QuiescingExecutor)Gravatar Mark Schaller2015-11-02
| | | | | | | | | | | | | Raises the level of abstraction of ValueVisitor's dependence on AbstractQueueVisitor. Except for the "ForTestingOnly" methods now available on the QuiescingExecutor interface, ValueVisitor is agnostic to the implementation of its executor. This also cleans up the full spectrum of visibility modifiers on ValueVisitor methods, all of which ought to be private. -- MOS_MIGRATED_REVID=106847453
* Change ValueVisitor to use delegationGravatar Mark Schaller2015-11-02
| | | | | | | | This simplifies a future change that introduces new variance to ValueVisitor's use of AbstractQueueVisitor. -- MOS_MIGRATED_REVID=106846210
* Add runfiles for HOST executables for actions without commands tooGravatar Brian Silverman2015-11-02
| | | | | | | | | | | | 6c51059e0a04d4170d10bfedbd9553b498cf28e7 adds the runfiles for HOST executables listed as inputs to SpawnActions with a command, but it seems reasonable to be able to execute those with non-command SpawnActions (ie shell scripts) too. -- Change-Id: I33b0fe3936afa87c69046350a53ee1485f2beab3 Reviewed-on: https://bazel-review.googlesource.com/#/c/2260/ MOS_MIGRATED_REVID=106845702
* Move LoadingPhaseRunner.Callback to the top-level class LoadingCallback.Gravatar Ulf Adams2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106839024
* Move LoadingPhaseRunner.loadForConfigurations to CommandEnvironment.Gravatar Ulf Adams2015-11-02
| | | | | | | | It's unclear if the method is still necessary with Skyframe, but I don't want to investigate in detail right now. -- MOS_MIGRATED_REVID=106838896
* Move LoadingPhaseRunner.LoadingResult to a top-level class.Gravatar Ulf Adams2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106838787
* Move LoadingPhaseRunner.Options to top-level class LoadingOptions.Gravatar Ulf Adams2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106836859
* Document and test how rules can run without the sandbox.Gravatar Brian Silverman2015-11-02
| | | | | | | | | | The only documentation about usable tags values was in a weird place, along with duplicated information about flaky tests. -- Change-Id: Ib98a0a5c582890512161ecf9f5d89c8e78d9ad68 Reviewed-on: https://bazel-review.googlesource.com/#/c/2220 MOS_MIGRATED_REVID=106832660
* Interface methods are public anyway, remove superfluous modifiers.Gravatar Philipp Wollermann2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106826084
* Remove BlazeRuntime.reporter; use a BlazeModule to attach event handlers.Gravatar Ulf Adams2015-11-02
| | | | | | | | This only affects tests that previously set a Reporter on the BlazeRuntime; the production code is already using the per-command Reporter in all cases. -- MOS_MIGRATED_REVID=106820846
* Introduce ErrorClassifierGravatar Mark Schaller2015-11-02
| | | | | | | | | | Changes the AbstractQueueVisitor strategy for varying its response to unhandled exceptions from inheritance to composition. This will help with a forthcoming switch from inheritance to delegation for ValueVisitor's use of AbstractQueueVisitor. -- MOS_MIGRATED_REVID=106730708
* Introduce QuiescingExecutorGravatar Mark Schaller2015-11-02
| | | | | | | | | | | | This interface (mostly) encapsulates what the ValueVisitor expects from the AbstractQueueVisitor class it currently inherits from. This makes it easier for a future CL to change ValueVisitor's strategy of code reuse from inheritance to composition. RELNOTES: -- MOS_MIGRATED_REVID=106728863
* Pass StdRedirect.dylib to ios_runner.sh.mac_template. So that we could use ↵Gravatar Googler2015-11-02
| | | | | | | | | "xcrun simctl" instead of iossim to launch the app when we invoke "blaze run". The next CL is to use it in ios_runner.sh.mac_template after new bazle is released. -- MOS_MIGRATED_REVID=106725049
* Strict matching of architecture name to ios platform. Also refactor Platform ↵Gravatar Chris Parsons2015-11-02
| | | | | | | into a new .apple package, as it is not relevant for solely objc rules. -- MOS_MIGRATED_REVID=106709486
* Adds a bazel-rules-tests java_test rule for the tests under ↵Gravatar Alex Humesky2015-11-02
| | | | | | | src/test/java/com/google/devtools/build/lib/bazel/rules -- MOS_MIGRATED_REVID=106695490
* Implement propagation along dependencies for Skylark aspects.Gravatar Dmitry Lomov2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106694515
* xcrun was adding a newline on the output that was being set in the SDKROOT ↵Gravatar Dave MacLachlan2015-11-02
| | | | | | | | | environment variable. RELNOTES:none -- MOS_MIGRATED_REVID=106694003
* Create directories for all the files in tarballs.Gravatar Brian Silverman2015-11-02
| | | | | | | | | | dpkg fails to install packages without the directories listed before the files in the data tarball. -- Change-Id: I839ce82de5414d3bf6ed98ec81f576eddcc66bee Reviewed-on: https://bazel-review.googlesource.com/#/c/2212 MOS_MIGRATED_REVID=106693757
* Deflake --runs_per_test_detects_flakes.Gravatar Brian Silverman2015-11-02
| | | | | | | | | | | Previously, if the first run failed (in iteration order, which I don't think is necessarily execution order) then --runs_per_test_detects_flakes would report FAILED instead of FLAKY. -- Change-Id: Ice7889d46203e1598d94a4e3c0bcbe13a45b0fe1 Reviewed-on: https://bazel-review.googlesource.com/#/c/2210/ MOS_MIGRATED_REVID=106693725
* Error out if no src files are provided to GroovyGravatar Erik Kuefler2015-11-02
| | | | | | | | | Otherwise you get groovyc's usage message spammed to stdout -- Change-Id: I04bcfd9166adb6c9287839035f025f93d805e738 Reviewed-on: https://bazel-review.googlesource.com/#/c/2251/ MOS_MIGRATED_REVID=106693428
* Drop src/test/java/BUILDGravatar Han-Wen Nienhuys2015-11-02
| | | | | -- MOS_MIGRATED_REVID=106693383
* Don't overwrite existing __init__.py files in py_binary zipsGravatar Benjamin Staffin2015-10-30
| | | | | | | | | | | | This switches zip from "add" to "update" mode, and only adds __init__.py where it's not already present. Fixes: #542 -- Change-Id: Id65632d1448b403ad328e4a1619c0d4e8ebfdcb4 Reviewed-on: https://bazel-review.googlesource.com/#/c/2250 MOS_MIGRATED_REVID=106690985
* Move local_repository and new_local_repository from build.lib.bazel to ↵Gravatar Lukacs Berki2015-10-30
| | | | | | | build.lib. -- MOS_MIGRATED_REVID=106689603
* Fix indentation.Gravatar Ulf Adams2015-10-30
| | | | | -- MOS_MIGRATED_REVID=106683157
* [jsonnet] Fix jsonnet_to_json rule to read code_vars from code_vars instead ↵Gravatar Googler2015-10-30
| | | | | | | | | of vars. RELNOTES: [jsonnet] Fix jsonnet_to_json rule to read code_vars from code_vars instead of vars. -- MOS_MIGRATED_REVID=106678289
* Make C++ builds work on OS X.Gravatar Lukacs Berki2015-10-30
| | | | | | | Fixes #538. -- MOS_MIGRATED_REVID=106674650
* Augment JNI utime() method.Gravatar Eric Fellheimer2015-10-30
| | | | | -- MOS_MIGRATED_REVID=106634616
* Use plutil instead of plmerge for converting strings files from text to binary.Gravatar Dave MacLachlan2015-10-30
| | | | | -- MOS_MIGRATED_REVID=106613927
* Remove unneeded import.Gravatar Dave MacLachlan2015-10-30
| | | | | -- MOS_MIGRATED_REVID=106613660
* Don't build Java if testing process-wrapper.Gravatar Han-Wen Nienhuys2015-10-30
| | | | | -- MOS_MIGRATED_REVID=106607501
* Cleanup, TODO removalGravatar Laurent Le Brun2015-10-30
| | | | | -- MOS_MIGRATED_REVID=106605940
* handle darwin_x86_64 target cpuGravatar Chris Parsons2015-10-30
| | | | | -- MOS_MIGRATED_REVID=106605250
* Tune down some test sizes.Gravatar Han-Wen Nienhuys2015-10-30
| | | | | | | | | | maven_test on my 2010 Mac Mini: Stats over 20 runs: max = 117.0s, min = 71.7s, avg = 82.6s, dev = 12.1s so the 300s timeout should suffice. -- MOS_MIGRATED_REVID=106604843
* Remove direct uses of Reporter (mostly in internal code).Gravatar Ulf Adams2015-10-30
| | | | | -- MOS_MIGRATED_REVID=106604357
* Moves -printmapping to the end of the Proguard arguments list.Gravatar Michael Staib2015-10-30
| | | | | | | | | | | If the proguard configuration itself contains -printmapping, this will override the -printmapping specified on the command line (by virtue of coming later). Putting it last means that this -printmapping will take precedence over any others, meaning that Proguard will always generate the correct mapping, preventing an action failure from not producing the correct output files. -- MOS_MIGRATED_REVID=106601595
* Fix another test with precompiled jars in srcsGravatar Liam Miller-Cushon2015-10-30
| | | | | | | Follow-up to -- MOS_MIGRATED_REVID=106600502
* Split off more BUILD files.Gravatar Han-Wen Nienhuys2015-10-30
| | | | | -- MOS_MIGRATED_REVID=106597904
* Add Skylark support for string_list_dictGravatar Francois-Rene Rideau2015-10-30
| | | | | | | Convert to Skylark values when destructuring a sequence or map. -- MOS_MIGRATED_REVID=106591523
* Add isSkylark to RuleClassGravatar Michajlo Matijkiw2015-10-30
| | | | | -- MOS_MIGRATED_REVID=106588003
* Add a getPathFragment method to RepositoryName; use it in PackageIdentifier.Gravatar Ulf Adams2015-10-30
| | | | | | | Progress towards #445. -- MOS_MIGRATED_REVID=106585570
* Allow any includes on the Mac for now.Gravatar Ulf Adams2015-10-30
| | | | | -- MOS_MIGRATED_REVID=106584736
* In objc tools, refer to the realpath tool using its full embedded tool ↵Gravatar Chris Parsons2015-10-29
| | | | | | | location. Then, if unavailable, look relative to the workspace. -- MOS_MIGRATED_REVID=106536282
* Make some things in GraphConcurrencyTest protected so subclasses can use them.Gravatar Nathan Harmata2015-10-29
| | | | | -- MOS_MIGRATED_REVID=106533345
* Fix sed command to work on OS X and LinuxGravatar Kristina Chodorow2015-10-29
| | | | | | | | | This was using -i to replace WORKSPACE in-place, but OS X requires -i to take an argument ('' in this case) and Linux expects `sed -i''` and OS X expects `sed -i ''`. -- MOS_MIGRATED_REVID=106530804