aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Clarify documentation of PACKAGE_NAMEGravatar Laurent Le Brun2017-02-15
| | | | | | -- PiperOrigin-RevId: 147517743 MOS_MIGRATED_REVID=147517743
* Correct support for TreeArtifacts with ObjC header thinning feature.Gravatar Googler2017-02-15
| | | | | | -- PiperOrigin-RevId: 147515806 MOS_MIGRATED_REVID=147515806
* Remove type checking requirement from AttributeMap.has.Gravatar Greg Estren2017-02-15
| | | | | | | | | | | | | | This overrides the traditional has(String name, Type<>T> type) with has(String name) and removes the type check outright from isConfigurable. Ideally we'd remove the old version in this same change. But there are enough uses of it that that's not a risk-free change and is safer as followup changes. -- PiperOrigin-RevId: 147513593 MOS_MIGRATED_REVID=147513593
* Rollback of commit 03d1255df1805ed1e5f7512bf0336f71c595791b.Gravatar Googler2017-02-15
| | | | | | | | | | *** Reason for rollback *** Vanilla roll forward -- PiperOrigin-RevId: 147512649 MOS_MIGRATED_REVID=147512649
* Avoid putting objc linkopts and copts in Set, as their order and ↵Gravatar Chris Parsons2017-02-15
| | | | | | | | | | duplicate-args need to be preserved. (Example: "-iquote foo -iquote bar" is a legitimate series of flags) -- PiperOrigin-RevId: 147512419 MOS_MIGRATED_REVID=147512419
* Some minor logging improvements related to diff awareness:Gravatar Nathan Harmata2017-02-15
| | | | | | | | | | | | (i) Log [the first 100] external [non external-repo] file paths when we encounter them in skyframe [when externalFileAction is not ASSUME_NON_EXISTENT_AND_IMMUTABLE_FOR_EXTERNAL_PATHS]. These caveats are to prevent log spam. (ii) Fix grammar when logging the results of handleDiffsWithMissingDiffInformation in the case when all package paths have known diff information and we're merely checking external/output/external-repo files. (iii) Log the purpose of each skyframe graph scan we do (see (ii)). -- PiperOrigin-RevId: 147508404 MOS_MIGRATED_REVID=147508404
* Flips the default value of --explicit_jre_deps to true.Gravatar Googler2017-02-15
| | | | | | | | RELNOTES: Flips --explicit_jre_deps flag on by default. -- PiperOrigin-RevId: 147497803 MOS_MIGRATED_REVID=147497803
* BuildFileAST.eval() doesn't execute the code when there's a static error.Gravatar Laurent Le Brun2017-02-15
| | | | | | | | | | | This has no visible effect on Bazel (eval is used just for internal expressions that don't fail), and is therefore not tested. It will be tested when we add tests to the standalone Skylark interpreter. -- PiperOrigin-RevId: 147495990 MOS_MIGRATED_REVID=147495990
* Clarify documentation about ConceptsGravatar Laurent Le Brun2017-02-15
| | | | | | -- PiperOrigin-RevId: 147491785 MOS_MIGRATED_REVID=147491785
* Specify layout for build-style.md and bzl-style.mdGravatar Laurent Le Brun2017-02-15
| | | | | | -- PiperOrigin-RevId: 147490477 MOS_MIGRATED_REVID=147490477
* Adds --[no]use_action_cache startup option to disable the action cache.Gravatar Googler2017-02-15
| | | | | | | | | Disabling the action cache is helpful in contexts where incremental builds are not required, or where actions need to be repeatedly executed for debugging. -- PiperOrigin-RevId: 147485055 MOS_MIGRATED_REVID=147485055
* Search for Test classes within the classpath used by the current ↵Gravatar Kush Chakraborty2017-02-15
| | | | | | | | | | | | classloader, instead of the system classpath. (2nd Attempt) Windows tests passed on Jenkins with this patch: http://ci.bazel.io/job/Gerrit-bazel-tests/380/, https://bazel-review.googlesource.com/c/8833 -- PiperOrigin-RevId: 147483103 MOS_MIGRATED_REVID=147483103
* Default Bazel builds to nontrimmed dynamic configurations (except LIPO).Gravatar Greg Estren2017-02-15
| | | | | | | | | | LIPO is still not ready yet. Details: https://docs.google.com/document/d/1uoU8t7loTOu6uyzez-ilhcYgEXg4xjViJu0aqrf69TY/edit -- PiperOrigin-RevId: 147478165 MOS_MIGRATED_REVID=147478165
* Rollback of commit 60b525597bf7aafdec99ea51c7f82ce5801b4725.Gravatar Dmitry Lomov2017-02-14
| | | | | | | | | | | | | | *** Reason for rollback *** Follow-up for CI breakage. *** Original change description *** Fix bazel build on CI. -- PiperOrigin-RevId: 147475894 MOS_MIGRATED_REVID=147475894
* Rollback of commit 01aa7d6f177f3284b5fecc0397bf29a605b37df0.Gravatar Dmitry Lomov2017-02-14
| | | | | | | | | | | | | | | *** Reason for rollback *** Breaks the CI: http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.7,PLATFORM_NAME=linux-x86_64/1270/console *** Original change description *** Adds support for pushing sites that don't need build, and build benchmark site. This should not affect CI for now. -- PiperOrigin-RevId: 147474775 MOS_MIGRATED_REVID=147474775
* Refactoring: Types report what class of labels they contain.Gravatar Michael Staib2017-02-14
| | | | | | | | | | | | | | | | | | | | | Currently label-type attributes are detected in many places across the codebase by simply reference-comparing against each of the label types. This CL aims to generalize most of these cases, moving the encoding of this logic into a single place (Type/BuildType itself). Not all of these cases can be made general without further refactoring, and some perhaps shouldn't be - serialization and Skylark rule context, for example, need to do exotic things based on the type. But most sites can avoid having to enumerate all the types they work with explicitly. This causes LABEL_DICT_UNARY to start being treated like the other label types, which means that CcToolchainSuiteRule and JavaRuntimeSuiteRule need to include a set of allowed file types (none, in their case). Skylark will continue treating it as a dictionary from String to Label in its rule context, however, to avoid visible behavior changes. -- PiperOrigin-RevId: 147471542 MOS_MIGRATED_REVID=147471542
* Skylark repositories: add a test to test correct invalidation with change to ↵Gravatar Damien Martin-Guillerez2017-02-14
| | | | | | | | | | | | | | | | | bzl files The marker file contains the hash of the Skylark extension from the ruleKey, see RuleFormatter.java#L44. Design doc: https://bazel.build/designs/2016/10/18/repository-invalidation.html [step 6] Issue #1022. -- Change-Id: I6da5e1f8797fa5ee20401ede29c67ccf1a8cef5a Reviewed-on: https://cr.bazel.build/8150 PiperOrigin-RevId: 147470732 MOS_MIGRATED_REVID=147470732
* Fix bazel build on CI.Gravatar Yue Gan2017-02-14
| | | | | | -- PiperOrigin-RevId: 147470288 MOS_MIGRATED_REVID=147470288
* Make Bazel work with Visual Studio 2017 Gravatar Yun Peng2017-02-14
| | | | | | | | | | | | | | | Now Bazel can detect MSVC from Visual Studio 2017 or Visual C++ build tools 2017. Also modified build_windows_jni.sh to make it work with VS 2017. Fixed: https://github.com/bazelbuild/bazel/issues/2440 -- Change-Id: I4afbce809ff74634f32fab87efe5e7f0b3f60c95 Reviewed-on: https://cr.bazel.build/8890 PiperOrigin-RevId: 147467993 MOS_MIGRATED_REVID=147467993
* Disable tests on JDK7 that are not supported by a new JavaBuilder.Gravatar Dmitry Lomov2017-02-14
| | | | | | -- PiperOrigin-RevId: 147464014 MOS_MIGRATED_REVID=147464014
* Use the test's PATH to resolve the --run_under commandGravatar Ulf Adams2017-02-14
| | | | | | | | | | | | | | | | | | | The change that originally introduced local PATH lookup was made a very long time ago, and it's unclear what the exact reasons were. This change makes the local and remote test execution code paths more consistent, which minimizes surprises. Bazel currently forwards the local PATH by default, so this should be a no-op. Ideally, we'd require PATH forwarding to be explicit, e.g., with --action_env=PATH, --test_env=PATH, or --run_under=$(which command). RELNOTES[INC]: Bazel now uses the test's PATH for commands specified as --run_under; this can affect users who explicitly set PATH to a more restrictive value than the default, which is to forward the local PATH -- PiperOrigin-RevId: 147457058 MOS_MIGRATED_REVID=147457058
* Note that --config can be picked up from rc files.Gravatar Googler2017-02-14
| | | | | | -- PiperOrigin-RevId: 147456771 MOS_MIGRATED_REVID=147456771
* Fix the documentation of set/depsetGravatar Vladimir Moskva2017-02-14
| | | | | | -- PiperOrigin-RevId: 147456653 MOS_MIGRATED_REVID=147456653
* Reinstate idleness checks where the server self-terminates when it's idle ↵Gravatar Lukacs Berki2017-02-14
| | | | | | | | | | and there is either too much memory pressure or the workspace directory is gone. Arguably, it should kill itself when the workspace directory is gone regardless of whether it's idle or not, but let's first get us back to a known good state, then we can think about improvements. -- PiperOrigin-RevId: 147454329 MOS_MIGRATED_REVID=147454329
* Avoid using //external labels; use @local_jdk// insteadGravatar Ulf Adams2017-02-14
| | | | | | -- PiperOrigin-RevId: 147449557 MOS_MIGRATED_REVID=147449557
* Windows JNI, refactor: move OpenDirectory to JNIGravatar Laszlo Csomor2017-02-14
| | | | | | | | | | | | Move the OpenDirectory helper method into the JNI library. We'll need it there; a subsequent change will make use of it there. See https://github.com/bazelbuild/bazel/issues/2107 -- PiperOrigin-RevId: 147448792 MOS_MIGRATED_REVID=147448792
* Remove special handling of name attribute. Fixes #278Gravatar Googler2017-02-14
| | | | | | | | | | | | | | | | | | | | | | | | | The name attribute gets special treatment in the codebase, in that it's not simply yet another attribute but stored in it's own field. Thus, every callside dealing with attributes needs to be aware of this special case and explicitly handle the name attribute. It's easy to see that this can lead to bugs. For example, querying for the name attribute is currently broken due the querying code not being aware of the special case [1]. Discussions with experienced bazel developers came to the conclusion that there is no need (anymore) to treat the name attribute specially and thus we decided it's best to remove the special treatment and handle the name attribute as any other attribute. This change removes the handling of name attributes and also adds a test case to verify that bug [1] is fixed. [1] https://github.com/bazelbuild/bazel/issues/278 -- PiperOrigin-RevId: 147446345 MOS_MIGRATED_REVID=147446345
* Make android_device pass --android_sdk_path to unified launcher.Gravatar Adam Michael2017-02-14
| | | | | | | | Creates filegroup containing sdk path in Bazel embedded Android SDK repository. -- PiperOrigin-RevId: 147426838 MOS_MIGRATED_REVID=147426838
* Exposes generated manifest artifact (this is the resulting artifact after ↵Gravatar Googler2017-02-14
| | | | | | | | the merge step) to Skylark. -- PiperOrigin-RevId: 147417110 MOS_MIGRATED_REVID=147417110
* Rollback of commit 51d245879ed2729f15c6c6a35b319a4277e7cd64.Gravatar Carmi Grushko2017-02-14
| | | | | | -- PiperOrigin-RevId: 147416635 MOS_MIGRATED_REVID=147416635
* Rollback of commit e15a31a3281ae386935d33f857351adea767b420.Gravatar Liam Miller-Cushon2017-02-14
| | | | | | | | | | *** Reason for rollback *** JavaBuilder 0.1 is obsolesced unknown commit -- PiperOrigin-RevId: 147398785 MOS_MIGRATED_REVID=147398785
* Add a test to PackageFunctionTest confirming current glob behavior.Gravatar Janak Ramakrishnan2017-02-14
| | | | | | -- PiperOrigin-RevId: 147396952 MOS_MIGRATED_REVID=147396952
* Rollback of commit cdbad585187dfe7bbb4d69ad68a1baf852beb691.Gravatar Michael Staib2017-02-14
| | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks Skylark aspects running over rules with LABEL_DICT_UNARY attributes. *** Original change description *** Refactoring: Types report what class of labels they contain. Currently label-type attributes are detected in many places across the codebase by simply reference-comparing against each of the label types. This CL aims to generalize most of these cases, moving the encoding of this logic into a single place (Type/BuildType itself). Not all of these cases can be made general without further refactoring, and some perhaps shouldn't be - serialization and Skylark rule context, for example, need to do... -- PiperOrigin-RevId: 147385072 MOS_MIGRATED_REVID=147385072
* Clarify that load() statements do not respect visibility.Gravatar Laurent Le Brun2017-02-14
| | | | | | -- PiperOrigin-RevId: 147384211 MOS_MIGRATED_REVID=147384211
* Make tests that mess with the WORKSPACE file work with untrimmed dynamic ↵Gravatar Greg Estren2017-02-14
| | | | | | | | | | | | | | | | | | | | configs. They already work with static configs because those configs get created in test setup, before WORKSPACE is modified. That means they get the necessary bindings needed to load their fragments (e.g. local_config_xcode for AppleConfiguration). But dynamic configs get instantiated on-demand. Which means in this case *after* WORKSPACE is overwritten. So they can't find the bindings and fail. This fix has offending tests *append* WORKSPACE instead of overwrite. This unblocks defaulting --experimental_dynamic_configs to "notrim_partial". -- PiperOrigin-RevId: 147377195 MOS_MIGRATED_REVID=147377195
* Allow objc.signing_certificate_name to return None in Skylark.Gravatar Googler2017-02-14
| | | | | | -- PiperOrigin-RevId: 147375812 MOS_MIGRATED_REVID=147375812
* Publish build-style.md and bzl-style.mdGravatar Laurent Le Brun2017-02-14
| | | | | | | | Not sure if it's enough for them to show up on bazel.build website? -- PiperOrigin-RevId: 147365969 MOS_MIGRATED_REVID=147365969
* JUnit4 now correctly labels filtered tests as "filtered".Gravatar Googler2017-02-14
| | | | | | -- PiperOrigin-RevId: 147362001 MOS_MIGRATED_REVID=147362001
* Stop retrieving FdoSupport statically from hard-coded attribute ↵Gravatar Rumou Duan2017-02-14
| | | | | | | | | | ":cc_toolchain" in RuleContext, instead take the provider from users and pass it around to where it is used. This gives J2ObjcAspect the ability to specify the C++ toolchain attribute under a different name to avoid attribute conflicts with attached rules that have already declared attribute ":cc_toolchain". -- PiperOrigin-RevId: 147358325 MOS_MIGRATED_REVID=147358325
* Open source the integration tests for BazelTestRunner and delete the ↵Gravatar Kush Chakraborty2017-02-14
| | | | | | | | internal versions. -- PiperOrigin-RevId: 147355493 MOS_MIGRATED_REVID=147355493
* Add an algorithm to reduce aspect paths according to aspects' visibility to ↵Gravatar Dmitry Lomov2017-02-14
| | | | | | | | | | | | each other. Aspects negotiate their visibility by advertizing and requiring providers. The algorithm is not used yet (that is future work). -- PiperOrigin-RevId: 147354682 MOS_MIGRATED_REVID=147354682
* Fix IllegalStateException when loading from a non declared external repository Gravatar Damien Martin-Guillerez2017-02-14
| | | | | | | | | | | This is another instance of #1793 that happens when a WORKSPACE file exists in some path underneath your current workspace. -- Change-Id: Idb01cd643548a170a27c9103f1b5081b058cc005 Reviewed-on: https://cr.bazel.build/8143 PiperOrigin-RevId: 147353935 MOS_MIGRATED_REVID=147353935
* Doc: mention profiling and specification.Gravatar Laurent Le Brun2017-02-14
| | | | | | | | Also clean up the rest of the page. -- PiperOrigin-RevId: 147353770 MOS_MIGRATED_REVID=147353770
* Allow Skylark aspects to advertise providers.Gravatar Dmitry Lomov2017-02-14
| | | | | | -- PiperOrigin-RevId: 147350507 MOS_MIGRATED_REVID=147350507
* Adds support for pushing sites that don't need build, and build benchmark site.Gravatar Yue Gan2017-02-14
| | | | | | | | This should not affect CI for now. -- PiperOrigin-RevId: 147346229 MOS_MIGRATED_REVID=147346229
* Add environ attribute to repository_rule Gravatar Damien Martin-Guillerez2017-02-14
| | | | | | | | | | | | | | | | | | | This environ attribute let the repository rule implementor describes on which environment variable change a repository should be refetched. RELNOTES[NEW]: environ parameter to the repository_rule function let defines a list of environment variables for which a change of value will trigger a repository refetching. Design doc: https://bazel.build/designs/2016/10/18/repository-invalidation.html [step 3 & 4] Fixes #1595. -- Change-Id: Ibc2f93e69cb08baf86107cc9a9428b7a0eba1bac Reviewed-on: https://cr.bazel.build/8139 PiperOrigin-RevId: 147345203 MOS_MIGRATED_REVID=147345203
* Windows: fix bootstrapping bugs with 0.4.4 Gravatar László Csomor2017-02-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix 3 bugs to get bootstrapping working on Windows after it was broken in bazel-0.4.4: * Move the definition of PATHSEP to before the code that overrides it for Windows * Fix the Java code processing the --javahome flag to recognize absolute Windows paths as absolute. See: https://github.com/bazelbuild/bazel/issues/2520 * Do not propagate the JAVA_HOME value in variables, because it contains spaces on Windows, and when we pass the variable to Bazel, and it's expanded to e.g. ... --foo=C:/Program Files, these are interpreted as two args instead of one. Also fix a bug that is just annoying, not causing any trouble (on Windows): * Silently swallow errors from the "rm -rf" in the atexit functions Also do some refactoring: * Rename a variable (BAZEL_ARGS) and a method to indicate they're private. They are not used from anywhere else as far as I know -- no occurrences in either the bazel or the continuous-integration repos. Fixes: https://github.com/bazelbuild/bazel/issues/2473 -- Change-Id: I309752cd7bbff0b5dd683ddb5573f3061350043c Reviewed-on: https://cr.bazel.build/8797 PiperOrigin-RevId: 147345194 MOS_MIGRATED_REVID=147345194
* Rollback of commit 3bed84ff177c7cbfd0c8d315829cc9dcb35fcf70.Gravatar Dmitry Lomov2017-02-13
| | | | | | | | | | | | | | | | *** Reason for rollback *** This breaks Bazel CI: http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/556/console *** Original change description *** Make android_sdk_repository fail if api_level requested is not installed. This could have prevented https://github.com/bazelbuild/bazel/issues/2500. -- PiperOrigin-RevId: 147338519 MOS_MIGRATED_REVID=147338519
* Supports drawing charts for multiple output files, which allows runningGravatar Yue Gan2017-02-13
| | | | | | | | benchmark and pushing output to website on CI. -- PiperOrigin-RevId: 147336476 MOS_MIGRATED_REVID=147336476
* Windows-aware path-absoluteness checks.Gravatar Laszlo Csomor2017-02-13
| | | | | | | | | Fixes: https://github.com/bazelbuild/bazel/issues/2520 Fixes one of the bugs causing https://github.com/bazelbuild/bazel/issues/2473 -- PiperOrigin-RevId: 147335357 MOS_MIGRATED_REVID=147335357