aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/main/java/com/google/devtools/build/lib/packages/SkylarkAspect.java5
-rw-r--r--src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java7
2 files changed, 9 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/SkylarkAspect.java b/src/main/java/com/google/devtools/build/lib/packages/SkylarkAspect.java
index b3bce846a2..994087668b 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/SkylarkAspect.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/SkylarkAspect.java
@@ -97,14 +97,13 @@ public class SkylarkAspect implements SkylarkExportable {
@Override
public void repr(SkylarkPrinter printer) {
- printer.append("Aspect:");
- implementation.repr(printer);
+ printer.append("<aspect>");
}
@Override
public void reprLegacy(SkylarkPrinter printer) {
printer.append("Aspect:");
- implementation.reprLegacy(printer);
+ printer.repr(implementation);
}
public String getName() {
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java
index d503ec9803..35d4d1d0d4 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java
@@ -232,6 +232,13 @@ public class SkylarkStringRepresentationsTest extends SkylarkTestCase {
}
@Test
+ public void testStringRepresentations_Aspects() throws Exception {
+ setSkylarkSemanticsOptions("--incompatible_descriptive_string_representations=true");
+
+ assertStringRepresentation("aspect(implementation=str)", "<aspect>");
+ }
+
+ @Test
public void testLegacyStringRepresentations_Labels() throws Exception {
setSkylarkSemanticsOptions("--incompatible_descriptive_string_representations=false");