diff options
Diffstat (limited to 'src/tools/runfiles/runfiles.h')
| -rw-r--r-- | src/tools/runfiles/runfiles.h | 19 |
1 files changed, 12 insertions, 7 deletions
diff --git a/src/tools/runfiles/runfiles.h b/src/tools/runfiles/runfiles.h index 821cc1aa6f..b29981e7f6 100644 --- a/src/tools/runfiles/runfiles.h +++ b/src/tools/runfiles/runfiles.h @@ -19,7 +19,9 @@ #ifndef BAZEL_SRC_TOOLS_RUNFILES_RUNFILES_H_ #define BAZEL_SRC_TOOLS_RUNFILES_RUNFILES_H_ 1 +#include <memory> #include <string> +#include <vector> namespace bazel { namespace runfiles { @@ -28,11 +30,6 @@ class Runfiles { public: virtual ~Runfiles() {} - // TODO(laszlocsomor): implement: - // Runfiles* Create(const string& argv0, string* error); - // TODO(laszlocsomor): implement: - // vector<pair<string, string>> EnvVars(); - // Returns a new manifest-based `Runfiles` instance. // Returns nullptr on error. If `error` is provided, the method prints an // error message into it. @@ -63,6 +60,13 @@ class Runfiles { // an empty string if the method doesn't know about this runfile virtual std::string Rlocation(const std::string& path) const = 0; + // Returns environment variables for subprocesses. + // + // The caller should set the returned key-value pairs in the environment of + // subprocesses in case those subprocesses are also Bazel-built binaries that + // need to use runfiles. + virtual std::vector<std::pair<std::string, std::string> > EnvVars() const = 0; + protected: Runfiles() {} @@ -74,8 +78,9 @@ class Runfiles { }; // The "testing" namespace contains functions that allow unit testing the code. -// Do not use these outside of runfiles_test.cc, because they may change without -// notice. +// Do not use these outside of runfiles_test.cc, they are only part of the +// public API for the benefit of the tests. +// These functions and their interface may change without notice. namespace testing { // For testing only. |