diff options
Diffstat (limited to 'src/main/java/com/google/devtools/build/skyframe')
-rw-r--r-- | src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java | 6 | ||||
-rw-r--r-- | src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java | 10 |
2 files changed, 12 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java b/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java index 459c7ffc7d..cd6a986acd 100644 --- a/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java +++ b/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java @@ -114,8 +114,10 @@ public abstract class InvalidatingNodeVisitor<TGraph extends ThinNodeQueryableGr } @Override - protected boolean isCriticalError(Throwable e) { - return e instanceof RuntimeException; + protected ErrorClassification classifyError(Throwable e) { + return e instanceof RuntimeException + ? ErrorClassification.CRITICAL_AND_LOG + : ErrorClassification.NOT_CRITICAL; } protected abstract long count(); diff --git a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java index 6dc31eeaf6..243577ecc6 100644 --- a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java +++ b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java @@ -607,8 +607,14 @@ public final class ParallelEvaluator implements Evaluator { } @Override - protected boolean isCriticalError(Throwable e) { - return e instanceof RuntimeException; + protected ErrorClassification classifyError(Throwable e) { + if (e instanceof SchedulerException) { + return ErrorClassification.CRITICAL; + } + if (e instanceof RuntimeException) { + return ErrorClassification.CRITICAL_AND_LOG; + } + return ErrorClassification.NOT_CRITICAL; } protected void waitForCompletion() throws InterruptedException { |