diff options
Diffstat (limited to 'src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java b/src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java index 8c3126f38b..8e1d3cfb81 100644 --- a/src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java +++ b/src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java @@ -191,7 +191,7 @@ class SkyFunctionEnvironment extends AbstractSkyFunctionEnvironment { + skyKey + ". Present values: " + deps - + "requested from: " + + " requested from: " + depKeys + ", " + entry); @@ -262,8 +262,7 @@ class SkyFunctionEnvironment extends AbstractSkyFunctionEnvironment { } Preconditions.checkState( triState == DependencyState.DONE, "%s %s %s", skyKey, triState, errorInfo); - state.addTemporaryDirectDeps( - GroupedListHelper.create(ImmutableList.of(ErrorTransienceValue.KEY))); + state.addTemporaryDirectDeps(GroupedListHelper.create(ErrorTransienceValue.KEY)); state.signalDep(); } @@ -467,10 +466,7 @@ class SkyFunctionEnvironment extends AbstractSkyFunctionEnvironment { } private void addDep(SkyKey key) { - if (!newlyRequestedDeps.contains(key)) { - // dep may have been requested already this evaluation. If not, add it. - newlyRequestedDeps.add(key); - } + newlyRequestedDeps.add(key); } /** |