diff options
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/syntax')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/syntax/Identifier.java | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/Identifier.java b/src/main/java/com/google/devtools/build/lib/syntax/Identifier.java index a4e7a9ecc0..e2bd0e351f 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/Identifier.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/Identifier.java @@ -19,13 +19,9 @@ import java.io.IOException; import java.util.Set; import javax.annotation.Nullable; -// TODO(bazel-team): for extra performance: -// (1) intern the strings, so we can use == to compare, and have .equals use the assumption. -// Then have Argument and Parameter use Identifier again instead of String as keys. -// (2) Use Identifier, not String, as keys in the Environment, which will be cleaner. -// (3) For performance, avoid doing HashMap lookups at runtime, and compile local variable access -// into array reference with a constant index. Variable lookups are currently a speed bottleneck, -// as previously measured in an experiment. +// TODO(bazel-team): For performance, avoid doing HashMap lookups at runtime, and compile local +// variable access into array reference with a constant index. Variable lookups are currently a +// speed bottleneck, as previously measured in an experiment. /** * Syntax node for an identifier. * |