diff options
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/SkyframeActionExecutor.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeActionExecutor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeActionExecutor.java index 1f4b1188c4..7f6e1801f3 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeActionExecutor.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeActionExecutor.java @@ -949,9 +949,9 @@ public final class SkyframeActionExecutor implements ActionExecutionContextFacto private boolean checkOutputs(Action action, MetadataHandler metadataHandler) { boolean success = true; for (Artifact output : action.getOutputs()) { - // artifactExists has the side effect of potentially adding the artifact to the cache, - // therefore we only call it if we know the artifact is indeed not omitted to avoid any - // unintended side effects. + // getMetadata has the side effect of adding the artifact to the cache if it's not there + // already (e.g., due to a previous call to MetadataHandler.injectDigest), therefore we only + // call it if we know the artifact is not omitted. if (!metadataHandler.artifactOmitted(output)) { try { metadataHandler.getMetadata(output); |