diff options
author | 2017-05-16 16:34:58 +0200 | |
---|---|---|
committer | 2017-05-17 15:17:56 +0200 | |
commit | de92f9d8ea093416fae999073bbfcf3cf501ab55 (patch) | |
tree | ed24c618c90628cdf3f1fe9e369b3a915e9ec570 /src/test/java/com/google/devtools/build/lib/analysis | |
parent | 7184b6f55a8cb72094a481d056fe89bc7be80c76 (diff) |
Automated g4 rollback of commit b71e99b1f3746103e5d6802eebc24096b3494959.
*** Reason for rollback ***
Causes crash bug in certain circumstances.
*** Original change description ***
Implement dynamically configured LIPO builds.
Quick overview:
- provide a dynamic interface for getting the artifact owner
configuration
- provide a (dynamic) RuleTransitionFactory LIPO_ON_DEMAND to replace
the (static) RuleClass.Configurator LIPO_ON_DEMAND. Eventually
we'll remove the rule class configurator interface entirely.
This doesn't actually turn dynamic LIPO on. So the direct effect of
this change should be a no-op. The flip will come in a followup
change. For now, dynamic...
PiperOrigin-RevId: 156180015
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/analysis')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java index 0a455ae0c2..1c88d6d8b4 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java @@ -1465,8 +1465,12 @@ public abstract class BuildViewTestCase extends FoundationTestCase { return Iterables.getOnlyElement(masterConfig.getTargetConfigurations()); } - protected BuildConfiguration getDataConfiguration() throws InterruptedException { - return getConfiguration(getTargetConfiguration(), ConfigurationTransition.DATA); + protected BuildConfiguration getDataConfiguration() { + BuildConfiguration targetConfig = getTargetConfiguration(); + // TODO(bazel-team): do a proper data transition for dynamic configurations. + return targetConfig.useDynamicConfigurations() + ? targetConfig + : targetConfig.getConfiguration(ConfigurationTransition.DATA); } protected BuildConfiguration getHostConfiguration() { @@ -1496,6 +1500,7 @@ public abstract class BuildViewTestCase extends FoundationTestCase { /** * Returns an attribute value retriever for the given rule for the target configuration. + */ protected AttributeMap attributes(RuleConfiguredTarget ct) { return ConfiguredAttributeMapper.of(ct); |