diff options
author | Akira Baruah <akira.baruah@gmail.com> | 2017-10-11 11:32:50 +0200 |
---|---|---|
committer | Marcel Hlopko <hlopko@google.com> | 2017-10-11 13:57:44 +0200 |
commit | 0a63dadf4eafbae1730f88644b0c537fb1c16d5c (patch) | |
tree | 48a05dc9bb3b90c75695f642d212a58bb5f665c2 /src/test/java | |
parent | 8e04f24517feb48024f21aa2cf672550463107cf (diff) |
Properly escape GitHub repository download URL for git_repository w/ sha256
Addresses #3661
Closes #3770.
PiperOrigin-RevId: 171797773
Diffstat (limited to 'src/test/java')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/bazel/repository/GitClonerTest.java | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/bazel/repository/GitClonerTest.java b/src/test/java/com/google/devtools/build/lib/bazel/repository/GitClonerTest.java index 10b668b171..738058c421 100644 --- a/src/test/java/com/google/devtools/build/lib/bazel/repository/GitClonerTest.java +++ b/src/test/java/com/google/devtools/build/lib/bazel/repository/GitClonerTest.java @@ -19,9 +19,11 @@ import static org.mockito.Matchers.any; import static org.mockito.Matchers.anyListOf; import static org.mockito.Matchers.anyMapOf; import static org.mockito.Matchers.eq; +import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; import com.google.common.base.Optional; +import com.google.common.collect.ImmutableList; import com.google.common.collect.Maps; import com.google.devtools.build.lib.analysis.util.BuildViewTestCase; import com.google.devtools.build.lib.bazel.repository.cache.RepositoryCache; @@ -82,6 +84,14 @@ public class GitClonerTest extends BuildViewTestCase { HttpDownloadValue value = GitCloner.clone( rule, outputDirectory, eventHandler, clientEnvironment, downloader); + verify(downloader) + .download( + eq(ImmutableList.of(new URL("https://github.com/foo/bar/archive/1.2.3.tar.gz"))), + any(String.class), + eq(Optional.of("tar.gz")), + eq(outputDirectory), + any(ExtendedEventHandler.class), + anyMapOf(String.class, String.class)); assertThat(value).isNotNull(); assertThat(value.getPath()).isEqualTo(outputDirectory); } |