aboutsummaryrefslogtreecommitdiffhomepage
path: root/absl/flags/internal/flag.cc
diff options
context:
space:
mode:
authorGravatar Abseil Team <absl-team@google.com>2020-02-11 10:47:28 -0800
committerGravatar Mark Barolak <mbar@google.com>2020-02-11 13:50:53 -0500
commit98eb410c93ad059f9bba1bf43f5bb916fc92a5ea (patch)
tree4dffc4639ac9100f754b9db7ba8895322435b8ea /absl/flags/internal/flag.cc
parentbf78e977309c4cb946914b456404141ddac1c302 (diff)
Export of internal Abseil changes
-- daa829a331a2316713681b5fe7630d1951e0fdec by Gennadiy Rozental <rogeeff@google.com>: Eliminate Flag's destroy method. The Abseil Flags are never destroyed. The only place where Destroy method was invoked was in some obscure place during flag registration, where we faces with duplicate retired flag registration. Regired Flag destruction is empty anyway. so we can just delete the duplicate object. The FLagImpl::Destroy is never invoked. PiperOrigin-RevId: 294472413 -- 3c159499ccde8ccdd6907b3a1ddb26be7d3f016f by Abseil Team <absl-team@google.com>: Internal change. PiperOrigin-RevId: 294401573 -- 25910db425c50d9b9a8f8275af5a67c2935934fd by Shahriar Rouf <nafi@google.com>: Optimize absl::string_view::compare. Motivation: https://godbolt.org/z/Uz8DWV PiperOrigin-RevId: 294286196 GitOrigin-RevId: daa829a331a2316713681b5fe7630d1951e0fdec Change-Id: I818dad27ac5eb61bb7632e01224953cd882803bf
Diffstat (limited to 'absl/flags/internal/flag.cc')
-rw-r--r--absl/flags/internal/flag.cc21
1 files changed, 0 insertions, 21 deletions
diff --git a/absl/flags/internal/flag.cc b/absl/flags/internal/flag.cc
index cfc0cf4..ba70da9 100644
--- a/absl/flags/internal/flag.cc
+++ b/absl/flags/internal/flag.cc
@@ -120,27 +120,6 @@ absl::Mutex* FlagImpl::DataGuard() const {
return reinterpret_cast<absl::Mutex*>(&data_guard_);
}
-void FlagImpl::Destroy() {
- {
- absl::MutexLock l(DataGuard());
-
- // Values are heap allocated for Abseil Flags.
- if (value_.dynamic) Delete(op_, value_.dynamic);
-
- // Release the dynamically allocated default value if any.
- if (DefaultKind() == FlagDefaultKind::kDynamicValue) {
- Delete(op_, default_src_.dynamic_value);
- }
-
- // If this flag has an assigned callback, release callback data.
- if (callback_) delete callback_;
- }
-
- absl::MutexLock l(&flag_mutex_lifetime_guard);
- DataGuard()->~Mutex();
- is_data_guard_inited_ = false;
-}
-
void FlagImpl::AssertValidType(const flags_internal::FlagOpFn op) const {
// `op` is the unmarshaling operation corresponding to the declaration
// visibile at the call site. `op_` is the Flag's defined unmarshalling