From f473694b272b517e13d14d85916c43c6b03ddda4 Mon Sep 17 00:00:00 2001 From: Jeffrey Hutzelman Date: Mon, 11 Feb 2013 23:39:44 -0500 Subject: server: Don't check auth on client acks Client acks don't actually include authenticators or checksums, but do claim to be authed if the original notice was. So, don't bother ever checking authentication on client acks. This fixes #93 --- server/dispatch.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/server/dispatch.c b/server/dispatch.c index 256a786..9981581 100644 --- a/server/dispatch.c +++ b/server/dispatch.c @@ -205,6 +205,12 @@ handle_packet(void) whence = &whoisit; } + /* Don't bother checking authentication on client ACKs */ + if (new_notice.z_kind == CLIENTACK) { + nack_cancel(&new_notice, &whoisit); + return; + } + /* Clients don't check auth of acks, nor do we make it so they can in general, so this is safe. */ if (new_notice.z_kind == SERVACK || new_notice.z_kind == SERVNAK) { -- cgit v1.2.3