Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | Clean up warnings | Jeffrey Hutzelman | 2013-02-14 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Eliminate compiler warnings due to various issues (listed below). This allows Zephyr to build cleanly under GCC versions ranging from 4.1.0 to 4.7.2 with all of the options shown below: -g -O2 -Wall -Werror -Wno-deprecated-declarations -Wmissing-declarations -Wpointer-arith -Wstrict-prototypes -Wshadow -Wextra -Wno-missing-field-initializers -Wno-unused-parameter and, on recent versions, -Wunreachable-code Test builds were done - On Ubuntu 12.10 (Quantal Quetzal) using both MIT Kerberos 1.10.1 and Heimdal 1.6, without krb4 and both with and without C-Ares and Hesiod - On Fedora 14 using Heimdal 0.6, without C-Ares or Hesiod and both with and without krb4 (KTH Kerberos 1.3rc2) - On Fedora Core 3, Fedora Core 5, Fedora 7, and Fedora 10, using Heimdal 0.6 and without C-Ares, Hesiod, or krb4 It also allows clean builds on Solaris 10 under the Sun Studio 12 (9/07) C compiler with the following options: -g -fd -v -errfmt -errhdr=%user -errtags=yes -errwarn=%all -erroff=E_OLD_STYLE_FUNC_DECL,E_ENUM_TYPE_MISMATCH_ARG,E_ARG_INCOMPATIBLE_WITH_ARG ... and under Solaris 9 with the Sun Forte 7 (3/02) C compiler with the above options and -erroff=E_FUNC_HAS_NO_RETURN_STMT. Solaris builds were done with Heimdal 0.6 and without C-Ares, Hesiod, or krb4. The following types of issues are addressed in this change: - Parameters and local variables with the same names as library functions - Parameters and local variables with the same names as globals - Declarations for exported global variables missing from headers - Prototypes for exported functions missing from headers - Missing 'static' on functions that shouldn't be exported - Old-style function declarations - Duplicate declarations - Type mismatches - Unused variables and functions - Uninitialized variables - Forward references to enums - Necessary header files not included - Violations of the aliasing rules, where GCC was able to detect them - Missing braces on if blocks that might be empty - Attempts to do pointer arithmetic on pointers of type void *, which is not permitted in standard C. - An attempt to pass a function pointer via a void * parameter, which is not permitted in standard C. Instead, we now pass a pointer to a structure, which then contains the required function pointer. - Unnecessary inclusion of <krb5_err.h>, which is already included by <krb5.h> when the former exists, and might not be protected against double inclusion, depending on which com_err was used. - Missing include of <com_err.h>, which was masked by the fact that it is included by headers generated by e2fsprogs compile_et - Use of com_err() with a non-constant value in place of the format string, which in every case was a fixed-size buffer in which a message was built using sprintf(!). Both the calls to sprintf and the fixed-size buffers have been removed, in favor of just letting com_err() do the formatting. - Various cases where X library functions expecting a parameter of type wchar_t * were instead passed a parameter of type XChar2b *. The two types look similar, but are not the same and are _not_ interchangeable. - An overly-simplistic configure test which failed to detect existence of <term.h> on Solaris, due to not including <curses.h>. - Using the wrong type for the flags output of krb5_auth_con_getflags() when building against Heimdal. A configure test is added to detect the correct type. | ||
* | check the return code from krb5_get_default_realm _before_ dereferencing | Karl Ramm | 2010-11-08 |
| | | | | the pointer | ||
* | stop using MAXHOSTNAMELEN in a variety of places. Also ↵ | Karl Ramm | 2010-08-24 |
| | | | | nuke-trailing-whitespace. | ||
* | use less oddball types | Karl Ramm | 2009-04-21 |
| | |||
* | Clean up $Zephyr$s | Karl Ramm | 2009-04-14 |
| | |||
* | Export a new variable, Zauthtype, which indicates what sort of authentication | Karl Ramm | 2009-04-14 |
| | | | | | | | | | the library was compiled for. Use this variable in the tests such that they will pass (and, like, test something) if the library was not compiled with authentication. | ||
* | should not be exported | Karl Ramm | 2009-04-14 |
| | |||
* | apple error table initialization for #41 | Karl Ramm | 2009-04-02 |
| | |||
* | Explicitly #include <arpa/nameser_compat.h> if it exists. | Karl Ramm | 2009-04-02 |
| | |||
* | Attempt to compensate for mit krb5_get_realm_host_host stupidity. | Karl Ramm | 2008-12-29 |
| | |||
* | remove macros complicating behind-the-scenes rearranging | Karl Ramm | 2008-12-24 |
| | |||
* | We don't really need a macro for ZGetRealm, do we? | Karl Ramm | 2008-12-22 |
| | |||
* | cleanup various warnings from gcc -Wall | Karl Ramm | 2008-01-21 |
| | |||
* | first pass de-K&Rify lib | Karl Ramm | 2008-01-20 |
| | |||
* | applied athena-update-branch patch | Karl Ramm | 2007-12-25 |
| | |||
* | Some RCS ID cleanup: delete $Log$ and replace other RCS keywords with $Id$. | Greg Hudson | 1999-01-22 |
| | |||
* | Move some variable definitions out of #ifdef HAVE_KRB4 to fix the | Greg Hudson | 1998-06-10 |
| | | | | non-krb4 compile case. | ||
* | Make __My_addr a struct in_addr and initialize it in ZInit() instead of | Greg Hudson | 1998-03-17 |
| | | | | | | having a special function in Zinternal.c. More importantly, do a better job of finding the local address by using getsockname() on a connected UDP socket. | ||
* | ZEPHYR_USES_KERBEROS -> HAVE_KRB4; ZEPHYR_USES_HESIOD -> HAVE_HESIOD | Greg Hudson | 1997-10-25 |
| | |||
* | Initialize __Zephyr_realm in the non-Kerberos case, since we no longer | Greg Hudson | 1997-09-23 |
| | | | | put a macro in the header file for that.> | ||
* | Pull in sources from zephyr locker. See /mit/zephyr/repository for | Greg Hudson | 1997-09-14 |
| | | | | detailed change information. | ||
* | Changed KERBEROS to Z_HaveKerberos | Richard Basch | 1993-11-20 |
| | |||
* | Changed bzero/bcopy to memset/memcpy [ANSI] | Richard Basch | 1993-11-19 |
| | |||
* | Use _BZERO,_BCOPY,_BCMP macros in lieu of the functions. | Richard Basch | 1993-09-24 |
| | | | | | These are declared in <zephyr/zephyr_conf.h> to be either the BSD routine or the ANSI routines, depending on the system type. | ||
* | Don't initialize __Zephyr_realm if Kerberos is not in use. | Kenneth G Raeburn | 1991-03-21 |
| | |||
* | new names for new compile_et/libcom_err | John Kohl | 1989-05-30 |
| | |||
* | need to #include "krb_err.h" to make sure that | John Kohl | 1989-05-25 |
| | | | | new versions of the names are redefined. | ||
* | change for new kerberos names | John Kohl | 1989-03-23 |
| | |||
* | use #define'd name for the service | John Kohl | 1988-11-14 |
| | | | | when not KERBEROS, use a pre-defined realm | ||
* | lint fixes | John Kohl | 1988-06-23 |
| | |||
* | For John | Robert S. French | 1988-06-15 |
| | |||
* | All sorts of changes for ver 0.2 | Robert S. French | 1988-05-17 |
| | |||
* | Update for protocol 0.2 / cleanup / Kerberos fixes | Robert S. French | 1988-05-13 |
| | |||
* | Added RCSID | Robert S. French | 1987-07-29 |
| | |||
* | Cache the sender | Robert S. French | 1987-07-09 |
| | |||
* | linting | Robert S. French | 1987-07-01 |
| | |||
* | safety | Robert S. French | 1987-06-24 |
| | |||
* | Safety checkin | Robert S. French | 1987-06-20 |
| | |||
* | Back to zeph | Robert S. French | 1987-06-14 |
| | |||
* | ezef!!! | Robert S. French | 1987-06-13 |
| | |||
* | Changed name to zeph | Robert S. French | 1987-06-12 |
| | |||
* | Initial revision | Robert S. French | 1987-06-12 |