From 7563101f66634c77f0d6878473cc6e46a7e3ff59 Mon Sep 17 00:00:00 2001 From: Dieter Plaetinck Date: Sun, 26 Apr 2009 16:02:06 +0200 Subject: better documented how scripts should work + refactored sample implementations --- extra/download.sh | 3 +-- extra/history.sh | 3 +++ extra/insert_bookmark.sh | 4 +--- extra/load_url_from_bookmarks.sh | 2 +- extra/load_url_from_history.sh | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) mode change 100644 => 100755 extra/download.sh create mode 100755 extra/history.sh mode change 100644 => 100755 extra/insert_bookmark.sh mode change 100644 => 100755 extra/load_url_from_bookmarks.sh (limited to 'extra') diff --git a/extra/download.sh b/extra/download.sh old mode 100644 new mode 100755 index 90d0a9f..ff3d8db --- a/extra/download.sh +++ b/extra/download.sh @@ -1,3 +1,2 @@ #!/bin/bash -# $1 = url of file to download -wget $1 +wget $5 diff --git a/extra/history.sh b/extra/history.sh new file mode 100755 index 0000000..4047476 --- /dev/null +++ b/extra/history.sh @@ -0,0 +1,3 @@ +#!/bin/bash + +echo "$7 $5" >> /tmp/uzbl.history diff --git a/extra/insert_bookmark.sh b/extra/insert_bookmark.sh old mode 100644 new mode 100755 index 3df6086..083a4b4 --- a/extra/insert_bookmark.sh +++ b/extra/insert_bookmark.sh @@ -1,11 +1,9 @@ #!/bin/bash -# $1 should be the uri you want to bookmark file=bookmarks -[ -z "$1" ] && exit 1 which zenity &>/dev/null || exit 2 -entry=`zenity --entry --text="Add bookmark. add tags at the end, separated by commas" --entry-text="$1"` +entry=`zenity --entry --text="Add bookmark. add tags at the end, separated by commas" --entry-text="$5"` url=`awk '{print $1}' <<< $entry` # TODO: check if already exists, if so, and tags are different: ask if you want to replace tags echo "$entry" >> $file diff --git a/extra/load_url_from_bookmarks.sh b/extra/load_url_from_bookmarks.sh old mode 100644 new mode 100755 index dfbbf9a..52e14e2 --- a/extra/load_url_from_bookmarks.sh +++ b/extra/load_url_from_bookmarks.sh @@ -1,4 +1,4 @@ #!/bin/bash file=bookmarks goto=`awk '{print $1}' $history_file | dmenu` #NOTE: it's the job of the script that inserts bookmarks to make sure there are no dupes. -[ -n "$goto" ] && echo "uri $goto" > /tmp/uzbl-fifo-name-TODO +[ -n "$goto" ] && echo "uri $goto" > $4 diff --git a/extra/load_url_from_history.sh b/extra/load_url_from_history.sh index bcc2362..559e257 100755 --- a/extra/load_url_from_history.sh +++ b/extra/load_url_from_history.sh @@ -1,4 +1,4 @@ #!/bin/bash history_file=/tmp/uzbl.history goto=`awk '{print $3}' $history_file | sort | uniq | dmenu` -[ -n "$goto" ] && echo "uri $goto" > /tmp/uzbl-fifo-name-TODO +[ -n "$goto" ] && echo "uri $goto" > $4 -- cgit v1.2.3