From 620ead5cf60a446a2f7dc4e136d8cee895ea51df Mon Sep 17 00:00:00 2001 From: Brendan Taylor Date: Wed, 23 Nov 2011 19:53:56 -0700 Subject: don't use window.open in follow.js. it's slow, forces you to turn on javascript_windows = 1, and on some systems results in multiple new windows/tabs. --- examples/data/scripts/follow.js | 7 +++---- examples/data/scripts/follow.sh | 3 +++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/examples/data/scripts/follow.js b/examples/data/scripts/follow.js index 45ecfc6..88f80f2 100644 --- a/examples/data/scripts/follow.js +++ b/examples/data/scripts/follow.js @@ -288,11 +288,10 @@ uzbl.follow.elementSelected = function(el) { // we're opening a new window using the URL attached to this element var uri = el.src || el.href; if(uri.match(/javascript:/)) return; - window.open(uri); - return "XXXRESET_MODEXXX" + return "XXXNEW_WINDOWXXX " + uri; } else { - // we're just going to click the element - return this.clickElem(el); + // we're just going to click the element + return this.clickElem(el); } } diff --git a/examples/data/scripts/follow.sh b/examples/data/scripts/follow.sh index 01e92db..de126eb 100755 --- a/examples/data/scripts/follow.sh +++ b/examples/data/scripts/follow.sh @@ -13,6 +13,9 @@ case "$result" in # a link was selected, reset uzbl's input mode printf 'set mode=\nevent KEYCMD_CLEAR\n' > "$UZBL_FIFO" ;; + XXXNEW_WINDOWXXX*) + printf "set mode=\nevent KEYCMD_CLEAR\nevent NEW_WINDOW $@\n" > "$UZBL_FIFO" + ;; XXXRETURNED_URIXXX*) uriaction=$1 uri=${result#XXXRETURNED_URIXXX} -- cgit v1.2.3