From 40037223b33fcdf178509ba5ece4ba33425c4627 Mon Sep 17 00:00:00 2001 From: Andrew Selle Date: Sat, 8 Sep 2018 09:19:22 -0700 Subject: Automated rollback of commit 0065d3389a63a529469dc71e950c66da2ebdbc24 PiperOrigin-RevId: 212119629 --- third_party/flatbuffers/BUILD.bazel | 1 + third_party/flatbuffers/build_defs.bzl | 19 +++++++++++-------- 2 files changed, 12 insertions(+), 8 deletions(-) (limited to 'third_party') diff --git a/third_party/flatbuffers/BUILD.bazel b/third_party/flatbuffers/BUILD.bazel index 9d233a30d6..934c0d9650 100644 --- a/third_party/flatbuffers/BUILD.bazel +++ b/third_party/flatbuffers/BUILD.bazel @@ -142,6 +142,7 @@ filegroup( srcs = [ "include/flatbuffers/base.h", "include/flatbuffers/flatbuffers.h", + "include/flatbuffers/minireflect.h", "include/flatbuffers/stl_emulation.h", "include/flatbuffers/util.h", ], diff --git a/third_party/flatbuffers/build_defs.bzl b/third_party/flatbuffers/build_defs.bzl index 2f25156668..235b44f7cf 100644 --- a/third_party/flatbuffers/build_defs.bzl +++ b/third_party/flatbuffers/build_defs.bzl @@ -92,14 +92,17 @@ def flatbuffer_library_public( cmd = reflection_genrule_cmd, message = "Generating flatbuffer reflection binary for %s:" % (name), ) - native.Fileset( - name = reflection_name, - out = "%s_out" % reflection_name, - entries = [ - native.FilesetEntry(files = reflection_outs), - ], - visibility = reflection_visiblity, - ) + # TODO(b/114456773): Make bazel rules proper and supported by flatbuffer + # Have to comment this since FilesetEntry is not supported in bazel + # skylark. + # native.Fileset( + # name = reflection_name, + # out = "%s_out" % reflection_name, + # entries = [ + # native.FilesetEntry(files = reflection_outs), + # ], + # visibility = reflection_visiblity, + # ) def flatbuffer_cc_library( name, -- cgit v1.2.3