From c80f1493222720c2601c7d68f0ec0dd236ceb621 Mon Sep 17 00:00:00 2001 From: Sanjoy Das Date: Wed, 18 Jul 2018 15:23:40 -0700 Subject: Add some LOGging when we detect nodes in a cycle PiperOrigin-RevId: 205146924 --- tensorflow/core/graph/graph_constructor.cc | 8 ++++++++ tensorflow/tools/graph_transforms/transform_utils.cc | 13 ++++++++++--- 2 files changed, 18 insertions(+), 3 deletions(-) (limited to 'tensorflow') diff --git a/tensorflow/core/graph/graph_constructor.cc b/tensorflow/core/graph/graph_constructor.cc index add26f3b71..8c73f8f712 100644 --- a/tensorflow/core/graph/graph_constructor.cc +++ b/tensorflow/core/graph/graph_constructor.cc @@ -1042,6 +1042,14 @@ Status GraphConstructor::Convert() { } if (processed < node_defs_.size()) { + LOG(WARNING) << "IN " << __func__ << (node_defs_.size() - processed) + << " NODES IN A CYCLE"; + for (int64 i = 0; i < node_defs_.size(); i++) { + if (pending_count_[i] != 0) { + LOG(WARNING) << "PENDING: " << SummarizeNodeDef(*node_defs_[i]) + << "WITH PENDING COUNT = " << pending_count_[i]; + } + } return errors::InvalidArgument(node_defs_.size() - processed, " nodes in a cycle"); } diff --git a/tensorflow/tools/graph_transforms/transform_utils.cc b/tensorflow/tools/graph_transforms/transform_utils.cc index af17fd75bc..cb084e49b7 100644 --- a/tensorflow/tools/graph_transforms/transform_utils.cc +++ b/tensorflow/tools/graph_transforms/transform_utils.cc @@ -247,9 +247,16 @@ Status SortByExecutionOrder(const GraphDef& input_graph_def, } } - if (processed < input_graph_def.node_size()) { - return errors::InvalidArgument(input_graph_def.node_size() - processed, - " nodes in a cycle"); + if (processed < num_nodes) { + LOG(WARNING) << "IN " << __func__ << (num_nodes - processed) + << " NODES IN A CYCLE"; + for (int64 i = 0; i < num_nodes; i++) { + if (pending_count[i] != 0) { + LOG(WARNING) << "PENDING: " << SummarizeNodeDef(input_graph_def.node(i)) + << "WITH PENDING COUNT = " << pending_count[i]; + } + } + return errors::InvalidArgument(num_nodes - processed, " nodes in a cycle"); } return Status::OK(); } -- cgit v1.2.3