From 22c06a62b7dcc75f6f717cea63a947b21805afda Mon Sep 17 00:00:00 2001 From: Mark Heffernan Date: Mon, 25 Jun 2018 23:05:07 -0700 Subject: Rename HLO opcode kGenerateToken to kAfterAll. Long term I think we want to require kAfterAll to take at least one token as operand so it cannot generate a token out of thin air, so kGenerateToken is no longer an appropriate name. Instead, a primordial token would be supplied some how in the entry computation, perhaps as a parameter, and then threaded to any side-effecting ops. NFC. PiperOrigin-RevId: 202079040 --- tensorflow/compiler/xla/service/hlo_parser_test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tensorflow/compiler/xla/service/hlo_parser_test.cc') diff --git a/tensorflow/compiler/xla/service/hlo_parser_test.cc b/tensorflow/compiler/xla/service/hlo_parser_test.cc index 5ec9225a68..da1a34ae3c 100644 --- a/tensorflow/compiler/xla/service/hlo_parser_test.cc +++ b/tensorflow/compiler/xla/service/hlo_parser_test.cc @@ -795,7 +795,7 @@ ENTRY ReduceR3ToR2.v3 { R"(HloModule outfeed_module ENTRY InfeedToOutfeed { - token = token[] generate-token() + token = token[] after-all() infeed = ((u32[3]{0}, pred[]), token[]) infeed(token) infeed.data = (u32[3]{0}, pred[]) get-tuple-element(infeed), index=0 outfeed = token[] outfeed(infeed.data, token) @@ -1425,7 +1425,7 @@ TEST_F(HloParserTest, ParseConvolutionDimensionNumbers) { TEST_F(HloParserTest, NontupleInfeed) { const string original = R"(HloModule nontuple_infeed: ENTRY nontuple_infeed { - token = token[] generate-token() + token = token[] after-all() ROOT infeed = pred[] infeed(token) })"; ExpectHasSubstr(ParseHloString(original).status().error_message(), -- cgit v1.2.3