From ac3c7686b9103d2b599650c073f9ac9d474559e4 Mon Sep 17 00:00:00 2001 From: Peter Hawkins Date: Tue, 4 Apr 2017 06:26:06 -0800 Subject: [TF:XLA] Failures from ComputationBuilder::IsConstant() and ComputationBuilder::ComputeConstant() should not be persistent. The reason to note failures via first_error_ is so that most methods can defer failure reporting until Build() time. However this makes no sense for methods such as ComputeConstant() that return a Status already -- such methods can just return their errors directly without "polluting" other callers. Change: 152129004 --- tensorflow/compiler/xla/client/computation_builder.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tensorflow/compiler/xla/client/computation_builder.cc b/tensorflow/compiler/xla/client/computation_builder.cc index 88efd87d1c..22a7068146 100644 --- a/tensorflow/compiler/xla/client/computation_builder.cc +++ b/tensorflow/compiler/xla/client/computation_builder.cc @@ -1229,8 +1229,7 @@ StatusOr ComputationBuilder::IsConstant( VLOG(2) << "done with request"; if (!s.ok()) { - NoteError(s); - return first_error_; + return s; } return response.is_constant(); } @@ -1255,8 +1254,7 @@ StatusOr> ComputationBuilder::ComputeConstant( VLOG(2) << "done with request"; if (!s.ok()) { - NoteError(s); - return first_error_; + return s; } TF_RET_CHECK(response.output().handle() != 0); -- cgit v1.2.3