| Commit message (Collapse) | Author | Age |
|
|
|
| |
PiperOrigin-RevId: 215243030
|
|
|
|
| |
PiperOrigin-RevId: 213693027
|
|
|
|
| |
PiperOrigin-RevId: 212736286
|
|
|
|
| |
PiperOrigin-RevId: 211487989
|
|
|
|
|
|
|
|
|
|
| |
conversions.
That is, instances of sp.ToString() are replaced with string(sp).
This will allow tensorflow::StringPiece::ToString to be removed, which is necessary before it can be replaced with absl::string_view.
PiperOrigin-RevId: 210394878
|
|
|
|
| |
PiperOrigin-RevId: 209679086
|
|
|
|
| |
PiperOrigin-RevId: 208104156
|
|
|
|
| |
PiperOrigin-RevId: 207152562
|
|
|
|
|
|
| |
Google Cloud Engine zone tensorflow is running in.
PiperOrigin-RevId: 206817614
|
|
|
|
| |
PiperOrigin-RevId: 206812942
|
|
|
|
| |
PiperOrigin-RevId: 203791186
|
|
|
|
|
|
|
|
| |
The GCS caching attributes can be set via several environment variables, and in some
cases interact with each other. This log statement helps developers verify the final
effect of these settings on the cache in use.
PiperOrigin-RevId: 203181905
|
|
|
|
| |
PiperOrigin-RevId: 202585094
|
|
|
|
| |
PiperOrigin-RevId: 200651761
|
|
|
|
| |
PiperOrigin-RevId: 198658074
|
|
|
|
|
|
|
| |
functions. That should be a programmatic error and we have full control of
internal functions, so it is OK to crash if error happens.
PiperOrigin-RevId: 198651749
|
|
|
|
|
|
| |
assumption that if a real GCS object has file name ending with "/", it is always a directory mark rather than an object carrying actual contents.
PiperOrigin-RevId: 198640604
|
|
|
|
| |
PiperOrigin-RevId: 198624285
|
|
|
|
| |
PiperOrigin-RevId: 198582954
|
|
|
|
|
|
|
| |
Revert #18413. Too many internal test failures due to the name scope change caused by this change.
Revert #18192. Cannot use re2::StringPiece internally. Need alternative for set call. Will pull and clean this up in a separate change.
PiperOrigin-RevId: 197991247
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a few issues with CurlHttpRequest (and correspondingly GcsFileSystem):
- Return status FAILED_PRECONDITION (i.e. "your buffer was too small") when CurlHttpRequest has a direct response buffer and the response is too large for the buffer, instead of UNAVAILABLE, since if the server resource is actually a fixed size, retrying automatically won't help at all. Also, include the message about the too-small buffer size in the returned Status as opposed to logging it, making it more obvious that it's treated as a message about a hard failure versus just a warning.
- If the response was actually a 416 Range Not Satisfied response, fully pretend that the response had no body even if we got one (I'm looking at you GCS... it returns a 177-byte error message). This means:
- Ignore a "buffer too small" error produced by the logic described above
- Don't report the length of that body in GetResultBufferDirectBytesTransferred(), which looks to the client like data corruption, just report 0 (this fix makes it match the behavior of the non-direct-buffer response handling)
I also tweaked the error messages, e.g. the message that includes an HTTP response code shouldn't report the CURLcode since it will always be CURLE_OK at that point.
PiperOrigin-RevId: 197805003
|
|
|
|
|
|
| |
the stat cache.
PiperOrigin-RevId: 197637482
|
|
|
|
|
|
|
|
| |
checkpoint hack. Enable the stat cache by default, as the block cache has
already been enabled by default. Set the default stat cache max_age to 5s,
which is the same in the Cloud TPU server.
PiperOrigin-RevId: 197175258
|
|
|
|
|
|
|
|
|
|
| |
* unused using-declarations
* redundant string conversions
* C-style casts
* redundant get() call on smart pointer
* the 'empty' method should be used to check for emptiness instead of 'size'
PiperOrigin-RevId: 196585984
|
|
|
|
|
|
| |
in gcs_file_system.h.
PiperOrigin-RevId: 196184962
|
|
|
|
| |
PiperOrigin-RevId: 195337886
|
|
|
|
|
|
| |
name in retrying_file_system.h.
PiperOrigin-RevId: 195297877
|
|
|
|
|
|
|
|
|
|
| |
conversions.
That is, instances of sp.ToString() are replaced with std::string(sp).
This will allow tensorflow::StringPiece::ToString to be removed, which is necessary before it can be replaced with absl::string_view.
PiperOrigin-RevId: 195162126
|
|
|
|
| |
PiperOrigin-RevId: 194614877
|
|
|
|
|
|
| |
overwritten or removed, the stat will become outdated.
PiperOrigin-RevId: 194148397
|
|
|
|
|
|
| |
the requested read size is larger than the block size.
PiperOrigin-RevId: 193422905
|
|
|
|
|
|
| |
See:
https://source.cloud.google.com/results/invocations/31632a30-3728-4635-a456-f89b9e8b9dfe/log
PiperOrigin-RevId: 192544848
|
|
|
|
|
|
| |
updated checkpoints from the contents.
PiperOrigin-RevId: 192517819
|
|
|
|
|
|
|
|
| |
tensorflow::str_util equivalents.
This will allow the deprecated methods to be removed.
PiperOrigin-RevId: 191627087
|
|
|
|
| |
PiperOrigin-RevId: 190878279
|
|
|
|
|
|
|
|
|
| |
END_PUBLIC
BEGIN_PUBLIC
Automated g4 rollback of changelist 189900977
PiperOrigin-RevId: 190169076
|
|
|
|
|
|
| |
obtain auth token from GCE. Before this change, if a process is not running under GCE, the token request to http://metadata server would time out after 3+ minutes of retry. After this change, the check is bypassed, and we return an empty token to the caller. At that point, the caller's request to read/write a file in GCS would either succeed or fail depending on whether the bucket is publicly accessible.
PiperOrigin-RevId: 189900977
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the
cases that are changed by this CL, a failure indicates a software bug, not a runtime
condition that should be handled and continued beyond. Continuing to execute only promotes silently-ignored bugs.
I also removed the useless call which attempts to set the HTTP protocol to HTTP/2, because this call always fails. I opened b/74351157 to track the possible feature of adding support for HTTP/2.
Also simplified the code around constructing the error string when returning actual Status objects, by moving code into a lambda.
PiperOrigin-RevId: 188363531
|
|
|
|
|
|
|
|
|
| |
GCS returns 400, invalid argument because it thinks the body is not empty. cURL, by default, sets "Transfer-Encoding: Chunked", which causes the server to ignore "Content-Length: 0":
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Transfer-Encoding
The server considers the HTTP request incomplete and may non-deterministically fail.
PiperOrigin-RevId: 188235030
|
|
|
|
| |
PiperOrigin-RevId: 188187793
|
|
|
|
|
|
| |
above.
PiperOrigin-RevId: 188110480
|
|
|
|
| |
PiperOrigin-RevId: 187895652
|
|
|
|
| |
PiperOrigin-RevId: 187652953
|
|
|
|
| |
PiperOrigin-RevId: 187647263
|
|
|
|
|
|
|
|
| |
- The main semantics change is that we return immediately if curl_easy_perform doesn't return CURLE_OK. The CURL documentation indicates that it's not ok to fetch info if the curl call failed:
https://curl.haxx.se/libcurl/c/curl_easy_getinfo.html
- LOG errors where we can't return a status. Otherwise return with a status immediately.
PiperOrigin-RevId: 187562481
|
|
|
|
| |
PiperOrigin-RevId: 187556563
|
|
|
|
|
|
|
|
|
|
|
|
| |
permit 308 when getting the status of an upload.
This matches the behavior of the official library:
https://github.com/google/apitools/blob/master/apitools/base/py/transfer.py#L925
And the general description here:
https://cloud.google.com/storage/docs/json_api/v1/how-tos/resumable-upload
PiperOrigin-RevId: 187400843
|
|
|
|
| |
PiperOrigin-RevId: 184220615
|
|
|
|
|
|
|
| |
Previously, 1 token was approximately 256 bytes. This is slightly less
intuitive than 1 kb.
PiperOrigin-RevId: 184212503
|
|
|
|
| |
PiperOrigin-RevId: 183869325
|