aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
| * | | | | | | | | | CLN: revise codesGravatar Yan Facai (颜发才)2018-08-12
| | | | | | | | | | |
* | | | | | | | | | | compat: Update forward compatibility horizon to 2018-08-12Gravatar A. Unique TensorFlower2018-08-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208379916
* | | | | | | | | | | Automated rollback of commit af25771f4418db658ad4b40a635ea5f2a4c2bbe6. ↵Gravatar Anna R2018-08-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert #21097. PiperOrigin-RevId: 208378106
* | | | | | | | | | | Merge pull request #21480 from wdirons:run_test_files_for_ppc64leGravatar TensorFlower Gardener2018-08-11
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208366190
* | | | | | | | | | | | Go: Update generated wrapper functions for TensorFlow ops.Gravatar A. Unique TensorFlower2018-08-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208356344
* | | | | | | | | | | | Update ops-related pbtxt files.Gravatar A. Unique TensorFlower2018-08-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208355476
* | | | | | | | | | | | Merge pull request #19105 from facaiy:ENH/unsafe_divGravatar TensorFlower Gardener2018-08-11
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208352779
* | | | | | | | | | | | | Use the full product name: Google Cloud BigtableGravatar Misha Brukman2018-08-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208352025
* | | | | | | | | | | | | Merge pull request #21097 from yongtang:07242018-re2Gravatar TensorFlower Gardener2018-08-11
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208348096
* \ \ \ \ \ \ \ \ \ \ \ \ \ Merge pull request #21519 from yongtang:08052018-squeeze_dimsGravatar TensorFlower Gardener2018-08-11
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208345703
* \ \ \ \ \ \ \ \ \ \ \ \ \ \ Merge pull request #21541 from markdryan:avx512_fix_nn_testGravatar TensorFlower Gardener2018-08-11
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208345397
* | | | | | | | | | | | | | | | Guard zeros by ZerosLikeOutsideLoop by pivot instead of switch.Gravatar Jacques Pienaar2018-08-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The constant should be dependent on the then/else edge of the switch instead of the switch. PiperOrigin-RevId: 208342636
* | | | | | | | | | | | | | | | compat: Update forward compatibility horizon to 2018-08-11Gravatar A. Unique TensorFlower2018-08-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208323893
* | | | | | | | | | | | | | | | Merge pull request #20039 from jrbtaylor:graph_editor_fixGravatar TensorFlower Gardener2018-08-11
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208317317
* | | | | | | | | | | | | | | | | Rename MKL-related feature macros.Gravatar A. Unique TensorFlower2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The existing feature macros are named INTEL_MKL to indicate that any flavor of MKL is available, INTEL_MKL_ML to indicate that *only* MKL-ML is available (i.e. MKL-DNN is not), and DO_NOT_USE_ML to indicate that *only* MKL-DNN is available (i.e. MKL-ML is not). This change renames INTEL_MKL_ML to INTEL_MKL_ML_ONLY and DO_NOT_USE_ML to INTEL_MKL_DNN_ONLY. The meanings of the macros have not changed. This change also adds a few sanity checks to mkl_util.h that ensures that the combination of INTEL_MKL, INTEL_MKL_ML_ONLY, and INTEL_MKL_DNN_ONLY is logically consistent: the *_ONLY macros may not both be defined, and if either of them is defined, bare INTEL_MKL must also be defined. PiperOrigin-RevId: 208313735
* | | | | | | | | | | | | | | | | Add validation support for tuples and dict values to be returned by the DatasetGravatar Anjali Sridhar2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | iterator when using DistributionStrategy in Keras. PiperOrigin-RevId: 208312889
* | | | | | | | | | | | | | | | | Merge pull request #21535 from CrazyJiawei:patch-1Gravatar TensorFlower Gardener2018-08-10
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208311588
* | | | | | | | | | | | | | | | | | Create new MultiStepStopHook for running mutiple steps per run when using ↵Gravatar Sourabh Bajaj2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TPU Distribution Strategy with Estimator. PiperOrigin-RevId: 208310915
* | | | | | | | | | | | | | | | | | Remove XlaCompiledCpuFunction::args()Gravatar Sanjoy Das2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lets us remove XlaCompiledCpuFunction::args_ and some awkwardness from XlaCompiledCpuFunction::Run. PiperOrigin-RevId: 208309249
| | | | | | | * | | | | | | | | | | Updates for code review commentsGravatar William D. Irons2018-08-10
| | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | Merge pull request #20066 from Intel-tensorflow:nhasabni/mkldnn-transposendGravatar TensorFlower Gardener2018-08-10
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208303080
* \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ Merge pull request #18223 from yongtang:10622-RecordInput-docGravatar TensorFlower Gardener2018-08-10
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208301074
* \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ Merge pull request #20479 from naurril:bug-fixGravatar TensorFlower Gardener2018-08-10
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208300149
* | | | | | | | | | | | | | | | | | | | | TFTS: de-flake ar_model_testGravatar Allen Lavoie2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208297005
* | | | | | | | | | | | | | | | | | | | | Add an Android target for whole_file_reader ops.Gravatar Shashi Shekhar2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208294588
* | | | | | | | | | | | | | | | | | | | | Internal change.Gravatar Anna R2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208294163
* | | | | | | | | | | | | | | | | | | | | Internal change.Gravatar Anna R2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208293192
* | | | | | | | | | | | | | | | | | | | | Merge pull request #21536 from facaiy:BUG/raw_receiver_fn_with_unknown_shapeGravatar TensorFlower Gardener2018-08-10
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208292722
* \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ Merge pull request #20030 from yongtang:06052018-AdjustContrastv2-shapeGravatar TensorFlower Gardener2018-08-10
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208292704
* | | | | | | | | | | | | | | | | | | | | | | Speeding up MultiDeviceIterator by more efficient locking. We create a ↵Gravatar Rohan Jain2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | background thread that tries to keep a host side buffer for each device full. When a GetNext request comes in, we return from the buffer if available or else we schedule a callback to be called when the background thread eventually fetches an element for it. PiperOrigin-RevId: 208292329
* | | | | | | | | | | | | | | | | | | | | | | Update minimize loss test to use new API run_steps_on_dataset. Update Step ↵Gravatar Priya Gupta2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | API to also use the new API. PiperOrigin-RevId: 208291393
* | | | | | | | | | | | | | | | | | | | | | | delete debug printGravatar Mark Daoust2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208290761
* | | | | | | | | | | | | | | | | | | | | | | Propagate file-related error messages to the screen.Gravatar Tim Shen2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208290419
| | | | | | | | | | | | | | | | | | | * | | | [Intel MKL] Adding keras pip packages to container builds.Gravatar Clayne Robison2018-08-10
| | | | | | | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | | | | | | Use shared memory for NNAPI input and output.Gravatar A. Unique TensorFlower2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208283489
* | | | | | | | | | | | | | | | | | | | | | | Internal change.Gravatar A. Unique TensorFlower2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208283367
* | | | | | | | | | | | | | | | | | | | | | | Introduce and use a BufferInfo class.Gravatar Sanjoy Das2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The BufferInfo represents information about buffer assignment in XlaCompiledCpuFunction. Arg sizes and temp sizes are now derived from BufferInfo instead of being discrete sources of information. Also made StaticData() private, tfcompile clients should not need to access it directly. PiperOrigin-RevId: 208283305
* | | | | | | | | | | | | | | | | | | | | | | [tf.data] Optimization checkpointing improvements.Gravatar Jiri Simsa2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL: - changes the `OptimizeDataset` checkpointing logic to checkpoint the optimized dataset (as opposed to the original dataset + the optimizations, re-running optimization every time a checkpoint is restored) - replaces `OpKernelContext` with newly introduced `SerializationContext` in the signature of `AsGraphDefInternal` to reduce the scope of the context and also simplify the logic for overriding the `FunctionLibraryDefinition` when optimizations take place PiperOrigin-RevId: 208282562
* | | | | | | | | | | | | | | | | | | | | | | Merge pull request #21521 from Androbin:selectGravatar TensorFlower Gardener2018-08-10
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208281031
* | | | | | | | | | | | | | | | | | | | | | | | Add support for the new metrics in Keras.Gravatar Pavithra Vijay2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add support for stateful metrics, weighted metrics, metric masking in eager mode. - Updated masking logic for loss and metrics. (similar to weights in cl/207311700) - Add weighted_metrics to save and load model. - Add Categorical accuracy metric. - Migrating #21071 PiperOrigin-RevId: 208278596
* | | | | | | | | | | | | | | | | | | | | | | | Merge pull request #21191 from mattdodge:patch-1Gravatar TensorFlower Gardener2018-08-10
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208278273
* | | | | | | | | | | | | | | | | | | | | | | | | Correct a mistake in the lgamma documentationGravatar David Majnemer2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The lower regularized incomplete Gamma function as defined in the documentation is P(a, x) but the heading for the function is Q(a, x). This is incorrect, Q(a, x) refers to the upper regularized incomplete Gamma function. PiperOrigin-RevId: 208277703
* | | | | | | | | | | | | | | | | | | | | | | | | Add tests for remote eager execution.Gravatar Akshay Modi2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208277185
* | | | | | | | | | | | | | | | | | | | | | | | | Lift the restriction in the docs that while loops can't be nested.Gravatar Dimitris Vardoulakis2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208276989
* | | | | | | | | | | | | | | | | | | | | | | | | Add two counters in Costs Struct for number of ops processed/predicted in ↵Gravatar Peter Ma2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | total, and number of ops predicted with unknown shapes PiperOrigin-RevId: 208274158
* | | | | | | | | | | | | | | | | | | | | | | | | Incremental update to the TFLite C APIGravatar Jared Duke2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208273960
* | | | | | | | | | | | | | | | | | | | | | | | | Add links to the C-api, and bazel-subproject instructions.Gravatar Mark Daoust2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208273008
* | | | | | | | | | | | | | | | | | | | | | | | | [tf.data] Minor API refactoring.Gravatar Jiri Simsa2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Renaming `AddParentDataset`, `SaveParent`, and `RestoreParent` to `AddInputDataset`, `SaveInput`, and `RestoreInput`. PiperOrigin-RevId: 208272695
* | | | | | | | | | | | | | | | | | | | | | | | | Make FunctionLibraryDefinition thread-safe.Gravatar Akshay Agrawal2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The eager runtime mutates the FunctionLibraryRuntime's FunctionLibraryDefinition, which is shared across threads; at the same time, OpKernels might read the FunctionLibraryDefinition. This is not thread-safe unless FunctionLibraryDefinition is thread-safe. This change makes FunctionLibraryDefinition, which is basically a map from function names to FunctionDefs, thread-safe. This is almost entirely accomplished by guarding the map with a mutex. There is however one complication: Find and RemoveFunction cannot be made thread-safe in a straightforward way (Find returns a raw pointer to a FunctionDef while Remove can delete the corresponding FunctionDef). In light of the fact that clients only ever call RemoveFunction when they in fact want to replace an existing function with a new one, we make the following modifications to FunctionLibraryDefinition's API: 1. A Contains method is added to check for the existence of a function. 2. A ReplaceFunction method is added. 3. RemoveFunction and RemoveGradient are made private. We also update clients of the FunctionLibraryDefinition to use Contains & ReplaceFunction instead of Find and RemoveFunction. PiperOrigin-RevId: 208271076
* | | | | | | | | | | | | | | | | | | | | | | | | Automated rollback of commit 9eb310c3f651d69b9a8eea016f6397049c5a0a31Gravatar Anna R2018-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PiperOrigin-RevId: 208270711
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-03 15:17:29 +0000