/* * Copyright 2013 Google Inc. * * Use of this source code is governed by a BSD-style license that can be * found in the LICENSE file. */ #include #include "SkCanvas.h" #include "SkData.h" #include "SkDevice.h" #include "SkImage_Base.h" #include "SkPath.h" #include "SkRRect.h" #include "SkSurface.h" #include "SkUtils.h" #include "Test.h" #if SK_SUPPORT_GPU #include "GrContext.h" #include "GrDrawContext.h" #include "GrGpu.h" #include "GrResourceProvider.h" #endif #include static void release_direct_surface_storage(void* pixels, void* context) { SkASSERT(pixels == context); sk_free(pixels); } static sk_sp create_surface(SkAlphaType at = kPremul_SkAlphaType, SkImageInfo* requestedInfo = nullptr) { const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); if (requestedInfo) { *requestedInfo = info; } return SkSurface::MakeRaster(info); } static sk_sp create_direct_surface(SkAlphaType at = kPremul_SkAlphaType, SkImageInfo* requestedInfo = nullptr) { const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); if (requestedInfo) { *requestedInfo = info; } const size_t rowBytes = info.minRowBytes(); void* storage = sk_malloc_throw(info.getSafeSize(rowBytes)); return SkSurface::MakeRasterDirectReleaseProc(info, storage, rowBytes, release_direct_surface_storage, storage); } #if SK_SUPPORT_GPU static sk_sp create_gpu_surface(GrContext* context, SkAlphaType at = kPremul_SkAlphaType, SkImageInfo* requestedInfo = nullptr) { const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); if (requestedInfo) { *requestedInfo = info; } return SkSurface::MakeRenderTarget(context, SkBudgeted::kNo, info, 0, nullptr); } static sk_sp create_gpu_scratch_surface(GrContext* context, SkAlphaType at = kPremul_SkAlphaType, SkImageInfo* requestedInfo = nullptr) { const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at); if (requestedInfo) { *requestedInfo = info; } return SkSurface::MakeRenderTarget(context, SkBudgeted::kYes, info, 0, nullptr); } #endif DEF_TEST(SurfaceEmpty, reporter) { const SkImageInfo info = SkImageInfo::Make(0, 0, kN32_SkColorType, kPremul_SkAlphaType); REPORTER_ASSERT(reporter, nullptr == SkSurface::MakeRaster(info)); REPORTER_ASSERT(reporter, nullptr == SkSurface::MakeRasterDirect(info, nullptr, 0)); } #if SK_SUPPORT_GPU DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceEmpty_Gpu, reporter, ctxInfo) { const SkImageInfo info = SkImageInfo::Make(0, 0, kN32_SkColorType, kPremul_SkAlphaType); REPORTER_ASSERT(reporter, nullptr == SkSurface::MakeRenderTarget(ctxInfo.grContext(), SkBudgeted::kNo, info, 0, nullptr)); } #endif static void test_canvas_peek(skiatest::Reporter* reporter, sk_sp& surface, const SkImageInfo& requestInfo, bool expectPeekSuccess) { const SkColor color = SK_ColorRED; const SkPMColor pmcolor = SkPreMultiplyColor(color); surface->getCanvas()->clear(color); SkPixmap pmap; bool success = surface->getCanvas()->peekPixels(&pmap); REPORTER_ASSERT(reporter, expectPeekSuccess == success); SkPixmap pmap2; const void* addr2 = surface->peekPixels(&pmap2) ? pmap2.addr() : nullptr; if (success) { REPORTER_ASSERT(reporter, requestInfo == pmap.info()); REPORTER_ASSERT(reporter, requestInfo.minRowBytes() <= pmap.rowBytes()); REPORTER_ASSERT(reporter, pmcolor == *pmap.addr32()); REPORTER_ASSERT(reporter, pmap.addr() == pmap2.addr()); REPORTER_ASSERT(reporter, pmap.info() == pmap2.info()); REPORTER_ASSERT(reporter, pmap.rowBytes() == pmap2.rowBytes()); } else { REPORTER_ASSERT(reporter, nullptr == addr2); } } DEF_TEST(SurfaceCanvasPeek, reporter) { for (auto& surface_func : { &create_surface, &create_direct_surface }) { SkImageInfo requestInfo; auto surface(surface_func(kPremul_SkAlphaType, &requestInfo)); test_canvas_peek(reporter, surface, requestInfo, true); } } #if SK_SUPPORT_GPU DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceCanvasPeek_Gpu, reporter, ctxInfo) { for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { SkImageInfo requestInfo; auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, &requestInfo)); test_canvas_peek(reporter, surface, requestInfo, false); } } #endif // For compatibility with clients that still call accessBitmap(), we need to ensure that we bump // the bitmap's genID when we draw to it, else they won't know it has new values. When they are // exclusively using surface/image, and we can hide accessBitmap from device, we can remove this // test. void test_access_pixels(skiatest::Reporter* reporter, const sk_sp& surface) { SkCanvas* canvas = surface->getCanvas(); canvas->clear(0); SkBaseDevice* device = canvas->getDevice_just_for_deprecated_compatibility_testing(); SkBitmap bm = device->accessBitmap(false); uint32_t genID0 = bm.getGenerationID(); // Now we draw something, which needs to "dirty" the genID (sorta like copy-on-write) canvas->drawColor(SK_ColorBLUE); // Now check that we get a different genID uint32_t genID1 = bm.getGenerationID(); REPORTER_ASSERT(reporter, genID0 != genID1); } DEF_TEST(SurfaceAccessPixels, reporter) { for (auto& surface_func : { &create_surface, &create_direct_surface }) { auto surface(surface_func(kPremul_SkAlphaType, nullptr)); test_access_pixels(reporter, surface); } } #if SK_SUPPORT_GPU DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceAccessPixels_Gpu, reporter, ctxInfo) { for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr)); test_access_pixels(reporter, surface); } } #endif static void test_snapshot_alphatype(skiatest::Reporter* reporter, const sk_sp& surface, bool expectOpaque) { REPORTER_ASSERT(reporter, surface); if (surface) { sk_sp image(surface->makeImageSnapshot()); REPORTER_ASSERT(reporter, image); if (image) { REPORTER_ASSERT(reporter, image->isOpaque() == SkToBool(expectOpaque)); } } } DEF_TEST(SurfaceSnapshotAlphaType, reporter) { for (auto& surface_func : { &create_surface, &create_direct_surface }) { for (auto& isOpaque : { true, false }) { SkAlphaType alphaType = isOpaque ? kOpaque_SkAlphaType : kPremul_SkAlphaType; auto surface(surface_func(alphaType, nullptr)); test_snapshot_alphatype(reporter, surface, isOpaque); } } } #if SK_SUPPORT_GPU DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceSnapshotAlphaType_Gpu, reporter, ctxInfo) { for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { for (auto& isOpaque : { true, false }) { SkAlphaType alphaType = isOpaque ? kOpaque_SkAlphaType : kPremul_SkAlphaType; auto surface(surface_func(ctxInfo.grContext(), alphaType, nullptr)); test_snapshot_alphatype(reporter, surface, isOpaque); } } } #endif static GrBackendObject get_surface_backend_texture_handle( SkSurface* s, SkSurface::BackendHandleAccess a) { return s->getTextureHandle(a); } static GrBackendObject get_surface_backend_render_target_handle( SkSurface* s, SkSurface::BackendHandleAccess a) { GrBackendObject result; if (!s->getRenderTargetHandle(&result, a)) { return 0; } return result; } static void test_backend_handle_access_copy_on_write( skiatest::Reporter* reporter, SkSurface* surface, SkSurface::BackendHandleAccess mode, GrBackendObject (*func)(SkSurface*, SkSurface::BackendHandleAccess)) { GrBackendObject obj1 = func(surface, mode); sk_sp snap1(surface->makeImageSnapshot()); GrBackendObject obj2 = func(surface, mode); sk_sp snap2(surface->makeImageSnapshot()); // If the access mode triggers CoW, then the backend objects should reflect it. REPORTER_ASSERT(reporter, (obj1 == obj2) == (snap1 == snap2)); } DEF_TEST(SurfaceBackendHandleAccessCopyOnWrite, reporter) { const SkSurface::BackendHandleAccess accessModes[] = { SkSurface::kFlushRead_BackendHandleAccess, SkSurface::kFlushWrite_BackendHandleAccess, SkSurface::kDiscardWrite_BackendHandleAccess, }; for (auto& handle_access_func : { &get_surface_backend_texture_handle, &get_surface_backend_render_target_handle }) { for (auto& accessMode : accessModes) { auto surface(create_surface()); test_backend_handle_access_copy_on_write(reporter, surface.get(), accessMode, handle_access_func); } } } #if SK_SUPPORT_GPU DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBackendHandleAccessCopyOnWrite_Gpu, reporter, ctxInfo) { const SkSurface::BackendHandleAccess accessModes[] = { SkSurface::kFlushRead_BackendHandleAccess, SkSurface::kFlushWrite_BackendHandleAccess, SkSurface::kDiscardWrite_BackendHandleAccess, }; for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { for (auto& handle_access_func : { &get_surface_backend_texture_handle, &get_surface_backend_render_target_handle }) { for (auto& accessMode : accessModes) { auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr)); test_backend_handle_access_copy_on_write(reporter, surface.get(), accessMode, handle_access_func); } } } } #endif static bool same_image(SkImage* a, SkImage* b, std::function getImageBackingStore) { return getImageBackingStore(a) == getImageBackingStore(b); } static bool same_image_surf(SkImage* a, SkSurface* b, std::function getImageBackingStore, std::function getSurfaceBackingStore) { return getImageBackingStore(a) == getSurfaceBackingStore(b); } static void test_unique_image_snap(skiatest::Reporter* reporter, SkSurface* surface, bool surfaceIsDirect, std::function imageBackingStore, std::function surfaceBackingStore) { std::function ibs = imageBackingStore; std::function sbs = surfaceBackingStore; static const SkBudgeted kB = SkBudgeted::kNo; { sk_sp image(surface->makeImageSnapshot(kB, SkSurface::kYes_ForceUnique)); REPORTER_ASSERT(reporter, !same_image_surf(image.get(), surface, ibs, sbs)); REPORTER_ASSERT(reporter, image->unique()); } { sk_sp image1(surface->makeImageSnapshot(kB, SkSurface::kYes_ForceUnique)); REPORTER_ASSERT(reporter, !same_image_surf(image1.get(), surface, ibs, sbs)); REPORTER_ASSERT(reporter, image1->unique()); sk_sp image2(surface->makeImageSnapshot(kB, SkSurface::kYes_ForceUnique)); REPORTER_ASSERT(reporter, !same_image_surf(image2.get(), surface, ibs, sbs)); REPORTER_ASSERT(reporter, !same_image(image1.get(), image2.get(), ibs)); REPORTER_ASSERT(reporter, image2->unique()); } { sk_sp image1(surface->makeImageSnapshot(kB, SkSurface::kNo_ForceUnique)); sk_sp image2(surface->makeImageSnapshot(kB, SkSurface::kYes_ForceUnique)); sk_sp image3(surface->makeImageSnapshot(kB, SkSurface::kNo_ForceUnique)); sk_sp image4(surface->makeImageSnapshot(kB, SkSurface::kYes_ForceUnique)); // Image 1 and 3 ought to be the same (or we're missing an optimization). REPORTER_ASSERT(reporter, same_image(image1.get(), image3.get(), ibs)); // If the surface is not direct then images 1 and 3 should alias the surface's // store. REPORTER_ASSERT(reporter, !surfaceIsDirect == same_image_surf(image1.get(), surface, ibs, sbs)); // Image 2 should not be shared with any other image. REPORTER_ASSERT(reporter, !same_image(image1.get(), image2.get(), ibs) && !same_image(image3.get(), image2.get(), ibs) && !same_image(image4.get(), image2.get(), ibs)); REPORTER_ASSERT(reporter, image2->unique()); REPORTER_ASSERT(reporter, !same_image_surf(image2.get(), surface, ibs, sbs)); // Image 4 should not be shared with any other image. REPORTER_ASSERT(reporter, !same_image(image1.get(), image4.get(), ibs) && !same_image(image3.get(), image4.get(), ibs)); REPORTER_ASSERT(reporter, !same_image_surf(image4.get(), surface, ibs, sbs)); REPORTER_ASSERT(reporter, image4->unique()); } } DEF_TEST(UniqueImageSnapshot, reporter) { auto getImageBackingStore = [reporter](SkImage* image) { SkPixmap pm; bool success = image->peekPixels(&pm); REPORTER_ASSERT(reporter, success); return reinterpret_cast(pm.addr()); }; auto getSufaceBackingStore = [reporter](SkSurface* surface) { SkPixmap pmap; const void* pixels = surface->getCanvas()->peekPixels(&pmap) ? pmap.addr() : nullptr; REPORTER_ASSERT(reporter, pixels); return reinterpret_cast(pixels); }; auto surface(create_surface()); test_unique_image_snap(reporter, surface.get(), false, getImageBackingStore, getSufaceBackingStore); surface = create_direct_surface(); test_unique_image_snap(reporter, surface.get(), true, getImageBackingStore, getSufaceBackingStore); } #if SK_SUPPORT_GPU DEF_GPUTEST_FOR_RENDERING_CONTEXTS(UniqueImageSnapshot_Gpu, reporter, ctxInfo) { GrContext* context = ctxInfo.grContext(); for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { auto surface(surface_func(context, kOpaque_SkAlphaType, nullptr)); auto imageBackingStore = [reporter](SkImage* image) { GrTexture* texture = as_IB(image)->peekTexture(); if (!texture) { ERRORF(reporter, "Not texture backed."); return static_cast(0); } return static_cast(texture->getUniqueID()); }; auto surfaceBackingStore = [reporter](SkSurface* surface) { GrDrawContext* dc = surface->getCanvas()->internal_private_accessTopLayerDrawContext(); GrRenderTarget* rt = dc->accessRenderTarget(); if (!rt) { ERRORF(reporter, "Not render target backed."); return static_cast(0); } return static_cast(rt->getUniqueID()); }; test_unique_image_snap(reporter, surface.get(), false, imageBackingStore, surfaceBackingStore); // Test again with a "direct" render target; GrBackendObject textureObject = context->getGpu()->createTestingOnlyBackendTexture(nullptr, 10, 10, kRGBA_8888_GrPixelConfig, true); GrBackendTextureDesc desc; desc.fConfig = kRGBA_8888_GrPixelConfig; desc.fWidth = 10; desc.fHeight = 10; desc.fFlags = kRenderTarget_GrBackendTextureFlag; desc.fTextureHandle = textureObject; GrTexture* texture = context->textureProvider()->wrapBackendTexture(desc); { auto surface(SkSurface::MakeRenderTargetDirect(texture->asRenderTarget())); test_unique_image_snap(reporter, surface.get(), true, imageBackingStore, surfaceBackingStore); } texture->unref(); context->getGpu()->deleteTestingOnlyBackendTexture(textureObject); } } #endif #if SK_SUPPORT_GPU // May we (soon) eliminate the need to keep testing this, by hiding the bloody device! static uint32_t get_legacy_gen_id(SkSurface* surface) { SkBaseDevice* device = surface->getCanvas()->getDevice_just_for_deprecated_compatibility_testing(); return device->accessBitmap(false).getGenerationID(); } /* * Test legacy behavor of bumping the surface's device's bitmap's genID when we access its * texture handle for writing. * * Note: this needs to be tested separately from checking makeImageSnapshot, as calling that * can also incidentally bump the genID (when a new backing surface is created). */ static void test_backend_handle_gen_id( skiatest::Reporter* reporter, SkSurface* surface, GrBackendObject (*func)(SkSurface*, SkSurface::BackendHandleAccess)) { const uint32_t gen0 = get_legacy_gen_id(surface); func(surface, SkSurface::kFlushRead_BackendHandleAccess); const uint32_t gen1 = get_legacy_gen_id(surface); REPORTER_ASSERT(reporter, gen0 == gen1); func(surface, SkSurface::kFlushWrite_BackendHandleAccess); const uint32_t gen2 = get_legacy_gen_id(surface); REPORTER_ASSERT(reporter, gen0 != gen2); func(surface, SkSurface::kDiscardWrite_BackendHandleAccess); const uint32_t gen3 = get_legacy_gen_id(surface); REPORTER_ASSERT(reporter, gen0 != gen3); REPORTER_ASSERT(reporter, gen2 != gen3); } static void test_backend_handle_unique_id( skiatest::Reporter* reporter, SkSurface* surface, GrBackendObject (*func)(SkSurface*, SkSurface::BackendHandleAccess)) { sk_sp image0(surface->makeImageSnapshot()); GrBackendObject obj = func(surface, SkSurface::kFlushRead_BackendHandleAccess); REPORTER_ASSERT(reporter, obj != 0); sk_sp image1(surface->makeImageSnapshot()); // just read access should not affect the snapshot REPORTER_ASSERT(reporter, image0->uniqueID() == image1->uniqueID()); obj = func(surface, SkSurface::kFlushWrite_BackendHandleAccess); REPORTER_ASSERT(reporter, obj != 0); sk_sp image2(surface->makeImageSnapshot()); // expect a new image, since we claimed we would write REPORTER_ASSERT(reporter, image0->uniqueID() != image2->uniqueID()); obj = func(surface, SkSurface::kDiscardWrite_BackendHandleAccess); REPORTER_ASSERT(reporter, obj != 0); sk_sp image3(surface->makeImageSnapshot()); // expect a new(er) image, since we claimed we would write REPORTER_ASSERT(reporter, image0->uniqueID() != image3->uniqueID()); REPORTER_ASSERT(reporter, image2->uniqueID() != image3->uniqueID()); } // No CPU test. DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBackendHandleAccessIDs_Gpu, reporter, ctxInfo) { for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { for (auto& test_func : { &test_backend_handle_unique_id, &test_backend_handle_gen_id }) { for (auto& handle_access_func : { &get_surface_backend_texture_handle, &get_surface_backend_render_target_handle}) { auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr)); test_func(reporter, surface.get(), handle_access_func); } } } } #endif // Verify that the right canvas commands trigger a copy on write. static void test_copy_on_write(skiatest::Reporter* reporter, SkSurface* surface) { SkCanvas* canvas = surface->getCanvas(); const SkRect testRect = SkRect::MakeXYWH(SkIntToScalar(0), SkIntToScalar(0), SkIntToScalar(4), SkIntToScalar(5)); SkPath testPath; testPath.addRect(SkRect::MakeXYWH(SkIntToScalar(0), SkIntToScalar(0), SkIntToScalar(2), SkIntToScalar(1))); const SkIRect testIRect = SkIRect::MakeXYWH(0, 0, 2, 1); SkRegion testRegion; testRegion.setRect(testIRect); const SkColor testColor = 0x01020304; const SkPaint testPaint; const SkPoint testPoints[3] = { {SkIntToScalar(0), SkIntToScalar(0)}, {SkIntToScalar(2), SkIntToScalar(1)}, {SkIntToScalar(0), SkIntToScalar(2)} }; const size_t testPointCount = 3; SkBitmap testBitmap; testBitmap.allocN32Pixels(10, 10); testBitmap.eraseColor(0); SkRRect testRRect; testRRect.setRectXY(testRect, SK_Scalar1, SK_Scalar1); SkString testText("Hello World"); const SkPoint testPoints2[] = { { SkIntToScalar(0), SkIntToScalar(1) }, { SkIntToScalar(1), SkIntToScalar(1) }, { SkIntToScalar(2), SkIntToScalar(1) }, { SkIntToScalar(3), SkIntToScalar(1) }, { SkIntToScalar(4), SkIntToScalar(1) }, { SkIntToScalar(5), SkIntToScalar(1) }, { SkIntToScalar(6), SkIntToScalar(1) }, { SkIntToScalar(7), SkIntToScalar(1) }, { SkIntToScalar(8), SkIntToScalar(1) }, { SkIntToScalar(9), SkIntToScalar(1) }, { SkIntToScalar(10), SkIntToScalar(1) }, }; #define EXPECT_COPY_ON_WRITE(command) \ { \ sk_sp imageBefore = surface->makeImageSnapshot(); \ sk_sp aur_before(imageBefore); \ canvas-> command ; \ sk_sp imageAfter = surface->makeImageSnapshot(); \ sk_sp aur_after(imageAfter); \ REPORTER_ASSERT(reporter, imageBefore != imageAfter); \ } EXPECT_COPY_ON_WRITE(clear(testColor)) EXPECT_COPY_ON_WRITE(drawPaint(testPaint)) EXPECT_COPY_ON_WRITE(drawPoints(SkCanvas::kPoints_PointMode, testPointCount, testPoints, \ testPaint)) EXPECT_COPY_ON_WRITE(drawOval(testRect, testPaint)) EXPECT_COPY_ON_WRITE(drawRect(testRect, testPaint)) EXPECT_COPY_ON_WRITE(drawRRect(testRRect, testPaint)) EXPECT_COPY_ON_WRITE(drawPath(testPath, testPaint)) EXPECT_COPY_ON_WRITE(drawBitmap(testBitmap, 0, 0)) EXPECT_COPY_ON_WRITE(drawBitmapRect(testBitmap, testRect, nullptr)) EXPECT_COPY_ON_WRITE(drawBitmapNine(testBitmap, testIRect, testRect, nullptr)) EXPECT_COPY_ON_WRITE(drawText(testText.c_str(), testText.size(), 0, 1, testPaint)) EXPECT_COPY_ON_WRITE(drawPosText(testText.c_str(), testText.size(), testPoints2, \ testPaint)) EXPECT_COPY_ON_WRITE(drawTextOnPath(testText.c_str(), testText.size(), testPath, nullptr, \ testPaint)) } DEF_TEST(SurfaceCopyOnWrite, reporter) { test_copy_on_write(reporter, create_surface().get()); } #if SK_SUPPORT_GPU DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceCopyOnWrite_Gpu, reporter, ctxInfo) { for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr)); test_copy_on_write(reporter, surface.get()); } } #endif static void test_writable_after_snapshot_release(skiatest::Reporter* reporter, SkSurface* surface) { // This test succeeds by not triggering an assertion. // The test verifies that the surface remains writable (usable) after // acquiring and releasing a snapshot without triggering a copy on write. SkCanvas* canvas = surface->getCanvas(); canvas->clear(1); surface->makeImageSnapshot(); // Create and destroy SkImage canvas->clear(2); // Must not assert internally } DEF_TEST(SurfaceWriteableAfterSnapshotRelease, reporter) { test_writable_after_snapshot_release(reporter, create_surface().get()); } #if SK_SUPPORT_GPU DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceWriteableAfterSnapshotRelease_Gpu, reporter, ctxInfo) { for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr)); test_writable_after_snapshot_release(reporter, surface.get()); } } #endif #if SK_SUPPORT_GPU static void test_crbug263329(skiatest::Reporter* reporter, SkSurface* surface1, SkSurface* surface2) { // This is a regression test for crbug.com/263329 // Bug was caused by onCopyOnWrite releasing the old surface texture // back to the scratch texture pool even though the texture is used // by and active SkImage_Gpu. SkCanvas* canvas1 = surface1->getCanvas(); SkCanvas* canvas2 = surface2->getCanvas(); canvas1->clear(1); sk_sp image1(surface1->makeImageSnapshot()); // Trigger copy on write, new backing is a scratch texture canvas1->clear(2); sk_sp image2(surface1->makeImageSnapshot()); // Trigger copy on write, old backing should not be returned to scratch // pool because it is held by image2 canvas1->clear(3); canvas2->clear(4); sk_sp image3(surface2->makeImageSnapshot()); // Trigger copy on write on surface2. The new backing store should not // be recycling a texture that is held by an existing image. canvas2->clear(5); sk_sp image4(surface2->makeImageSnapshot()); REPORTER_ASSERT(reporter, as_IB(image4)->peekTexture() != as_IB(image3)->peekTexture()); // The following assertion checks crbug.com/263329 REPORTER_ASSERT(reporter, as_IB(image4)->peekTexture() != as_IB(image2)->peekTexture()); REPORTER_ASSERT(reporter, as_IB(image4)->peekTexture() != as_IB(image1)->peekTexture()); REPORTER_ASSERT(reporter, as_IB(image3)->peekTexture() != as_IB(image2)->peekTexture()); REPORTER_ASSERT(reporter, as_IB(image3)->peekTexture() != as_IB(image1)->peekTexture()); REPORTER_ASSERT(reporter, as_IB(image2)->peekTexture() != as_IB(image1)->peekTexture()); } DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceCRBug263329_Gpu, reporter, ctxInfo) { for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { auto surface1(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr)); auto surface2(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr)); test_crbug263329(reporter, surface1.get(), surface2.get()); } } #endif DEF_TEST(SurfaceGetTexture, reporter) { auto surface(create_surface()); sk_sp image(surface->makeImageSnapshot()); REPORTER_ASSERT(reporter, as_IB(image)->peekTexture() == nullptr); surface->notifyContentWillChange(SkSurface::kDiscard_ContentChangeMode); REPORTER_ASSERT(reporter, as_IB(image)->peekTexture() == nullptr); } #if SK_SUPPORT_GPU DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfacepeekTexture_Gpu, reporter, ctxInfo) { for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr)); sk_sp image(surface->makeImageSnapshot()); GrTexture* texture = as_IB(image)->peekTexture(); REPORTER_ASSERT(reporter, texture); REPORTER_ASSERT(reporter, 0 != texture->getTextureHandle()); surface->notifyContentWillChange(SkSurface::kDiscard_ContentChangeMode); REPORTER_ASSERT(reporter, as_IB(image)->peekTexture() == texture); } } #endif #if SK_SUPPORT_GPU #include "GrGpuResourcePriv.h" #include "SkGpuDevice.h" #include "SkImage_Gpu.h" #include "SkSurface_Gpu.h" static SkBudgeted is_budgeted(const sk_sp& surf) { SkSurface_Gpu* gsurf = (SkSurface_Gpu*)surf.get(); return gsurf->getDevice()->accessRenderTarget()->resourcePriv().isBudgeted(); } static SkBudgeted is_budgeted(SkImage* image) { return ((SkImage_Gpu*)image)->peekTexture()->resourcePriv().isBudgeted(); } static SkBudgeted is_budgeted(const sk_sp image) { return is_budgeted(image.get()); } DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceBudget, reporter, ctxInfo) { SkImageInfo info = SkImageInfo::MakeN32Premul(8,8); for (auto sbudgeted : { SkBudgeted::kNo, SkBudgeted::kYes }) { for (auto ibudgeted : { SkBudgeted::kNo, SkBudgeted::kYes }) { auto surface(SkSurface::MakeRenderTarget(ctxInfo.grContext(), sbudgeted, info)); SkASSERT(surface); REPORTER_ASSERT(reporter, sbudgeted == is_budgeted(surface)); sk_sp image(surface->makeImageSnapshot(ibudgeted)); // Initially the image shares a texture with the surface, and the surface decides // whether it is budgeted or not. REPORTER_ASSERT(reporter, sbudgeted == is_budgeted(surface)); REPORTER_ASSERT(reporter, sbudgeted == is_budgeted(image)); // Now trigger copy-on-write surface->getCanvas()->clear(SK_ColorBLUE); // They don't share a texture anymore. They should each have made their own budget // decision. REPORTER_ASSERT(reporter, sbudgeted == is_budgeted(surface)); REPORTER_ASSERT(reporter, ibudgeted == is_budgeted(image)); } } } #endif static void test_no_canvas1(skiatest::Reporter* reporter, SkSurface* surface, SkSurface::ContentChangeMode mode) { // Test passes by not asserting surface->notifyContentWillChange(mode); SkDEBUGCODE(surface->validate();) } static void test_no_canvas2(skiatest::Reporter* reporter, SkSurface* surface, SkSurface::ContentChangeMode mode) { // Verifies the robustness of SkSurface for handling use cases where calls // are made before a canvas is created. sk_sp image1 = surface->makeImageSnapshot(); sk_sp aur_image1(image1); SkDEBUGCODE(image1->validate();) SkDEBUGCODE(surface->validate();) surface->notifyContentWillChange(mode); SkDEBUGCODE(image1->validate();) SkDEBUGCODE(surface->validate();) sk_sp image2 = surface->makeImageSnapshot(); sk_sp aur_image2(image2); SkDEBUGCODE(image2->validate();) SkDEBUGCODE(surface->validate();) REPORTER_ASSERT(reporter, image1 != image2); } DEF_TEST(SurfaceNoCanvas, reporter) { SkSurface::ContentChangeMode modes[] = { SkSurface::kDiscard_ContentChangeMode, SkSurface::kRetain_ContentChangeMode}; for (auto& test_func : { &test_no_canvas1, &test_no_canvas2 }) { for (auto& mode : modes) { test_func(reporter, create_surface().get(), mode); } } } #if SK_SUPPORT_GPU DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceNoCanvas_Gpu, reporter, ctxInfo) { SkSurface::ContentChangeMode modes[] = { SkSurface::kDiscard_ContentChangeMode, SkSurface::kRetain_ContentChangeMode}; for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) { for (auto& test_func : { &test_no_canvas1, &test_no_canvas2 }) { for (auto& mode : modes) { auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr)); test_func(reporter, surface.get(), mode); } } } } #endif static void check_rowbytes_remain_consistent(SkSurface* surface, skiatest::Reporter* reporter) { SkPixmap surfacePM; REPORTER_ASSERT(reporter, surface->peekPixels(&surfacePM)); sk_sp image(surface->makeImageSnapshot()); SkPixmap pm; REPORTER_ASSERT(reporter, image->peekPixels(&pm)); REPORTER_ASSERT(reporter, surfacePM.rowBytes() == pm.rowBytes()); // trigger a copy-on-write surface->getCanvas()->drawPaint(SkPaint()); sk_sp image2(surface->makeImageSnapshot()); REPORTER_ASSERT(reporter, image->uniqueID() != image2->uniqueID()); SkPixmap pm2; REPORTER_ASSERT(reporter, image2->peekPixels(&pm2)); REPORTER_ASSERT(reporter, pm2.rowBytes() == pm.rowBytes()); } DEF_TEST(surface_rowbytes, reporter) { const SkImageInfo info = SkImageInfo::MakeN32Premul(100, 100); auto surf0(SkSurface::MakeRaster(info)); check_rowbytes_remain_consistent(surf0.get(), reporter); // specify a larger rowbytes auto surf1(SkSurface::MakeRaster(info, 500, nullptr)); check_rowbytes_remain_consistent(surf1.get(), reporter); // Try some illegal rowByte values auto s = SkSurface::MakeRaster(info, 396, nullptr); // needs to be at least 400 REPORTER_ASSERT(reporter, nullptr == s); s = SkSurface::MakeRaster(info, 1 << 30, nullptr); // allocation to large REPORTER_ASSERT(reporter, nullptr == s); } #if SK_SUPPORT_GPU static sk_sp create_gpu_surface_backend_texture( GrContext* context, int sampleCnt, uint32_t color, GrBackendObject* outTexture) { const int kWidth = 10; const int kHeight = 10; SkAutoTDeleteArray pixels(new uint32_t[kWidth * kHeight]); sk_memset32(pixels.get(), color, kWidth * kHeight); GrBackendTextureDesc desc; desc.fConfig = kRGBA_8888_GrPixelConfig; desc.fWidth = kWidth; desc.fHeight = kHeight; desc.fFlags = kRenderTarget_GrBackendTextureFlag; desc.fTextureHandle = context->getGpu()->createTestingOnlyBackendTexture( pixels.get(), kWidth, kHeight, kRGBA_8888_GrPixelConfig, true); desc.fSampleCnt = sampleCnt; sk_sp surface = SkSurface::MakeFromBackendTexture(context, desc, nullptr); if (!surface) { context->getGpu()->deleteTestingOnlyBackendTexture(desc.fTextureHandle); return nullptr; } *outTexture = desc.fTextureHandle; return surface; } static sk_sp create_gpu_surface_backend_texture_as_render_target( GrContext* context, int sampleCnt, uint32_t color, GrBackendObject* outTexture) { const int kWidth = 10; const int kHeight = 10; SkAutoTDeleteArray pixels(new uint32_t[kWidth * kHeight]); sk_memset32(pixels.get(), color, kWidth * kHeight); GrBackendTextureDesc desc; desc.fConfig = kRGBA_8888_GrPixelConfig; desc.fWidth = kWidth; desc.fHeight = kHeight; desc.fFlags = kRenderTarget_GrBackendTextureFlag; desc.fTextureHandle = context->getGpu()->createTestingOnlyBackendTexture( pixels.get(), kWidth, kHeight, kRGBA_8888_GrPixelConfig, true); desc.fSampleCnt = sampleCnt; sk_sp surface = SkSurface::MakeFromBackendTextureAsRenderTarget(context, desc, nullptr); if (!surface) { context->getGpu()->deleteTestingOnlyBackendTexture(desc.fTextureHandle); return nullptr; } *outTexture = desc.fTextureHandle; return surface; } static void test_surface_clear(skiatest::Reporter* reporter, sk_sp surface, std::function grSurfaceGetter, uint32_t expectedValue) { if (!surface) { ERRORF(reporter, "Could not create GPU SkSurface."); return; } int w = surface->width(); int h = surface->height(); SkAutoTDeleteArray pixels(new uint32_t[w * h]); sk_memset32(pixels.get(), ~expectedValue, w * h); SkAutoTUnref grSurface(SkSafeRef(grSurfaceGetter(surface.get()))); if (!grSurface) { ERRORF(reporter, "Could access render target of GPU SkSurface."); return; } surface.reset(); grSurface->readPixels(0, 0, w, h, kRGBA_8888_GrPixelConfig, pixels.get()); for (int y = 0; y < h; ++y) { for (int x = 0; x < w; ++x) { uint32_t pixel = pixels.get()[y * w + x]; if (pixel != expectedValue) { SkString msg; if (expectedValue) { msg = "SkSurface should have left render target unmodified"; } else { msg = "SkSurface should have cleared the render target"; } ERRORF(reporter, "%s but read 0x%08x (instead of 0x%08x) at %x,%d", msg.c_str(), pixel, expectedValue, x, y); return; } } } } DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceClear_Gpu, reporter, ctxInfo) { GrContext* context = ctxInfo.grContext(); std::function grSurfaceGetters[] = { [] (SkSurface* s){ GrDrawContext* dc = s->getCanvas()->internal_private_accessTopLayerDrawContext(); return dc->accessRenderTarget(); }, [] (SkSurface* s){ SkBaseDevice* d = s->getCanvas()->getDevice_just_for_deprecated_compatibility_testing(); return d->accessRenderTarget(); }, [] (SkSurface* s){ sk_sp i(s->makeImageSnapshot()); return as_IB(i)->peekTexture(); } }; for (auto grSurfaceGetter : grSurfaceGetters) { // Test that non-wrapped RTs are created clear. for (auto& surface_func : {&create_gpu_surface, &create_gpu_scratch_surface}) { auto surface = surface_func(context, kPremul_SkAlphaType, nullptr); test_surface_clear(reporter, surface, grSurfaceGetter, 0x0); } // Wrapped RTs are *not* supposed to clear (to allow client to partially update a surface). const uint32_t kOrigColor = 0xABABABAB; for (auto& surfaceFunc : {&create_gpu_surface_backend_texture, &create_gpu_surface_backend_texture_as_render_target}) { GrBackendObject textureObject; auto surface = surfaceFunc(context, 0, kOrigColor, &textureObject); test_surface_clear(reporter, surface, grSurfaceGetter, kOrigColor); surface.reset(); context->getGpu()->deleteTestingOnlyBackendTexture(textureObject); } } } static void test_surface_draw_partially( skiatest::Reporter* reporter, sk_sp surface, uint32_t origColor) { const int kW = surface->width(); const int kH = surface->height(); SkPaint paint; const SkColor kRectColor = ~origColor | 0xFF000000; paint.setColor(kRectColor); surface->getCanvas()->drawRect(SkRect::MakeWH(SkIntToScalar(kW), SkIntToScalar(kH)/2), paint); SkAutoTDeleteArray pixels(new uint32_t[kW * kH]); sk_memset32(pixels.get(), ~origColor, kW * kH); // Read back RGBA to avoid format conversions that may not be supported on all platforms. SkImageInfo readInfo = SkImageInfo::Make(kW, kH, kRGBA_8888_SkColorType, kPremul_SkAlphaType); SkAssertResult(surface->readPixels(readInfo, pixels.get(), kW * sizeof(uint32_t), 0, 0)); bool stop = false; SkPMColor origColorPM = SkPackARGB_as_RGBA((origColor >> 24 & 0xFF), (origColor >> 0 & 0xFF), (origColor >> 8 & 0xFF), (origColor >> 16 & 0xFF)); SkPMColor rectColorPM = SkPackARGB_as_RGBA((kRectColor >> 24 & 0xFF), (kRectColor >> 16 & 0xFF), (kRectColor >> 8 & 0xFF), (kRectColor >> 0 & 0xFF)); for (int y = 0; y < kH/2 && !stop; ++y) { for (int x = 0; x < kW && !stop; ++x) { REPORTER_ASSERT(reporter, rectColorPM == pixels[x + y * kW]); if (rectColorPM != pixels[x + y * kW]) { stop = true; } } } stop = false; for (int y = kH/2; y < kH && !stop; ++y) { for (int x = 0; x < kW && !stop; ++x) { REPORTER_ASSERT(reporter, origColorPM == pixels[x + y * kW]); if (origColorPM != pixels[x + y * kW]) { stop = true; } } } } DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfacePartialDraw_Gpu, reporter, ctxInfo) { GrGpu* gpu = ctxInfo.grContext()->getGpu(); if (!gpu) { return; } static const uint32_t kOrigColor = 0xFFAABBCC; for (auto& surfaceFunc : {&create_gpu_surface_backend_texture, &create_gpu_surface_backend_texture_as_render_target}) { // Validate that we can draw to the canvas and that the original texture color is // preserved in pixels that aren't rendered to via the surface. // This works only for non-multisampled case. GrBackendObject textureObject; auto surface = surfaceFunc(ctxInfo.grContext(), 0, kOrigColor, &textureObject); if (surface) { test_surface_draw_partially(reporter, surface, kOrigColor); surface.reset(); gpu->deleteTestingOnlyBackendTexture(textureObject); } } } DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceAttachStencil_Gpu, reporter, ctxInfo) { GrGpu* gpu = ctxInfo.grContext()->getGpu(); if (!gpu) { return; } static const uint32_t kOrigColor = 0xFFAABBCC; for (auto& surfaceFunc : {&create_gpu_surface_backend_texture, &create_gpu_surface_backend_texture_as_render_target}) { for (int sampleCnt : {0, 4, 8}) { GrBackendObject textureObject; auto surface = surfaceFunc(ctxInfo.grContext(), sampleCnt, kOrigColor, &textureObject); if (!surface && sampleCnt > 0) { // Certain platforms don't support MSAA, skip these. continue; } // Validate that we can attach a stencil buffer to an SkSurface created by either of // our surface functions. GrRenderTarget* rt = surface->getCanvas()->internal_private_accessTopLayerDrawContext() ->accessRenderTarget(); REPORTER_ASSERT(reporter, ctxInfo.grContext()->resourceProvider()->attachStencilAttachment(rt)); gpu->deleteTestingOnlyBackendTexture(textureObject); } } } #endif