From 2b3c2a3ff9166e92ca1700e695c30ae729a3f10c Mon Sep 17 00:00:00 2001 From: mtklein Date: Thu, 8 Sep 2016 08:39:34 -0700 Subject: GN: add sanitize arg Attempt to take over all *SAN builds. MSAN has a lot of coordination required between gn/BUILD.gn and gn_flavor.py. I'd like to follow up to move more of this into gn/BUILD.gn, to make it easier to use locally. The compile steps should be much faster now. We no longer build CMake and Clang for every run, instead using the clang_linux CIPD package. This removes the need for all the third_party/externals/llvm/... dependencies. Similarly, since we're using the clang_linux package, we no longer depend on Chrome's Clang, and thus no longer need to sync chromium on these bots. Instead of packaging up MSAN libraries and llvm-symbolizer in the compile output, I have the test / perf bots also depend on the clang_linux package. These do not vary from build to build. No more need for the xsan.blacklist -include hack: Clang, GN, and Ninja all track changes to xsan.blacklist without our help. This has the incidental effect of upgrading the compiler used by *SAN bots from Clang 3.8 to Clang 3.9. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289343002 Review-Url: https://codereview.chromium.org/2289343002 --- tools/xsan.blacklist | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) (limited to 'tools/xsan.blacklist') diff --git a/tools/xsan.blacklist b/tools/xsan.blacklist index 57c8020759..a917e2d3d4 100644 --- a/tools/xsan.blacklist +++ b/tools/xsan.blacklist @@ -1,12 +1,2 @@ -#if 0 - -# This file must be a no-op C #include header, and a valid *SAN blacklist file. -# Luckily, anything starting with # is a comment to *SAN blacklist files, -# and anything inside #if 0 is ignored by C. Yippee! -# -# If you want to type '*', type '.*' instead. Don't make C comments! - # Suppress third_party/externals. We mostly care about our own code. -src:.*third_party/externals.* - -#endif +src:*third_party/externals* -- cgit v1.2.3