From 24c568c1597de9f54df8cea3b46f2e93028a5aec Mon Sep 17 00:00:00 2001 From: "commit-bot@chromium.org" Date: Thu, 10 Apr 2014 15:39:02 +0000 Subject: add explicit filepaths to render_pictures JSON summary BUG=skia:2230,skia:1942 R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/226293002 git-svn-id: http://skia.googlecode.com/svn/trunk@14133 2bbb7eff-a529-9590-31e7-b0007b416f81 --- tools/picture_utils.h | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'tools/picture_utils.h') diff --git a/tools/picture_utils.h b/tools/picture_utils.h index 4c2f6e546a..02eee285d0 100644 --- a/tools/picture_utils.h +++ b/tools/picture_utils.h @@ -24,14 +24,25 @@ namespace sk_tools { // not be on the GPU. void force_all_opaque(const SkBitmap& bitmap); + /** + * Replaces all instances of oldChar with newChar in str. + * + * TODO: This function appears here and in skimage_main.cpp ; + * we should add the implementation to src/core/SkString.cpp, write tests for it, + * and remove it from elsewhere. + */ + void replace_char(SkString* str, const char oldChar, const char newChar); + // Creates a posix style filepath by concatenating name onto dir with a // forward slash into path. + // TODO(epoger): delete in favor of SkOSPath::SkPathJoin()? void make_filepath(SkString* path, const SkString&, const SkString& name); // Returns the last part of the path (file name or leaf directory name) // // This basically just looks for a foward slash or backslash (windows // only). + // TODO(epoger): delete in favor of SkOSPath::SkBasename()? void get_basename(SkString* basename, const SkString& path); // Returns true if the string ends with % -- cgit v1.2.3