From cda08f84907136186ee2dcfde1dd04a8531e5315 Mon Sep 17 00:00:00 2001 From: rmistry Date: Tue, 26 Apr 2016 08:27:49 -0700 Subject: Return error code when get_images_from_skps has failures. BUG=skia:4981 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916183002 Review URL: https://codereview.chromium.org/1916183002 --- tools/get_images_from_skps.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'tools/get_images_from_skps.cpp') diff --git a/tools/get_images_from_skps.cpp b/tools/get_images_from_skps.cpp index f963b9a86b..a78c412a1b 100644 --- a/tools/get_images_from_skps.cpp +++ b/tools/get_images_from_skps.cpp @@ -157,12 +157,14 @@ int main(int argc, char** argv) { SkDebugf("%d known, %d unknown\n", gKnown, totalUnknowns); fRoot["totalFailures"] = totalUnknowns; fRoot["totalSuccesses"] = gKnown; - if (totalUnknowns > 0 && !FLAGS_failuresJsonPath.isEmpty()) { - SkDebugf("Writing failures to %s\n", FLAGS_failuresJsonPath[0]); - SkFILEWStream stream(FLAGS_failuresJsonPath[0]); - stream.writeText(Json::StyledWriter().write(fRoot).c_str()); - stream.flush(); + if (totalUnknowns > 0) { + if (!FLAGS_failuresJsonPath.isEmpty()) { + SkDebugf("Writing failures to %s\n", FLAGS_failuresJsonPath[0]); + SkFILEWStream stream(FLAGS_failuresJsonPath[0]); + stream.writeText(Json::StyledWriter().write(fRoot).c_str()); + stream.flush(); + } + return -1; } - return 0; } -- cgit v1.2.3