From af18f22da6c53346a326dcb0c1b237e20ca44fe4 Mon Sep 17 00:00:00 2001 From: Leon Scroggins III Date: Thu, 15 Mar 2018 16:35:56 -0400 Subject: Make get_images_from_skps always return success Previously, it would fail (and thus turn the bot red) if an image failed to decode (e.g. with SkCodec::Result of kInvalidInput). This tends to happen because the captured page had not fully downloaded yet. Stop treating this an error. It may still be useful to test using SkCodec just to be sure that we didn't crash, so keep running the test. Change-Id: I1a0530fb82fa32d95c5f01d5131626745cf6c4f2 Reviewed-on: https://skia-review.googlesource.com/114582 Reviewed-by: Ravi Mistry Reviewed-by: Mike Reed Commit-Queue: Leon Scroggins --- tools/get_images_from_skps.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'tools/get_images_from_skps.cpp') diff --git a/tools/get_images_from_skps.cpp b/tools/get_images_from_skps.cpp index 35624348ff..3c15403d6d 100644 --- a/tools/get_images_from_skps.cpp +++ b/tools/get_images_from_skps.cpp @@ -208,7 +208,6 @@ int main(int argc, char** argv) { stream.writeText(Json::StyledWriter().write(fRoot).c_str()); stream.flush(); } - return -1; } return 0; } -- cgit v1.2.3