From 788a5f0871eb832eb4c8b884de407ae1bddd2c13 Mon Sep 17 00:00:00 2001 From: "commit-bot@chromium.org" Date: Mon, 27 Jan 2014 16:34:45 +0000 Subject: Explain empty report in compare_codereview.py. Let user know when control and roll have no common trybots, instead of being silent. BUG=skia: R=borenet@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/135683003 git-svn-id: http://skia.googlecode.com/svn/trunk@13194 2bbb7eff-a529-9590-31e7-b0007b416f81 --- tools/compare_codereview.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'tools/compare_codereview.py') diff --git a/tools/compare_codereview.py b/tools/compare_codereview.py index 16f3a0198d..ae2909611e 100755 --- a/tools/compare_codereview.py +++ b/tools/compare_codereview.py @@ -325,12 +325,15 @@ def main(control_url, roll_url, verbosity=1): # pylint: disable=I0011,R0914,R0912 control = CodeReviewHTMLParser.parse(control_url) roll = CodeReviewHTMLParser.parse(roll_url) - if not (control and roll): + all_bots = set(control) & set(roll) # Set intersection. + if not all_bots: + print >> sys.stderr, ( + 'Error: control %s and roll %s have no common trybots.' + % (list(control), list(roll))) return control_name = '[control %s]' % control_url.split('/')[-1] roll_name = '[roll %s]' % roll_url.split('/')[-1] - all_bots = set(control) & set(roll) # Set intersection. out = sys.stdout if verbosity > 0: -- cgit v1.2.3