From e70b9e899c987a73d964b9b630c65523ad84717a Mon Sep 17 00:00:00 2001
From: Cary Clark <caryclark@skia.org>
Date: Tue, 23 Jan 2018 08:59:11 -0500
Subject: report error on global enum

rather than segfault when running
bookmaker cross check, report
a parsable error.

In a separate CL, I'll add support
for global enums.

R=herb@google.com
Bug: skia:6898
Change-Id: I91c62df5470acbf5c0acf0c558d2d5d3bf48d40e
Reviewed-on: https://skia-review.googlesource.com/98682
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Herb Derby <herb@google.com>
---
 tools/bookmaker/includeParser.cpp | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'tools/bookmaker')

diff --git a/tools/bookmaker/includeParser.cpp b/tools/bookmaker/includeParser.cpp
index 26281b6184..548a3b94da 100644
--- a/tools/bookmaker/includeParser.cpp
+++ b/tools/bookmaker/includeParser.cpp
@@ -1231,6 +1231,9 @@ bool IncludeParser::parseDefine() {
 }
 
 bool IncludeParser::parseEnum(Definition* child, Definition* markupDef) {
+    if (!markupDef) {
+        return child->reportError<bool>("no support for global enum declaration");
+    }
     string nameStr;
     if (child->fTokens.size() > 0) {
         auto token = child->fTokens.begin();
-- 
cgit v1.2.3