From c6f7a4ffa9522159efc42f7c948bba5e66bb8844 Mon Sep 17 00:00:00 2001 From: Leon Scroggins III Date: Mon, 4 Dec 2017 16:40:24 -0500 Subject: Hide SkEncodedInfo Bug: skia:7353 Bug: skia:6839 This contains information that is not necessary for clients to know. The Color enum tells the number of components in the input, but this is only interesting internally (to the SkSwizzler). Similarly, the Alpha enum differs from SkAlphaType in that it has kBinary instead of kPremul. This is useful information only internally for determining whether the SkColorSpaceXform needs to premultiply. The bitsPerComponent is potentially useful for a client; Android (in SkAndroidCodec) uses it to determine the SkColorType. Rather than exposing bitsPerComponent, use it to make the same decision that Android would have made - 16 bits per component means to set the info to F16. Add a test that computeOutputColorType behaves as expected. Switch conversionSupported to use an SkColorType, which is enough info. Replace the SkEncodedInfo::Alpha field on SkCodec::FrameInfo with an SkAlphaType. SkCodec still needs an SkEncodedInfo, so move its header (which is already not SK_API) to include/private. Change-Id: Ie2cf11339bf999ebfd4390c0f448f7edd6feabda Reviewed-on: https://skia-review.googlesource.com/79260 Reviewed-by: Mike Reed Reviewed-by: Mike Klein Commit-Queue: Leon Scroggins --- third_party/gif/SkGifImageReader.cpp | 7 ++++--- third_party/gif/SkGifImageReader.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) (limited to 'third_party/gif') diff --git a/third_party/gif/SkGifImageReader.cpp b/third_party/gif/SkGifImageReader.cpp index a54fb59d3b..a04f8e11d0 100644 --- a/third_party/gif/SkGifImageReader.cpp +++ b/third_party/gif/SkGifImageReader.cpp @@ -879,15 +879,16 @@ static bool restore_bg(const SkFrame& frame) { return frame.getDisposalMethod() == SkCodecAnimation::DisposalMethod::kRestoreBGColor; } -bool SkGIFFrameContext::onReportsAlpha() const { +SkEncodedInfo::Alpha SkGIFFrameContext::onReportedAlpha() const { // Note: We could correct these after decoding - i.e. some frames may turn out to be // independent and opaque if they do not use the transparent pixel, but that would require // checking whether each pixel used the transparent index. - return is_palette_index_valid(this->transparentPixel()); + return is_palette_index_valid(this->transparentPixel()) ? SkEncodedInfo::kBinary_Alpha + : SkEncodedInfo::kOpaque_Alpha; } void SkFrameHolder::setAlphaAndRequiredFrame(SkFrame* frame) { - const bool reportsAlpha = frame->reportsAlpha(); + const bool reportsAlpha = frame->reportedAlpha() != SkEncodedInfo::kOpaque_Alpha; const auto screenRect = SkIRect::MakeWH(fScreenWidth, fScreenHeight); const auto frameRect = frame_rect_on_screen(frame->frameRect(), screenRect); diff --git a/third_party/gif/SkGifImageReader.h b/third_party/gif/SkGifImageReader.h index b5eca10dfb..5d8597fccf 100644 --- a/third_party/gif/SkGifImageReader.h +++ b/third_party/gif/SkGifImageReader.h @@ -247,7 +247,7 @@ public: SkGIFColorMap& localColorMap() { return m_localColorMap; } protected: - bool onReportsAlpha() const override; + SkEncodedInfo::Alpha onReportedAlpha() const override; private: int m_transparentPixel; // Index of transparent pixel. Value is kNotFound if there is no transparent pixel. -- cgit v1.2.3