From b935cf8e12d7371246d318f20f4ebf88e321573a Mon Sep 17 00:00:00 2001 From: Herb Derby Date: Thu, 26 Jul 2018 16:54:18 -0400 Subject: const all the things Having the glyph run list be const as it passes through the stack means that future change can't be introduced in the device code that changes behavior. Try to force all text changes into the SkGylphRun system. Change-Id: I9412bc094c7adb8554887c725a6264af306e1d42 Reviewed-on: https://skia-review.googlesource.com/143702 Commit-Queue: Herb Derby Reviewed-by: Ben Wagner --- tests/GlyphRunTest.cpp | 4 ++-- tests/PDFPrimitivesTest.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'tests') diff --git a/tests/GlyphRunTest.cpp b/tests/GlyphRunTest.cpp index 49d7340aca..9cd9c4ff83 100644 --- a/tests/GlyphRunTest.cpp +++ b/tests/GlyphRunTest.cpp @@ -86,9 +86,9 @@ DEF_TEST(GlyphRunBlob, reporter) { auto runList = runBuilder.useGlyphRunList(); - REPORTER_ASSERT(reporter, runList->size() == runCount); + REPORTER_ASSERT(reporter, runList.size() == runCount); int runIndex = 0; - for (auto& run : *runList) { + for (auto& run : runList) { REPORTER_ASSERT(reporter, run.runSize() == count); int index = 0; diff --git a/tests/PDFPrimitivesTest.cpp b/tests/PDFPrimitivesTest.cpp index adbfdc763c..a9214ff948 100644 --- a/tests/PDFPrimitivesTest.cpp +++ b/tests/PDFPrimitivesTest.cpp @@ -494,7 +494,7 @@ static SkGlyphRun make_run(size_t len, const SkGlyphID* glyphs, SkPoint* pos, size_t utf8TextByteLength, const char* utf8Text) { return SkGlyphRun(std::move(paint), SkSpan{}, // No dense indices for now. - SkSpan{pos, len}, + SkSpan{pos, len}, SkSpan{glyphs, len}, SkSpan{}, SkSpan{utf8Text, utf8TextByteLength}, -- cgit v1.2.3