From 9a5d1ab54d52a912bb3ac9f74ee01bba079639e5 Mon Sep 17 00:00:00 2001 From: fmalita Date: Mon, 27 Jul 2015 10:27:28 -0700 Subject: Make peekPixels() usable with raster surface snapshots SkSurface_Raster snapshots do not lock their backing bitmaps when the pixel ref is shared - they only lock on deep-copy. But since for raster surfaces the pixels are always in memory, I think it would be OK to also lock in the former case. This allows for optimized (zero-copy) reads of raster surface snapshot data. R=reed@google.com Review URL: https://codereview.chromium.org/1256993002 --- tests/SkImageTest.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'tests/SkImageTest.cpp') diff --git a/tests/SkImageTest.cpp b/tests/SkImageTest.cpp index 2f23b3f661..508982cea6 100644 --- a/tests/SkImageTest.cpp +++ b/tests/SkImageTest.cpp @@ -26,7 +26,8 @@ DEF_TEST(SkImageFromBitmap_extractSubset, reporter) { canvas.drawIRect(r, p); SkBitmap dstBitmap; srcBitmap.extractSubset(&dstBitmap, r); - image.reset(SkNewImageFromRasterBitmap(dstBitmap, true, NULL)); + image.reset(SkNewImageFromRasterBitmap(dstBitmap, true, NULL, + kUnlocked_SharedPixelRefMode)); } SkBitmap tgt; -- cgit v1.2.3