From 9ea53f93e79ba312c4b3943923450a8b4aa57c82 Mon Sep 17 00:00:00 2001 From: tfarina Date: Tue, 24 Jun 2014 06:50:39 -0700 Subject: Preprend Test to test function name generated by DEF_TEST() macro. That way when declaring a test with DEF_TEST() macro, you don't have to uniquify the test name because it might colide with the class it is being testing. For example, if you are testing SkBase64 and do: DEF_TEST(SkBase64, reporter) { } That will generate an error because the macro will declare a function named SkBase64 which colides with the type SkBase64. By adding Test to the function name we avoid this problem. Fixed the entries found with the following command line: $ git grep "Test, r" | grep DEF BUG=None TEST=make tests && out/Debug/tests R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/345753007 --- tests/SkBase64Test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/SkBase64Test.cpp') diff --git a/tests/SkBase64Test.cpp b/tests/SkBase64Test.cpp index 217e2ca56d..14ff1f7717 100644 --- a/tests/SkBase64Test.cpp +++ b/tests/SkBase64Test.cpp @@ -9,7 +9,7 @@ #include "Test.h" -DEF_TEST(SkBase64Test, reporter) { +DEF_TEST(SkBase64, reporter) { char all[256]; for (int index = 0; index < 256; ++index) { all[index] = (signed char) (index + 1); -- cgit v1.2.3