From 4eb6f7a698e80ce0faa7e3700e6cfd0d89f99089 Mon Sep 17 00:00:00 2001 From: Cary Clark Date: Tue, 17 Apr 2018 13:34:37 -0400 Subject: path is rect diag test is required Removed a test that appeared to go uncalled; Ivan to the rescue, with a test case proving that it is required. R=robertphillips@google.com Bug: 824145,skia:7792 Change-Id: I7df9688072bd36b7597673148e3fe5dbbf82f5a7 Reviewed-on: https://skia-review.googlesource.com/121883 Commit-Queue: Cary Clark Commit-Queue: Robert Phillips Auto-Submit: Cary Clark Reviewed-by: Robert Phillips --- tests/PathTest.cpp | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'tests/PathTest.cpp') diff --git a/tests/PathTest.cpp b/tests/PathTest.cpp index d7b38d87e1..611393becd 100644 --- a/tests/PathTest.cpp +++ b/tests/PathTest.cpp @@ -5018,4 +5018,10 @@ DEF_TEST(Path_isRect, reporter) { SkPoint points36[] = { {75, 75}, {150, 75}, {150, 150}, {10, 150}, {75, 75}, {75, 75} }; path = makePath2(points36, verbs36, SK_ARRAY_COUNT(verbs36)); REPORTER_ASSERT(reporter, !path.isRect(&rect, nullptr, nullptr)); + // isolated from skbug.com/7792#c39 + SkPath::Verb verbs39[] = { SkPath::kMove_Verb, SkPath::kLine_Verb, SkPath::kLine_Verb, + SkPath::kLine_Verb }; + SkPoint points39[] = { {150, 75}, {150, 150}, {75, 150}, {75, 100} }; + path = makePath2(points39, verbs39, SK_ARRAY_COUNT(verbs39)); + REPORTER_ASSERT(reporter, !path.isRect(&rect, nullptr, nullptr)); } -- cgit v1.2.3