From 00b621cfc0dac2a0028757a974de33a78bb8579d Mon Sep 17 00:00:00 2001 From: mtklein Date: Wed, 17 Jun 2015 15:26:15 -0700 Subject: Add sk_parallel_for() This should be a drop-in replacement for most for-loops to make them run in parallel: for (int i = 0; i < N; i++) { code... } ~~~> sk_parallel_for(N, [&](int i) { code... }); This is just syntax sugar over SkTaskGroup to make this use case really easy to write. There's no more overhead that we weren't already forced to add using an interface like batch(), and no extra heap allocations. I've replaced 3 uses of SkTaskGroup with sk_parallel_for: 1) My unit tests for SkOnce. 2) Cary's path fuzzer. 3) SkMultiPictureDraw. Performance should be the same. Please compare left and right for readability. :) BUG=skia: No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1184373003 --- tests/PathOpsThreadedCommon.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'tests/PathOpsThreadedCommon.cpp') diff --git a/tests/PathOpsThreadedCommon.cpp b/tests/PathOpsThreadedCommon.cpp index 0adde915e0..10501d139c 100644 --- a/tests/PathOpsThreadedCommon.cpp +++ b/tests/PathOpsThreadedCommon.cpp @@ -16,8 +16,7 @@ PathOpsThreadedTestRunner::~PathOpsThreadedTestRunner() { } void PathOpsThreadedTestRunner::render() { - SkTaskGroup tg; - for (int index = 0; index < fRunnables.count(); ++ index) { - tg.add(fRunnables[index]); - } + sk_parallel_for(fRunnables.count(), [&](int i) { + fRunnables[i]->run(); + }); } -- cgit v1.2.3