From 27c46a08a9210e9306b8ea1b00349ec198153c38 Mon Sep 17 00:00:00 2001 From: hcm Date: Tue, 28 Oct 2014 10:55:54 -0700 Subject: Revert of harden pathops for pathological test (patchset #19 id:410001 of https://codereview.chromium.org/633393002/) Reason for revert: Compile errors on bots Original issue's description: > These tests stress pathops by describing the union of circle-like paths that have tiny line segments embedded and double back to create near-coincident conditions. > > The fixes include > - detect when finding the active top loops between two possible answers > - preflight chasing winding to ensure answer is consistent > - binary search more often when quadratic intersection fails > - add more failure paths when an intersect is missed > > While this fixes the chrome bug, reenabling path ops in svg should be deferred until additional fixes are landed. > > TBR= > BUG=421132 > > Committed: https://skia.googlesource.com/skia/+/6f726addf3178b01949bb389ef83cf14a1d7b6b2 TBR=caryclark@google.com NOTREECHECKS=true NOTRY=true BUG=421132 Review URL: https://codereview.chromium.org/686843002 --- tests/PathOpsQuadReduceOrderTest.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/PathOpsQuadReduceOrderTest.cpp') diff --git a/tests/PathOpsQuadReduceOrderTest.cpp b/tests/PathOpsQuadReduceOrderTest.cpp index dd2c493f78..9a0bdcf308 100644 --- a/tests/PathOpsQuadReduceOrderTest.cpp +++ b/tests/PathOpsQuadReduceOrderTest.cpp @@ -56,7 +56,7 @@ static void standardTestCases(skiatest::Reporter* reporter) { for (index = firstQuadraticModLineTest; index < quadraticModEpsilonLines_count; ++index) { const SkDQuad& quad = quadraticModEpsilonLines[index]; order = reducer.reduce(quad); - if (order != 2 && order != 3) { // FIXME: data probably is not good + if (order != 3) { SkDebugf("[%d] line mod quad order=%d\n", (int) index, order); } } -- cgit v1.2.3