From 1326068147ee60de138061a3fc1157fcfd5d017b Mon Sep 17 00:00:00 2001 From: caryclark Date: Mon, 24 Oct 2016 05:10:14 -0700 Subject: formalize host debugging Pathops writes files, anticipating upcoming crashes, and verifies the results against regions. Formalize these debugging methods so that they are more easily triggered by hosts outside of skia unit tests. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2441763003 Review-Url: https://codereview.chromium.org/2441763003 --- tests/PathOpsIssue3651.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'tests/PathOpsIssue3651.cpp') diff --git a/tests/PathOpsIssue3651.cpp b/tests/PathOpsIssue3651.cpp index 574bec09c3..bd4ed2d9ab 100644 --- a/tests/PathOpsIssue3651.cpp +++ b/tests/PathOpsIssue3651.cpp @@ -473,7 +473,8 @@ static void issue3651_1a(skiatest::Reporter* reporter, const char* filename) { SkPath path = path1_a(); SkPath pathB = path2_a(); // DEBUG_UNDER_DEVELOPMENT issue3651_1a disable expectation check for now - testPathOpCheck(reporter, path, pathB, SkPathOp::kUnion_SkPathOp, filename, !FLAGS_runFail); + testPathOpCheck(reporter, path, pathB, SkPathOp::kUnion_SkPathOp, filename, + !SkOpGlobalState::DebugRunFail()); } static SkPath path3() { @@ -1204,7 +1205,8 @@ static void issue3651_1(skiatest::Reporter* reporter, const char* filename) { SkPath path = path1(); SkPath pathB = path2(); // DEBUG_UNDER_DEVELOPMENT issue3651_1 disable expectation check for now - testPathOpCheck(reporter, path, pathB, SkPathOp::kUnion_SkPathOp, filename, !FLAGS_runFail); + testPathOpCheck(reporter, path, pathB, SkPathOp::kUnion_SkPathOp, filename, + !SkOpGlobalState::DebugRunFail()); } static void issue3651_2(skiatest::Reporter* reporter, const char* filename) { -- cgit v1.2.3