From 473f69276f1854db80e094cc4af091f7f8a5b00b Mon Sep 17 00:00:00 2001 From: Mike Reed Date: Fri, 16 Mar 2018 10:15:43 -0400 Subject: fix nextContour bug Calling nextContour() needs to ensure that we've already measured the "current" one. Bug: skia: Change-Id: I501c26d0b068028d67103888f06ec89125a5407a Reviewed-on: https://skia-review.googlesource.com/114692 Reviewed-by: Cary Clark Commit-Queue: Mike Reed --- tests/PathMeasureTest.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'tests/PathMeasureTest.cpp') diff --git a/tests/PathMeasureTest.cpp b/tests/PathMeasureTest.cpp index df66578f1b..bc75c5f122 100644 --- a/tests/PathMeasureTest.cpp +++ b/tests/PathMeasureTest.cpp @@ -217,3 +217,13 @@ DEF_TEST(PathMeasureConic, reporter) { REPORTER_ASSERT(reporter, 19.5f < stdP.fX && stdP.fX < 20.5f); REPORTER_ASSERT(reporter, 19.5f < hiP.fX && hiP.fX < 20.5f); } + +// Regression test for b/26425223 +DEF_TEST(PathMeasure_nextctr, reporter) { + SkPath path; + path.moveTo(0, 0); path.lineTo(100, 0); + + SkPathMeasure meas(path, false); + // only expect 1 contour, even if we didn't explicitly call getLength() ourselves + REPORTER_ASSERT(reporter, !meas.nextContour()); +} -- cgit v1.2.3