From 5adaf8bf24e7581104c41c868188602624e8ba86 Mon Sep 17 00:00:00 2001 From: Mike Reed Date: Thu, 15 Dec 2016 13:02:33 -0500 Subject: remove unused dynamicwstream.snapshotAsData() Checking to invalidate this on every write() call has a measurable cost, so removing it both simplifies the class and speeds it up. BUG=skia: Change-Id: Idf0baa265c9a0b5d26d82fce948c61ed9b0810b1 Reviewed-on: https://skia-review.googlesource.com/6096 Reviewed-by: Ben Wagner Reviewed-by: Mike Klein Commit-Queue: Mike Reed --- tests/PDFGlyphsToUnicodeTest.cpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'tests/PDFGlyphsToUnicodeTest.cpp') diff --git a/tests/PDFGlyphsToUnicodeTest.cpp b/tests/PDFGlyphsToUnicodeTest.cpp index b3ee2d86f2..a256c93a8d 100644 --- a/tests/PDFGlyphsToUnicodeTest.cpp +++ b/tests/PDFGlyphsToUnicodeTest.cpp @@ -15,14 +15,19 @@ static const int kMaximumGlyphCount = SK_MaxU16 + 1; static bool stream_equals(const SkDynamicMemoryWStream& stream, size_t offset, const char* buffer, size_t len) { - sk_sp data = stream.snapshotAsData(); - if (offset + len > data->size()) { + if (len != strlen(buffer)) { return false; } - if (len != strlen(buffer)) { + + const size_t streamSize = stream.bytesWritten(); + + if (offset + len > streamSize) { return false; } - return memcmp(data->bytes() + offset, buffer, len) == 0; + + SkAutoTMalloc data(streamSize); + stream.copyTo(data.get()); + return memcmp(data.get() + offset, buffer, len) == 0; } DEF_TEST(SkPDF_ToUnicode, reporter) { -- cgit v1.2.3