From 5a2e50edc51006ce91366e177a9d21a16775d7fd Mon Sep 17 00:00:00 2001 From: Mike Reed Date: Mon, 2 Oct 2017 13:44:11 +0000 Subject: Revert "Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap""" This reverts commit cd284c532376d16fcc4ed75baf3da65c3e4a2e95. Reason for revert: assert fired in SkMallocPixelRef.cpp:61: fatal error: "assert(info.computeByteSize(rowBytes) == info.getSafeSize(rowBytes))" google3 thinks it was from surface_rowbytes Original change's description: > Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"" > > This reverts commit 809cbedd4b252be221b2ac3b4269d312fd8f53a0. > > Bug: skia: > Change-Id: I680d8daeeeeb15526b44c1305d8fb0c6bfa38e1d > Reviewed-on: https://skia-review.googlesource.com/52665 > Commit-Queue: Mike Reed > Reviewed-by: Florin Malita TBR=fmalita@chromium.org,reed@google.com Change-Id: I41e3f7a3f791cc8183291847e783ed8a53bc91d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/53802 Reviewed-by: Mike Reed Commit-Queue: Mike Reed --- tests/MallocPixelRefTest.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'tests/MallocPixelRefTest.cpp') diff --git a/tests/MallocPixelRefTest.cpp b/tests/MallocPixelRefTest.cpp index ac080994e2..957c8b3948 100644 --- a/tests/MallocPixelRefTest.cpp +++ b/tests/MallocPixelRefTest.cpp @@ -32,7 +32,7 @@ DEF_TEST(MallocPixelRef, reporter) { } { size_t rowBytes = info.minRowBytes() - 1; - size_t size = info.computeByteSize(rowBytes); + size_t size = info.getSafeSize(rowBytes); sk_sp data(SkData::MakeUninitialized(size)); sk_sp pr( SkMallocPixelRef::MakeWithData(info, rowBytes, data)); @@ -41,7 +41,7 @@ DEF_TEST(MallocPixelRef, reporter) { } { size_t rowBytes = info.minRowBytes() + 2; - size_t size = info.computeByteSize(rowBytes) - 1; + size_t size = info.getSafeSize(rowBytes) - 1; sk_sp data(SkData::MakeUninitialized(size)); sk_sp pr( SkMallocPixelRef::MakeWithData(info, rowBytes, data)); @@ -49,7 +49,7 @@ DEF_TEST(MallocPixelRef, reporter) { REPORTER_ASSERT(reporter, nullptr == pr.get()); } size_t rowBytes = info.minRowBytes() + 7; - size_t size = info.computeByteSize(rowBytes) + 9; + size_t size = info.getSafeSize(rowBytes) + 9; { SkAutoMalloc memory(size); sk_sp pr( -- cgit v1.2.3