From 32a4910e57b1fdd3c8671de1ee85e05ca21d079f Mon Sep 17 00:00:00 2001 From: Cary Clark Date: Sun, 20 May 2018 23:15:43 +0000 Subject: Revert "remove toString" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 5191880cbf3ee4d122b0d11b4945fbab0784fda7. Reason for revert: broke flutter Original change's description: > remove toString > > toString may have been used by obsolete debugger only > find out if that is so > > R=​brianosman@google.com,bsalomon@google.com > > Docs-Preview: https://skia.org/?cl=119894 > Bug:830651 > Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd > Reviewed-on: https://skia-review.googlesource.com/119894 > Commit-Queue: Cary Clark > Reviewed-by: Brian Salomon TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org Change-Id: I9f81de6c3615ee0608bcea9081b77239b4b8816c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830651 Reviewed-on: https://skia-review.googlesource.com/129340 Reviewed-by: Cary Clark Commit-Queue: Cary Clark --- tests/ImageFilterTest.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'tests/ImageFilterTest.cpp') diff --git a/tests/ImageFilterTest.cpp b/tests/ImageFilterTest.cpp index b57af7f30b..8e46715fbb 100644 --- a/tests/ImageFilterTest.cpp +++ b/tests/ImageFilterTest.cpp @@ -59,6 +59,7 @@ public: return sk_sp(new MatrixTestImageFilter(reporter, expectedMatrix)); } + void toString(SkString* str) const override; SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(MatrixTestImageFilter) protected: @@ -102,6 +103,7 @@ public: return nullptr; } + void toString(SkString* str) const override; SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(FailImageFilter) private: @@ -113,6 +115,11 @@ sk_sp FailImageFilter::CreateProc(SkReadBuffer& buffer) { return sk_sp(new FailImageFilter()); } +void FailImageFilter::toString(SkString* str) const { + str->appendf("FailImageFilter: ("); + str->append(")"); +} + void draw_gradient_circle(SkCanvas* canvas, int width, int height) { SkScalar x = SkIntToScalar(width / 2); SkScalar y = SkIntToScalar(height / 2); @@ -290,6 +297,7 @@ public: : SkImageFilter(nullptr, 0, nullptr), fBounds(bounds) {} private: + void toString(SkString*) const override {} Factory getFactory() const override { return nullptr; } sk_sp onFilterImage(SkSpecialImage* src, const Context&, @@ -312,6 +320,11 @@ sk_sp MatrixTestImageFilter::CreateProc(SkReadBuffer& buffer) { return nullptr; } +void MatrixTestImageFilter::toString(SkString* str) const { + str->appendf("MatrixTestImageFilter: ("); + str->append(")"); +} + static sk_sp make_small_image() { auto surface(SkSurface::MakeRasterN32Premul(kBitmapSize, kBitmapSize)); SkCanvas* canvas = surface->getCanvas(); @@ -1863,6 +1876,8 @@ DEF_TEST(ImageFilterColorSpaceDAG, reporter) { public: TestFilter() : INHERITED(nullptr, 0, nullptr) {} + void toString(SkString*) const override {} + Factory getFactory() const override { return nullptr; } size_t cloneCount() const { return fCloneCount; } -- cgit v1.2.3