From 2f924b4b0e5d364d608e181da8270241038de6c9 Mon Sep 17 00:00:00 2001 From: Florin Malita Date: Wed, 19 Jul 2017 10:16:59 -0400 Subject: Use raster pipeline for repeat/mirror radial gradients The legacy clamp specialization is still faster, but for repeat and mirror RP wins (at low color stop counts). Change-Id: Ifef3eb5b3111b3741d3a033310a4cdb58e592247 Reviewed-on: https://skia-review.googlesource.com/24283 Reviewed-by: Mike Reed Commit-Queue: Florin Malita --- src/shaders/gradients/SkRadialGradient.cpp | 15 ++++++++++++++- src/shaders/gradients/SkRadialGradient.h | 6 ++++-- 2 files changed, 18 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/shaders/gradients/SkRadialGradient.cpp b/src/shaders/gradients/SkRadialGradient.cpp index 0a6a940b18..658ee55d3a 100644 --- a/src/shaders/gradients/SkRadialGradient.cpp +++ b/src/shaders/gradients/SkRadialGradient.cpp @@ -48,7 +48,11 @@ SkShaderBase::Context* SkRadialGradient::onMakeContext( SkRadialGradient::RadialGradientContext::RadialGradientContext( const SkRadialGradient& shader, const ContextRec& rec) - : INHERITED(shader, rec) {} + : INHERITED(shader, rec) { +#ifndef SK_SUPPORT_LEGACY_RADIAL_GRADIENT + SkASSERT(shader.getTileMode() == SkShader::kClamp_TileMode); +#endif +} SkShader::GradientType SkRadialGradient::asAGradient(GradientInfo* info) const { if (info) { @@ -359,6 +363,15 @@ sk_sp SkRadialGradient::onMakeColorSpace(SkColorSpaceXformer* xformer) &this->getLocalMatrix()); } +bool SkRadialGradient::onIsRasterPipelineOnly() const { +#ifdef SK_SUPPORT_LEGACY_RADIAL_GRADIENT + return false; +#else + // We have a clamp fast path; everything else -> RP. + return fTileMode != SkShader::kClamp_TileMode; +#endif +} + bool SkRadialGradient::adjustMatrixAndAppendStages(SkArenaAlloc* alloc, SkMatrix* matrix, SkRasterPipeline* p, diff --git a/src/shaders/gradients/SkRadialGradient.h b/src/shaders/gradients/SkRadialGradient.h index c0353cf153..f85bc8e53a 100644 --- a/src/shaders/gradients/SkRadialGradient.h +++ b/src/shaders/gradients/SkRadialGradient.h @@ -10,7 +10,7 @@ #include "SkGradientShaderPriv.h" -class SkRadialGradient : public SkGradientShaderBase { +class SkRadialGradient final : public SkGradientShaderBase { public: SkRadialGradient(const SkPoint& center, SkScalar radius, const Descriptor&); @@ -41,7 +41,9 @@ protected: bool adjustMatrixAndAppendStages(SkArenaAlloc* alloc, SkMatrix* matrix, SkRasterPipeline* tPipeline, - SkRasterPipeline* postPipeline) const final; + SkRasterPipeline* postPipeline) const override; + + bool onIsRasterPipelineOnly() const override; private: const SkPoint fCenter; -- cgit v1.2.3