From 92e37b6d79f12ccfaaf7671413316952d182267d Mon Sep 17 00:00:00 2001 From: Cary Clark Date: Wed, 23 May 2018 08:02:27 -0400 Subject: Reland "remove toString" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 32a4910e57b1fdd3c8671de1ee85e05ca21d079f. Reason for revert: SkMatrix::toString use has been removed from flutter and has been picked up in fuchsia Original change's description: > Revert "remove toString" > > This reverts commit 5191880cbf3ee4d122b0d11b4945fbab0784fda7. > > Reason for revert: broke flutter > > Original change's description: > > remove toString > > > > toString may have been used by obsolete debugger only > > find out if that is so > > > > R=​brianosman@google.com,bsalomon@google.com > > > > Docs-Preview: https://skia.org/?cl=119894 > > Bug:830651 > > Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd > > Reviewed-on: https://skia-review.googlesource.com/119894 > > Commit-Queue: Cary Clark > > Reviewed-by: Brian Salomon > > TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org > > Change-Id: I9f81de6c3615ee0608bcea9081b77239b4b8816c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 830651 > Reviewed-on: https://skia-review.googlesource.com/129340 > Reviewed-by: Cary Clark > Commit-Queue: Cary Clark TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 830651 Change-Id: Ida8725b6051132d8c46faf99358a8fcc1bcabf34 Reviewed-on: https://skia-review.googlesource.com/129623 Reviewed-by: Cary Clark Reviewed-by: Cary Clark Commit-Queue: Cary Clark --- src/utils/SkShadowUtils.cpp | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/utils') diff --git a/src/utils/SkShadowUtils.cpp b/src/utils/SkShadowUtils.cpp index dfd5ba4886..f0b1e8f4d7 100644 --- a/src/utils/SkShadowUtils.cpp +++ b/src/utils/SkShadowUtils.cpp @@ -45,7 +45,6 @@ public: GrContext*, const GrColorSpaceInfo&) const override; #endif - void toString(SkString* str) const override; SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkGaussianColorFilter) protected: @@ -64,10 +63,6 @@ sk_sp SkGaussianColorFilter::CreateProc(SkReadBuffer&) { return Make(); } -void SkGaussianColorFilter::toString(SkString* str) const { - str->append("SkGaussianColorFilter "); -} - #if SK_SUPPORT_GPU std::unique_ptr SkGaussianColorFilter::asFragmentProcessor( -- cgit v1.2.3