From 38f118a2e7f986b06d69d0af41ec2d1af53dac39 Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Thu, 28 Jun 2018 18:04:02 -0400 Subject: update and skip accepts check in lexers We think we're getting away with this because our tokens never go from legal to illegal to legal again, right? Change-Id: Iaaef797f7c4b487ba7b1d0e018846bd13086b34c Reviewed-on: https://skia-review.googlesource.com/138275 Auto-Submit: Mike Klein Commit-Queue: Ethan Nicholas Reviewed-by: Ethan Nicholas --- src/sksl/SkSLLexer.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/sksl/SkSLLexer.cpp') diff --git a/src/sksl/SkSLLexer.cpp b/src/sksl/SkSLLexer.cpp index 44ebdcad1e..5bb970a627 100644 --- a/src/sksl/SkSLLexer.cpp +++ b/src/sksl/SkSLLexer.cpp @@ -957,7 +957,8 @@ Token Lexer::next() { if (!state) { break; } - if (accepts[state]) { + // We seem to be getting away without doing this check. + /*if (accepts[state] != -1)*/ { lastAccept = (Token::Kind)accepts[state]; lastAcceptEnd = offset; } @@ -966,4 +967,4 @@ Token Lexer::next() { return Token(lastAccept, startOffset, lastAcceptEnd - startOffset); } -} // namespace +} // namespace SkSL -- cgit v1.2.3