From 3f9855293350bd1949855a6002943d3cef97a32f Mon Sep 17 00:00:00 2001 From: Ben Wagner Date: Mon, 9 Oct 2017 10:47:47 -0400 Subject: Small pathops cleanup. Newer clang compiler produces the diagnostic ../../tests/PathOpsDebug.cpp:1349:44: error: comparison of unsigned enum expression >= 0 is always true [-Werror,-Wtautological-unsigned-enum-zero-compare] if (!firstOp && c->operand() && op >= 0) { The check seems to be defending against bad values of SkPathOp, but this now seems unnecessary. This also adds 'rdiff' to kPathOpStr for future debugging. Change-Id: I08e5ba77c56e519ce4d9ae89491f7ccd5eb7f944 Reviewed-on: https://skia-review.googlesource.com/57104 Reviewed-by: Cary Clark Commit-Queue: Ben Wagner --- src/pathops/SkPathOpsDebug.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/pathops') diff --git a/src/pathops/SkPathOpsDebug.cpp b/src/pathops/SkPathOpsDebug.cpp index b3ca85210b..f13b958a84 100644 --- a/src/pathops/SkPathOpsDebug.cpp +++ b/src/pathops/SkPathOpsDebug.cpp @@ -42,7 +42,7 @@ int SkPathOpsDebug::gSortCount; #endif #if DEBUG_ACTIVE_OP -const char* SkPathOpsDebug::kPathOpStr[] = {"diff", "sect", "union", "xor"}; +const char* SkPathOpsDebug::kPathOpStr[] = {"diff", "sect", "union", "xor", "rdiff"}; #endif #if defined SK_DEBUG || !FORCE_RELEASE -- cgit v1.2.3