From 12dfaaa53c23f3d03050bde8f64136ac1f44164a Mon Sep 17 00:00:00 2001 From: mtklein Date: Tue, 7 Jun 2016 09:35:27 -0700 Subject: Move immintrin/arm_neon includes to where they are used. On my Mac (so, immintrin), this improves compile time, both wall and cpu, by about 16%. To test I ran this on an SSD with files hot in their caches: $ env CC=/usr/bin/clang CXX=/usr/bin/clang++ ./gyp_skia && \ ninja -C out/Release -t clean && \ time ninja -C out/Release Before: 159 wall / 3367 cpu 159 wall / 3368 cpu After: 137 wall / 2860 cpu 136 wall / 2863 cpu I also tried further refining immintrin down to emmintrin / tmmintrin / smmintrin etc. That made no signficant difference, so I've kept immintrin for its simplicity. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2045633002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot TBR=reed@google.com No public API changes. Review-Url: https://codereview.chromium.org/2045633002 --- src/opts/SkNx_sse.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/opts/SkNx_sse.h') diff --git a/src/opts/SkNx_sse.h b/src/opts/SkNx_sse.h index 1fc235d99b..0b22a5a3c6 100644 --- a/src/opts/SkNx_sse.h +++ b/src/opts/SkNx_sse.h @@ -9,6 +9,7 @@ #define SkNx_sse_DEFINED #include "SkCpu.h" +#include // This file may assume <= SSE2, but must check SK_CPU_SSE_LEVEL for anything more recent. // If you do, make sure this is in a static inline function... anywhere else risks violating ODR. -- cgit v1.2.3