From be22636c3d9e8d73dd408c241c183e923e149574 Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Tue, 12 Dec 2017 11:30:36 -0500 Subject: a little SkJumper tidy up I noticed these little bits while working on that old-Clang fix. - We can force-inline anytime we've got Clang, not just when JUMPER_IS_OFFLINE. - The _aarch64 and _vfp4 WRAP functions are dead code, as they're never compiled offline now. Change-Id: I5850daded2ffcfe50ceeadc43f89fa8597df3387 Reviewed-on: https://skia-review.googlesource.com/84060 Commit-Queue: Mike Klein Commit-Queue: Florin Malita Reviewed-by: Florin Malita --- src/jumper/SkJumper_misc.h | 2 +- src/jumper/SkJumper_stages.cpp | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) (limited to 'src/jumper') diff --git a/src/jumper/SkJumper_misc.h b/src/jumper/SkJumper_misc.h index 59dfd65ab0..4aa88aafb0 100644 --- a/src/jumper/SkJumper_misc.h +++ b/src/jumper/SkJumper_misc.h @@ -13,7 +13,7 @@ // Miscellany used by SkJumper_stages.cpp and SkJumper_vectors.h. // Every function in this file should be marked static and inline using SI. -#if defined(JUMPER_IS_OFFLINE) +#if defined(__clang__) #define SI __attribute__((always_inline)) static inline #else #define SI static inline diff --git a/src/jumper/SkJumper_stages.cpp b/src/jumper/SkJumper_stages.cpp index f20eb83377..e7ffe6bbff 100644 --- a/src/jumper/SkJumper_stages.cpp +++ b/src/jumper/SkJumper_stages.cpp @@ -20,10 +20,6 @@ static const size_t N = sizeof(F) / sizeof(float); // That lets us link together several options. #if !defined(JUMPER_IS_OFFLINE) #define WRAP(name) sk_##name -#elif defined(__aarch64__) - #define WRAP(name) sk_##name##_aarch64 -#elif defined(__arm__) - #define WRAP(name) sk_##name##_vfp4 #elif defined(__AVX512F__) #define WRAP(name) sk_##name##_skx #elif defined(__AVX2__) -- cgit v1.2.3